#
#asahi-gpu · 2023-07-25 12:01
lina*Âno16
#asahi-gpu · 2023-07-25 12:01
linaThat DID fix it *together* with fp16
#asahi-gpu · 2023-07-25 12:01
alyssagg
#asahi-gpu · 2023-07-25 12:01
alyssameanwhile my submit refactor thing seems to break both firefox and chrome, brrrr
#asahi-gpu · 2023-07-25 11:59
alyssawait-waits
#asahi-gpu · 2023-07-25 11:59
linawait wait
#asahi-gpu · 2023-07-25 11:57
alyssaIt does reek of fp16 coord bugs so idk
#asahi-gpu · 2023-07-25 11:57
alyssaIDK
#asahi-gpu · 2023-07-25 11:57
alyssaK
#asahi-gpu · 2023-07-25 11:56
linaalyssa: No change
#asahi-gpu · 2023-07-25 11:54
alyssayou'll wan tto comment out the nir_lower_mediump_io call in agx_compile.c for that
#asahi-gpu · 2023-07-25 11:54
linaOh...
#asahi-gpu · 2023-07-25 11:54
alyssathe backend AGX compiler may still choose to do itself regardless of flag
#asahi-gpu · 2023-07-25 11:54
alyssano16 tells the GLSL compiler not to generate fp16 instructions
#asahi-gpu · 2023-07-25 11:53
alyssano16 doesn't fully disable fp16
#asahi-gpu · 2023-07-25 11:53
alyssa11:51 lina | "fp16" you say, but "no16" doesn't fix it!
#asahi-gpu · 2023-07-25 11:53
alyssaI do remember hitting that once
#asahi-gpu · 2023-07-25 11:53
linaIt could also be that it's intended to be point sampling and it's the linear sampling that shouldn't be there...
#asahi-gpu · 2023-07-25 11:51
lina"fp16" you say, but "no16" doesn't fix it!
#asahi-gpu · 2023-07-25 11:51
linaIt looks like it's sampling a texture linearly with texcoords that are noticeably off or something like that
#asahi-gpu · 2023-07-25 11:50
linaalyssa: Unrelated, but have you seen the Google Sheets issue? I haven't had a chance to look at it yet, just curious whether you have any ideas. Basically as you scroll the visible parts of the canvas gets seriously blurred proportional to the distance to cell A1.
#asahi-gpu · 2023-07-25 11:46
alyssahavent' decided how I want to untangle that yet
#asahi-gpu · 2023-07-25 11:46
alyssayeah..
#asahi-gpu · 2023-07-25 11:46
linaOops ^^
#asahi-gpu · 2023-07-25 11:45
alyssa(turns out I unwittingly hardcoded a GLism)
#asahi-gpu · 2023-07-25 11:45
alyssabut AGXV needs that too so.. not a loss :>
#asahi-gpu · 2023-07-25 11:45
alyssaannoying one will be rewriting a big chunk of resource management code
#asahi-gpu · 2023-07-25 11:45
alyssait turns out there are a lot of yaks I need to shave :>
#asahi-gpu · 2023-07-25 11:40
alyssabut if you're going to rework the code rather than merge what I have, might be worth architecting around those cases too? idk
#asahi-gpu · 2023-07-25 11:40
alyssashhhh
#asahi-gpu · 2023-07-25 11:40
lina"secret" project ^^
#asahi-gpu · 2023-07-25 11:39
alyssaI don't need that for my secret project
#asahi-gpu · 2023-07-25 11:39
alyssaYeah, makes sense
#asahi-gpu · 2023-07-25 11:39
linaBasically when flushing writers we'd batch up all the submits and send it all at once
#asahi-gpu · 2023-07-25 11:39
linaE.g. when doing mipmap gen we can totally do that
#asahi-gpu · 2023-07-25 11:39
linaYeah, there was always room for that
#asahi-gpu · 2023-07-25 11:38
alyssa(potentiallly even submitting multiple batches at once to reduce user/kernel roundtrips)
#asahi-gpu · 2023-07-25 11:38
alyssabut I can imagine a lot of optimizations where we'd want the more general thing
#asahi-gpu · 2023-07-25 11:37
alyssacurrently the only new requirement is combined CDM+VDM submit for graphics batches
#asahi-gpu · 2023-07-25 11:37
alyssaif you hate the code and would rather rewrite yourself given the new requirements I'm fine with that outcome too ;)
#asahi-gpu · 2023-07-25 11:36
alyssaYep~!
#asahi-gpu · 2023-07-25 11:35
linaWhat I said with the barriers works right?
#asahi-gpu · 2023-07-25 11:35
linaalyssa: Sure ^^
#asahi-gpu · 2023-07-25 11:34
alyssaI could see this interfacing needing to be extended yet again for efficient mipmap generation (with the blit PDM queue?)
#asahi-gpu · 2023-07-25 11:34
alyssabe able to queue up arbitrary sequences of VDM and CDM work
#asahi-gpu · 2023-07-25 11:34
alyssai'm also unsure if we want to go further than that
#asahi-gpu · 2023-07-25 11:33
alyssa2. it's mucking with UAPI bits and I don't have a ton of confidence in my ability to get the logic right, so I do need an actual review from you and not a rubberstamp ;)
#asahi-gpu · 2023-07-25 11:33
alyssa1. it's churny around UAPI bits so I expect it will conflict badly with whatever you work on next, better merge it sooner then ;)
#asahi-gpu · 2023-07-25 11:32
alyssalina: when you get a chance, could you prioritize review of https://gitlab.freedesktop.org/asahi/mesa/-/merge_requests/111 ? it's not too big, but
#asahi-gpu · 2023-07-23 17:21
alyssa:+1:

plus ›