#
#asahi-gpu · 2023-08-26 22:14
i509vcbI've been working through it and I feel I have something nearly done
#asahi-gpu · 2023-08-26 22:14
i509vcbok
#asahi-gpu · 2023-08-26 22:14
alyssaThat's the absolute easiest approach
#asahi-gpu · 2023-08-26 22:14
alyssai509vcb: The details are up to you
#asahi-gpu · 2023-08-26 19:19
i509vcbs/than/then
#asahi-gpu · 2023-08-26 19:17
i509vcbWas the intention that when I lay out uniforms I just reserve a spot for a uint64_t that is a gpu pointer to the uploaded agxv_sysvals_graphics/compute? and then just have the buffers to be bound just appear after than in the uniform registers?
#asahi-gpu · 2023-08-26 19:08
i509vcbfor GL you don't seem to record what sysval is at what offset or which ones were encountered?
#asahi-gpu · 2023-08-26 19:07
i509vcbalyssa: poke on question above
#asahi-gpu · 2023-08-25 15:03
i509vcbThis seems to imply that I'd need to still have a bunch of has_whatever fields and bases in another type?
#asahi-gpu · 2023-08-25 15:03
i509vcb> agx_usc_uniform is then used to copy from that struct to uniform registers according to the layout that you picked earlier.
#asahi-gpu · 2023-08-25 14:24
i509vcbSmithay is definitely better now but I am still a annoyed by all the Arc<Mutex<T>> abuse we need
#asahi-gpu · 2023-08-25 14:23
i509vcbSadly Deref is an escape route
#asahi-gpu · 2023-08-25 14:23
i509vcbI've had the opinion that rust punishes bad architecture
#asahi-gpu · 2023-08-25 14:22
rosefromthedeadyeah, iirc bevy just invested in Deref abuse and gave up on "doing things right" because it can make apis so much nicer
#asahi-gpu · 2023-08-25 14:21
i509vcbCertainly not as bad as some cases I've seen where people have done inheritence via that...
#asahi-gpu · 2023-08-25 14:20
i509vcbI guess Into<u64> if you really need the raw value
#asahi-gpu · 2023-08-25 14:20
i509vcbYeah probably a bit of Deref abuse there
#asahi-gpu · 2023-08-25 13:37
rosefromthedeads/deref/use std::ops::Deref/
#asahi-gpu · 2023-08-25 13:37
rosefromthedeadah, the old "you shouldn't deref for polymorphism even though it makes everyone's life easier"
#asahi-gpu · 2023-08-25 13:21
i509vcbAnd then implement Deref<Self::Target = u64> for GpuPtr
#asahi-gpu · 2023-08-25 13:20
i509vcbYeah in rust I'd probably make a newtype for that
#asahi-gpu · 2023-08-25 10:52
alyssait would be a lot more useful in rust.
#asahi-gpu · 2023-08-25 10:51
alyssai509vcb: certainly it's possible to do that, for panfrost I used the `mali_ptr` typedef for that ... it's not as useful as it seems, though, since C will do implicit casting between u64 and agx_gpu_ptr so the type annotation becomes a purely optional hint
#asahi-gpu · 2023-08-25 04:19
i509vcbCould there be any stylistic improvement to have a sort of "agx_gpu_ptr" typedef to make it more clear that a uint64_t should be semantically treated as a gpu pointer in code?
#asahi-gpu · 2023-08-24 18:03
alyssathx
#asahi-gpu · 2023-08-24 18:02
ella-0alyssa: will have a look
#asahi-gpu · 2023-08-24 17:51
alyssathanks :)
#asahi-gpu · 2023-08-24 17:51
alyssaella-0: please weigh in on https://gitlab.freedesktop.org/asahi/mesa/-/merge_requests/172#note_2057894
#asahi-gpu · 2023-08-24 17:08
ella-0i509vcb: pushed that meta stuff see https://gitlab.freedesktop.org/asahi/mesa/-/merge_requests/173
#asahi-gpu · 2023-08-23 23:10
alyssai509vcb: :)
#asahi-gpu · 2023-08-23 22:58
i509vcbs/intrinsic/sysval
#asahi-gpu · 2023-08-23 22:47
i509vcb(now I see why the gallium driver doesn't lower every intrinsic the same way)
#asahi-gpu · 2023-08-23 22:34
i509vcbI'll do that later
#asahi-gpu · 2023-08-23 22:34
i509vcbAnd I realize I did not consider indirect yet in my MR
#asahi-gpu · 2023-08-23 22:05
ella-0i509vcb: yeah I have those save/restore stuff locally since it was causing some issues with occlusion query tests. will push tomorrow.
#asahi-gpu · 2023-08-23 21:31
alyssai509vcb: specifically, see nvk_meta_begin/nvk_meta_end
#asahi-gpu · 2023-08-23 21:31
alyssasee how NVK does it
#asahi-gpu · 2023-08-23 21:31
alyssawe need to do meta save/restore
#asahi-gpu · 2023-08-23 21:31
alyssaoh, yeah
#asahi-gpu · 2023-08-23 21:30
i509vcbat least one is done
#asahi-gpu · 2023-08-23 21:29
i509vcbs/unsued/unused
#asahi-gpu · 2023-08-23 21:29
i509vcbI guess all the stuff I built to make the sysval stuff expansible in the future is going to sit unsued for a bit...
#asahi-gpu · 2023-08-23 21:28
i509vcbit clobbers the currently bound pipeline
#asahi-gpu · 2023-08-23 21:28
i509vcbHmm I seem to have found a problem with the vk_meta_copy stuff
#asahi-gpu · 2023-08-23 21:24
alyssaWoo!
#asahi-gpu · 2023-08-23 20:57
i509vcbOk now it passes
#asahi-gpu · 2023-08-23 20:53
i509vcbnope premature victory it passes some of the tests...
#asahi-gpu · 2023-08-23 20:50
i509vcbalyssa: thank you for the help so far
#asahi-gpu · 2023-08-23 20:50
i509vcbWell dEQP-VK.compute.builtin_var.num_work_groups passes
#asahi-gpu · 2023-08-23 20:50
i509vcbFound my problem, forgot to copy a struct...

plus ›