#
#asahi-gpu · 2023-09-04 18:29
alyssathe issue is that the base address MUST come from a uniform, it CANNOT come from registers
#asahi-gpu · 2023-09-04 18:29
alyssaI don't have a great alternative right now
#asahi-gpu · 2023-09-04 18:28
alyssawhich hard-requires the driver to fix the uniform layout, and is different from how we handle every other uniform
#asahi-gpu · 2023-09-04 18:28
alyssaCurrently we're representing a bindless table at uniform u0_u1 with a literal constant #0 in the shader
#asahi-gpu · 2023-09-04 18:27
i509vcbI am entirely lost there
#asahi-gpu · 2023-09-04 18:27
i509vcb> I probably need to change how this works in the compiler don't I
#asahi-gpu · 2023-09-04 18:27
alyssasure
#asahi-gpu · 2023-09-04 18:27
i509vcbI can see that I'd need to upload the texture descriptors when descriptor sets are bound
#asahi-gpu · 2023-09-04 18:22
alyssaI probably need to change how this works in the compiler don't I.
#asahi-gpu · 2023-09-04 18:22
alyssahmm
#asahi-gpu · 2023-09-04 18:21
alyssahm
#asahi-gpu · 2023-09-04 18:21
alyssaProbably I should figure out a way to avoid that.
#asahi-gpu · 2023-09-04 18:21
alyssamanually assigning uniforms
#asahi-gpu · 2023-09-04 18:21
alyssaagx_root_sysvals doesn't get this array, you need to special case it unfortunately
#asahi-gpu · 2023-09-04 18:20
alyssaoh, umm, scratch what I said about agx_root_sysvals
#asahi-gpu · 2023-09-04 18:20
alyssa* Image instructions in the shader are lowered to bindless, where the bindless handle is (uniform index for the descriptor set, offset for the binding * 24)
#asahi-gpu · 2023-09-04 18:19
alyssa* agx_root_sysvals[] gains a pointer to the texture desc array for each set
#asahi-gpu · 2023-09-04 18:19
alyssaAnyway, the texture descriptor array is per-descriptor set and uploaded
#asahi-gpu · 2023-09-04 18:18
alyssaThat might be better for cache efficiency maybe, idk
#asahi-gpu · 2023-09-04 18:18
alyssaAlternatively you can compact things per-descriptor set and fix up when lowering the shader
#asahi-gpu · 2023-09-04 18:18
alyssaIdeally, this is indexed directly by the BINDING (and multiplied by a stride of AGX_TEXTURE_LENGTH == 24 bytes)
#asahi-gpu · 2023-09-04 18:17
alyssa* Each descriptor set gets an array of texture/image descriptors associated with it.
#asahi-gpu · 2023-09-04 18:17
alyssaI think you want something roughly like:
#asahi-gpu · 2023-09-04 18:16
i509vcbokay red herring then
#asahi-gpu · 2023-09-04 18:16
alyssapanvk does not do that, no
#asahi-gpu · 2023-09-04 18:15
i509vcb(Descriptor set accesses pretty much)
#asahi-gpu · 2023-09-04 18:15
i509vcbalyssa: for lowering all texture/image instructions to bindless, panvk appears to do something similar to that?
#asahi-gpu · 2023-09-04 16:41
alyssanya~
#asahi-gpu · 2023-09-04 16:00
linaOur numbers will only grow~
#asahi-gpu · 2023-09-04 16:00
linamay or may not have plans to teach another catgirl programming...
#asahi-gpu · 2023-09-04 15:41
ella-0eric_engestrom: VK_DRIVER_ID_MESA_AGXV is more inline with the other drivers so that I guess
#asahi-gpu · 2023-09-04 15:38
alyssamary gets it
#asahi-gpu · 2023-09-04 15:38
MaryVK_DRIVER_ID_MESA_NYASAHI
#asahi-gpu · 2023-09-04 15:35
alyssaVK_DRIVER_ID_MESA_CATGIRLZ_NYA it is
#asahi-gpu · 2023-09-04 15:26
linaWhatever works! ^^
#asahi-gpu · 2023-09-04 15:05
eric_engestromI'll wait 24h to give a chance to everyone regardless of their timezone :)
#asahi-gpu · 2023-09-04 15:05
eric_engestromsounds good :)
#asahi-gpu · 2023-09-04 15:05
alyssaneutral
#asahi-gpu · 2023-09-04 15:05
alyssa3Cneutral
#asahi-gpu · 2023-09-04 14:59
MaryI would say AGXV on my side
#asahi-gpu · 2023-09-04 13:58
eric_engestromsee https://github.com/KhronosGroup/Vulkan-Headers/blob/main/include/vulkan/vulkan_core.h#L5773 for existing ones
#asahi-gpu · 2023-09-04 13:58
eric_engestromella-0, alyssa, (lina if you have an opinion): I'm going to request a VK_DRIVER_ID_* for asahi/agxv; do you prefer VK_DRIVER_ID_MESA_ASAHI or VK_DRIVER_ID_MESA_AGXV (or something else?)
#asahi-gpu · 2023-09-03 17:23
alyssahmm, easy enough to do that second bit
#asahi-gpu · 2023-09-03 17:05
alyssaor at least get testing in the release tagging loop
#asahi-gpu · 2023-09-03 17:05
alyssawondering what the least invasive way to get no-nonsense asahi/mesa CI would be
#asahi-gpu · 2023-09-03 15:56
alyssajannau: tip, you can cat together all the caselists and do a single deqp-runner run
#asahi-gpu · 2023-09-03 15:56
alyssa:+1:
#asahi-gpu · 2023-09-03 15:39
jannaupasses deqp-runner deqp_{egl,es2,es3,es31} on m1 ultra. previously segfaulting programs still work
#asahi-gpu · 2023-09-03 15:16
alyssaCTS is running now
#asahi-gpu · 2023-09-03 15:16
alyssapushed asahi/main, please smoketest

plus ›