#
#asahi-gpu · 2024-01-05 11:05
alyssai509vcb: https://gitlab.freedesktop.org/i509VCB/mesa/-/commit/02528b81be23d2b71ad8542f1e66c286e13df83d#78939f2a54b94a5f882175ecc0ac1f25b521df38_367_394
#asahi-gpu · 2024-01-05 11:04
alyssain which case, drop the u2f32 (unsigned to float) conversion
#asahi-gpu · 2024-01-05 11:04
alyssaunless it's meant to be an integer
#asahi-gpu · 2024-01-05 11:03
alyssanir_fadd
#asahi-gpu · 2024-01-05 11:03
alyssai509vcb: https://gitlab.freedesktop.org/i509VCB/mesa/-/commit/02528b81be23d2b71ad8542f1e66c286e13df83d#ccd82ce6d5431b9371915af7969698022e62444e_120_121
#asahi-gpu · 2024-01-05 04:05
i509vcbI think I might have forgotten something, but I think this is all the compiler related stuff for layers: https://gitlab.freedesktop.org/i509VCB/mesa/-/commit/02528b81be23d2b71ad8542f1e66c286e13df83d
#asahi-gpu · 2024-01-04 23:11
alyssagrep nouveau/vulkan for load_layer_id to see how
#asahi-gpu · 2024-01-04 23:10
alyssas/the driver/agxv/
#asahi-gpu · 2024-01-04 23:10
alyssawhich we'll need to lower to load_input() in the driver
#asahi-gpu · 2024-01-04 23:10
alyssavk_meta_blit_resolve uses nir_load_layer_id
#asahi-gpu · 2024-01-04 23:10
alyssai509vcb: load the layer ID
#asahi-gpu · 2024-01-04 23:09
alyssano swizzling
#asahi-gpu · 2024-01-04 23:09
alyssai509vcb: vk copies are like memcpys
#asahi-gpu · 2024-01-04 22:46
i509vcbcan't get the instance id in a fragment shader...
#asahi-gpu · 2024-01-04 22:26
i509vcbvk_meta_draw_volume seems to do an instance per layer, I guess that's whats stopping 3D from working since I see nothing related to getting the instance number in the shader so far
#asahi-gpu · 2024-01-04 21:20
i509vcbhmm no swizzle needed
#asahi-gpu · 2024-01-04 20:37
i509vcbI'll need to check (won't I need a swizzle for that), but I guess for that case it would make sense to have getting the copy format for snorm and sfloat formats be driver specific
#asahi-gpu · 2024-01-04 20:18
alyssashould be compatible with e.g. rgba8_unorm?
#asahi-gpu · 2024-01-04 20:18
alyssai509vcb: what's wrong with bgra_snorm?
#asahi-gpu · 2024-01-04 20:06
i509vcbAh right compressed formats, let me see how many failures I get again if I turn those back on
#asahi-gpu · 2024-01-04 20:00
i509vcbM2 Air with 16GB of ram
#asahi-gpu · 2024-01-04 20:00
j`eyi509vcb: what machine are you using?
#asahi-gpu · 2024-01-04 19:58
alyssasigh
#asahi-gpu · 2024-01-04 19:57
i509vcbIt will probably take several hours to run when agxv is done enough to try to do a full cts run
#asahi-gpu · 2024-01-04 19:56
alyssa..and growing
#asahi-gpu · 2024-01-04 19:56
alyssathe full thing is millions of tests
#asahi-gpu · 2024-01-04 19:55
j`eydayum
#asahi-gpu · 2024-01-04 19:55
alyssaj`ey: the vulkan cts is.... intense.
#asahi-gpu · 2024-01-04 19:55
i509vcbgrepped out image_to_image in the api subgroup
#asahi-gpu · 2024-01-04 19:55
j`eythere's 50k tests in that subgroup?? or in total
#asahi-gpu · 2024-01-04 19:53
i509vcb(3d and stencil/depth are the largest groups I need to get fixed still)
#asahi-gpu · 2024-01-04 19:53
i509vcbFor dEQP-VK.api.copy_and_blit.core.image_to_image.*
#asahi-gpu · 2024-01-04 19:53
i509vcbPass: 8754, Fail: 372, Skip: 41386, Flake: 2, Duration: 3:10, Remaining: 0
#asahi-gpu · 2024-01-04 19:39
i509vcbstupid typo for r32g32b32a32
#asahi-gpu · 2024-01-04 18:47
i509vcbhttps://pixfmtdb.emersion.fr/VK_FORMAT_B8G8R8A8_SNORM seems to show it's not much and Zink docs doesn't seem to that format is needed
#asahi-gpu · 2024-01-04 18:44
i509vcbAlthough r32g32b32a32_sfloat has a hardware equvilant
#asahi-gpu · 2024-01-04 18:44
i509vcbr32g32b32a32_sfloat still fails for some weird reason
#asahi-gpu · 2024-01-04 18:43
i509vcbb8g8r8a8_snorm can't be copied via meta-copy
#asahi-gpu · 2024-01-04 18:42
j`eyi509vcb: nice going!
#asahi-gpu · 2024-01-04 18:42
i509vcbSadly a few formats always fail, I think the hardware has no SINT/UINT equivalent for these
#asahi-gpu · 2024-01-04 18:42
alyssai509vcb: awesome!
#asahi-gpu · 2024-01-04 18:42
i509vcbalyssa: yep I forgot that and that fixed nearly every failure
#asahi-gpu · 2024-01-04 13:09
alyssathen in agx.agxv_CmdEndRendering.0012, we're downloading flots as floats, again canonicalizing/flushing
#asahi-gpu · 2024-01-04 13:08
alyssain e.g. agx.agxv_CmdEndRendering.0002 we're uploading floats as floats so the NaNs are getting canonicalized (and denorms flushed)
#asahi-gpu · 2024-01-04 13:07
alyssai509vcb: You need to do the same snorm/float casting logic for CopyBufferToImage and for CopyImageToBuffer, otherwise those will canonicalize NaNs/-1.0 too
#asahi-gpu · 2024-01-04 03:26
i509vcbalyssa: ^
#asahi-gpu · 2024-01-04 03:24
i509vcbhttps://usercontent.irccloud-cdn.com/file/oktOpvbI/agxdecode-dEQP-VK.api.copy_and_blit.core.image_to_image.all_formats.color.2d_to_2d.b8g8r8a8_snorm.r16g16_sfloat.general_genera.zip
#asahi-gpu · 2024-01-04 01:41
alyssahappy to take a look at the trace
#asahi-gpu · 2024-01-04 01:41
alyssathanks
#asahi-gpu · 2024-01-04 01:41
i509vcbI'll grab that in a bit, gotta do something

plus ›