#asahi-gpu · 2022-10-27 02:21
LunaFoxgirlVT^•w•^#asahi-gpu · 2022-10-27 02:21
alyssaThere's precedent for G13P missing capabilities that G13G has, I think)#asahi-gpu · 2022-10-27 02:21
linaAnd at least a couple general bitmask like things with different values#asahi-gpu · 2022-10-27 02:21
phirethere were a few unks that flipped from 0 to 1#asahi-gpu · 2022-10-27 02:20
linaLet me look at what changed...#asahi-gpu · 2022-10-27 02:20
linaEither global or per batch#asahi-gpu · 2022-10-27 02:20
alyssathough maybe it's specced out for G13 but it's a model-specific feature bit#asahi-gpu · 2022-10-27 02:20
linaIt could be a config change#asahi-gpu · 2022-10-27 02:20
alyssaAlthough it does seem odd to change any of this *within* a major arch,#asahi-gpu · 2022-10-27 02:20
alyssaI could believe that#asahi-gpu · 2022-10-27 02:20
linaSo maybe intermediate Z flushes on Ultra using compression is a new G13X thing#asahi-gpu · 2022-10-27 02:20
alyssaright#asahi-gpu · 2022-10-27 02:20
linaBut I still haven't seen this on M1, only Ultra#asahi-gpu · 2022-10-27 02:19
alyssaThat seems plausible#asahi-gpu · 2022-10-27 02:19
alyssaOh, geez#asahi-gpu · 2022-10-27 02:19
linaYou just fault for a few frames iff the geometry is complex enough#asahi-gpu · 2022-10-27 02:19
linaAnd that's why it looks like it works#asahi-gpu · 2022-10-27 02:19
linaBut you're still faulting on intermediate flushes, before the TVB grows in Mesa, without the metadata buffer#asahi-gpu · 2022-10-27 02:18
linaSo you probably found the flag to make Z uncompressed on *final store*, and I am setting that right#asahi-gpu · 2022-10-27 02:18
linaSo only the intermediate flushes use the acceleration buffer!#asahi-gpu · 2022-10-27 02:17
linaalyssa: The depth buffer *is* written unconditionally. However, it's written uncompressed!#asahi-gpu · 2022-10-27 02:17
phirefinal output, and in-progress?#asahi-gpu · 2022-10-27 02:17
linaOhhh....#asahi-gpu · 2022-10-27 02:17
phireor there are two depth buffers?#asahi-gpu · 2022-10-27 02:17
linaOr... hold on.#asahi-gpu · 2022-10-27 02:14
linaMind you, the mesa I'm using for python testing is very outdated right now, so if you fixed this recently, that might explain it. Or I got the depth flags wrong.#asahi-gpu · 2022-10-27 02:14
alyssa2. Mesa is working ok, but your driver/Python isn't setting the right control register bits to make this work#asahi-gpu · 2022-10-27 02:13
alyssa1. I screwed up Mesa and this isn't working on macOS, but in that case I'd expect to see more CTS fails#asahi-gpu · 2022-10-27 02:13
alyssaSo I see two possibilities#asahi-gpu · 2022-10-27 02:13
alyssa(yes I know that's wasteful)#asahi-gpu · 2022-10-27 02:13
linaIt sure is with my bunny framedumps...#asahi-gpu · 2022-10-27 02:12
alyssaWith current Mesa, the intention is to always flush to RAM#asahi-gpu · 2022-10-27 02:12
alyssaThat's an optimization that gallium/asahi isn't doing yet, though.#asahi-gpu · 2022-10-27 02:12
alyssa02:11 < lina> If the app isn't actually reading out the depth buffer there is no need to flush it out to RAM#asahi-gpu · 2022-10-27 02:12
alyssaHm.#asahi-gpu · 2022-10-27 02:11
linaWith my bunny renders, the depth buffer is unwritten if I make the TVB large enough that it can render in a single pass, I only get data there if it ends up splitting due to a small TVB#asahi-gpu · 2022-10-27 02:11
linaIf the app isn't actually reading out the depth buffer there is no need to flush it out to RAM#asahi-gpu · 2022-10-27 02:10
alyssalina: sorry what?#asahi-gpu · 2022-10-27 02:10
alyssa02:10 < lina> Keep in mind that the depth buffer, unless the app really needs it, is only written to on TVB overflows#asahi-gpu · 2022-10-27 02:10
linaAnd those go away after a few frames#asahi-gpu · 2022-10-27 02:10
linaKeep in mind that the depth buffer, unless the app really needs it, is only written to on TVB overflows#asahi-gpu · 2022-10-27 02:09
phireoh, point. I should chuck this into the hypervisor later#asahi-gpu · 2022-10-27 02:09
linaphire: It "works" but it also faults sometimes. I did get frames out of it without the patch, but the hypervisor showed GPU faults.#asahi-gpu · 2022-10-27 01:34
alyssaPresumably#asahi-gpu · 2022-10-27 01:34
phireZLS = Z load store? #asahi-gpu · 2022-10-27 01:33
phireI guess all the depth stuff is already fixed-function anyway, due to the deferred shading nature#asahi-gpu · 2022-10-27 01:22
alyssathe PBE just writes images#asahi-gpu · 2022-10-27 01:22
alyssabut the ZLS knows what depth buffers and stencil buffers are,#asahi-gpu · 2022-10-27 01:22
alyssathe closest equivalent is the PBE which handles image writes in general#asahi-gpu · 2022-10-27 01:22
alyssathere is not dedicated colour buffer hardware