#
✕ nick:lina
#asahi-gpu · 2023-03-03 18:00
linaalyssa: Also I had to add an argument to 1228f92097d due to a mesa:main change, but it's just copypasta, please check that it's correct ^^;;
#asahi-gpu · 2023-03-03 17:57
linaAlso I just force pushed
#asahi-gpu · 2023-03-03 17:57
linaIf you think it's correct, sure ^^
#asahi-gpu · 2023-03-03 17:55
lina(Or whether it does anything()
#asahi-gpu · 2023-03-03 17:55
linaTop commit on that is some guesswork for the things we were still not setting properly in the cmdbuf, no idea how it interacts with multisampling.
#asahi-gpu · 2023-03-03 17:55
linaalyssa: Pushed to my agx/next, I think that should be clean. Needs a kernel uprev due to a minor UAPI change.
#asahi-gpu · 2023-03-03 15:43
linaMaybe we should have a notes doc on what's broken/why to avoid duplicate work ^^;;
#asahi-gpu · 2023-03-03 15:43
linaYeah... I saw only the last one was wrong, but it took me a while to even notice the 64 offset...
#asahi-gpu · 2023-03-03 15:41
linaI'm not sure how long it's been but it's been a while of digging through render target code to get to offsets > 64 (which I got to just now) ^^;;
#asahi-gpu · 2023-03-03 15:40
linaI mean I spent that long getting to where you were ;;
#asahi-gpu · 2023-03-03 15:38
linaI do feel like sometimes I spend hours figuring out stuff you've already figured out ;;
#asahi-gpu · 2023-03-03 15:37
linaI think I spent the past 2-3 hours getting there...
#asahi-gpu · 2023-03-03 15:37
linaWell either way at least for GLES3 I'm pretty sure I don't have any sync-related regressions... it's that, some depth/stencil stuff, and some pack/unpack stuff. All of which sound completely unrelated to sync.
#asahi-gpu · 2023-03-03 15:36
linaOh...........
#asahi-gpu · 2023-03-03 15:36
linaIt wasn't on your existing GLES3 fail list... but I see it is in the GLES31 one...
#asahi-gpu · 2023-03-03 15:34
linaalyssa: I'm stuck on max draw buffers right now, TIB offsets >= 64 do not work. I'm going to macOS to see if I'm missing something here, even kernel side...
#asahi-gpu · 2023-03-03 12:53
linaSooo --deqp-surface-type=fbo is very, very broken... ;;
#asahi-gpu · 2023-03-03 12:30
linaAnd now I'm running into others... and I'm getting the feeling none of this has anything to do with explicit sync and it's just all very broken and I don't get it...
#asahi-gpu · 2023-03-03 12:30
linaOK so I fixed that one with a state tracker patch... but I still don't know why this isn't breaking other drivers...
#asahi-gpu · 2023-03-03 12:15
linaalyssa: Ummm so I'm running into ASAN issues with constant buffers and blitting and I can't figure out why this isn't broken for everyone...
#asahi-gpu · 2023-03-03 10:00
linaIt turns out you can render to a BO and *then* export it and so we need to post-facto insert a DMA-BUF fence into it at export time...
#asahi-gpu · 2023-03-03 09:59
linaalyssa: I can't repro the pink square thing with stk but I can with nautilus. Fixed ^^
#asahi-gpu · 2023-03-03 09:08
linaI don't recall ever seeing this back when I tested dEQP-GLES2 with the explicit sync stuff... could it be an upstream mesa regression recently? I tried just UAPI on top of mesa/mesa:main and it still happens...
#asahi-gpu · 2023-03-03 09:07
linaalyssa: I have a flake regression in dEQP-GLES2 and I don't know where it comes from... it's easy to reproduce running dEQP-GLES2.functional.fragment_ops.interaction.basic_shader.77 in a loop. The images have random bad pixels... any ideas? It still happens in sync mode, and also with the flush_resource stuff disabled...
#asahi-gpu · 2023-03-03 08:05
linaOkay, the flush_resource thing was completely broken... Maybe that's what was breaking Sway... ^^;;
#asahi-gpu · 2023-03-03 07:14
linaAnd at least some are due to the flush_resource stuff
#asahi-gpu · 2023-03-03 07:14
linadEQP-EGL was all kinds of broken now...
#asahi-gpu · 2023-03-03 07:14
linaalyssa: So I think a lot of the regressions are actually from the git work/rebase for upstreaming the device stuff ^^;; (fd leaks...)
#asahi-gpu · 2023-03-03 05:58
lina^^
#asahi-gpu · 2023-03-03 05:57
linaI don't think we want to do anything fancy with IRQs delivered to userspace... the equivalent of that with the existing UAPI is to just have a thread poll on syncobjs and do the cleanup there, but that sounds like a "might be a good idea some day, probably not now" thing...
#asahi-gpu · 2023-03-03 05:56
linaAnd I'll do something to make batches not roll around all the time. I think I can just do a poll on all submitted syncobjs twice after each submission (you can do several in one syscall, doing it twice means we potentially clean up 2 batches for each new batch, which should keep memory usage under control)
#asahi-gpu · 2023-03-03 05:55
linathe flush_resource thing
#asahi-gpu · 2023-03-03 05:55
linaSo I'm going to move the SHAREABLE fix thing to before the batch tracking because that was actually regressed (well, it was always technically wrong, it just started mattering) by the UAPI change, not the actual explicit sync
#asahi-gpu · 2023-03-03 05:51
linaIt's not a hard leak but I don't know how much memory it's *supposed* to use...
#asahi-gpu · 2023-03-03 05:51
linaOh yeah, deqp-EGL hits the OOM killer on 8GB with >1 thread (or maybe 2 fit, barely), I don't know why...
#asahi-gpu · 2023-03-03 05:48
linaOof... gles2 was fine last I tried it, but I didn't try gles3... ^^;;
#asahi-gpu · 2023-03-02 15:09
linaGot it! ^^
#asahi-gpu · 2023-03-02 03:20
linaDoes it go away with ASAHI_MESA_DEBUG=sync only for stk, or for all of sway?
#asahi-gpu · 2023-03-02 03:20
linaalyssa: Only on startup and only on sway? Hmm... that's starting to sound like something that shouldn't block release at this point ^^;;
#asahi-gpu · 2023-03-01 17:35
linaAnyway, I should sleep ^^
#asahi-gpu · 2023-03-01 17:35
linaI can't reproduce it on my phone at least (Firefox on Android, Pixel 4a 5G)
#asahi-gpu · 2023-03-01 17:33
linaI can't test that easily but I think you can ^^
#asahi-gpu · 2023-03-01 17:33
linaWould it happen on panfrost too?
#asahi-gpu · 2023-03-01 17:32
linaIs there a good way to prove it's an app bug so we can confidently say we don't care? ^^
#asahi-gpu · 2023-03-01 17:32
linaSo I guess this is going to have to be a quirks thing? And probably enable it for all browsers because WebGL...
#asahi-gpu · 2023-03-01 17:31
linaOh, it didn't break here...
#asahi-gpu · 2023-03-01 17:30
linaThis is <(modern) phone res and it's pretty bad, like decals sliding into walls bad and vertices jumping multiple pixels...
#asahi-gpu · 2023-03-01 17:29
linaYeah, one of those "all apps get this wrong" things I bet...
#asahi-gpu · 2023-03-01 17:28
linaThat does ^^
#asahi-gpu · 2023-03-01 17:27
linaalyssa: Huh, that does not fix it...

plus ›