#
✕ nick:lina
#asahi-gpu · 2023-07-30 03:51
linaLooks like you found a better solution ^^
#asahi-gpu · 2023-07-30 03:51
linajannau: I found that UAF a long time ago, tried to fix it in core mesa code, and it broke a piglit, and I back burnered it because it wasn't breaking anything IRL...
#asahi-gpu · 2023-07-29 10:16
linaAlso kernel changes cannot cause that kind of userspace issue
#asahi-gpu · 2023-07-29 10:16
linaYeah that makes no sense
#asahi-gpu · 2023-07-29 07:36
lina(Still feeling a bit sick so I'm going to lie down for a bit)
#asahi-gpu · 2023-07-29 07:30
linaThat looks like a UAF...
#asahi-gpu · 2023-07-29 07:30
linaDo you have a way to reproduce it?
#asahi-gpu · 2023-07-29 07:12
linaI'm going to get lunch, but this is weird...
#asahi-gpu · 2023-07-29 07:12
linaBut yes, reverting it fixes xwayland on mutter
#asahi-gpu · 2023-07-29 07:11
linaNow I'm really confused...
#asahi-gpu · 2023-07-29 07:11
linaWhich both has nothing to do with its own commit description (!?) and doesn't have anything to do with modifiers
#asahi-gpu · 2023-07-29 07:11
linaI bisected the xwayland thing to 1d9d72b3fb905e
#asahi-gpu · 2023-07-29 07:11
linaUmmmmmmmmmm
#asahi-gpu · 2023-07-29 07:00
linaYeah, it's a core Mesa regression. I have a bad and good commit now (with trivial Asahi changes on top), going to bisect
#asahi-gpu · 2023-07-29 06:25
linaI think it might be a Mesa regression somewhere, it worked with some random older branch
#asahi-gpu · 2023-07-29 05:17
linaIt means somewhere along the line the modifier gets lost or set to zero
#asahi-gpu · 2023-07-29 05:17
linaApps are rendering compressed and mutter is compositing them as linear
#asahi-gpu · 2023-07-29 05:16
linaThat's the modifiers issue
#asahi-gpu · 2023-07-29 02:32
linaLooks like GNOME 44 / XWayland broke window modifiers or something like that...
#asahi-gpu · 2023-07-26 13:21
linaIt's probably a kernel snafu...
#asahi-gpu · 2023-07-26 13:18
linaYeah, that was my guess too ^^
#asahi-gpu · 2023-07-26 07:51
linaalyssa: Got you some YUV texture examples ^^ https://gist.github.com/asahilina/b3864932fd1881325b7c1719fe912bb6
#asahi-gpu · 2023-07-26 03:21
linaJust going to look at the descriptors
#asahi-gpu · 2023-07-26 03:21
linaI figured it's not too complicated to explain ^^
#asahi-gpu · 2023-07-26 03:21
linaBTW today I wanted to look at something simple as a bit of a walkthrough some reversing stuff, think YUV textures are okay?
#asahi-gpu · 2023-07-26 03:20
linaThat was implemented blind and I wouldn't be surprised if I missed some *layers somewhere...
#asahi-gpu · 2023-07-26 03:20
linaCould easily be mine
#asahi-gpu · 2023-07-26 03:20
lina^^;;
#asahi-gpu · 2023-07-26 03:20
linaDoes layered rendering work on the Linux driver? I think that was never really tested
#asahi-gpu · 2023-07-26 03:19
linaalyssa: I'll review your MR later (sorry, got caught up in apartment/move stuff last night... still setting up wiring and stuff ^^;;)
#asahi-gpu · 2023-07-26 03:01
linaIf you get "Job timed out on the DRM scheduler" then things are going to break
#asahi-gpu · 2023-07-26 03:01
linaRunning out of slots is normal then because all GPU jobs gets stuck...
#asahi-gpu · 2023-07-26 03:00
linaThis is a known issue when you get faults, there's a chance it might happen and I don't know why yet
#asahi-gpu · 2023-07-26 03:00
linaActually no, I think what happened there is the GPU firmware crashed/froze
#asahi-gpu · 2023-07-26 03:00
lina(This whole thing is going to be redesigned in the driver so I don't really want to try to fix it if it's broken right now ^^;;)
#asahi-gpu · 2023-07-26 02:59
linaMaybe reduce the parallelism?
#asahi-gpu · 2023-07-26 02:59
linaMary: Those "out of slots" messages mean you're out of global GPU resources... it's supposed to just block until they free up then, but those codepaths haven't been tested much so I wouldn't be surprised if things go wrong...
#asahi-gpu · 2023-07-25 14:02
lina;;
#asahi-gpu · 2023-07-25 14:01
linaBut it's the second shader with the clamp() that breaks that
#asahi-gpu · 2023-07-25 14:01
linaWe have a hack in the driver that detects the easy case with no ALU and does exactly that, upgrades to fp32, because this is a common issue
#asahi-gpu · 2023-07-25 14:00
linaIf so this should be broken there too...
#asahi-gpu · 2023-07-25 14:00
linaBut I'm guessing that doesn't work when there's ALU in between exactly like this case?
#asahi-gpu · 2023-07-25 13:57
linahttps://bugzilla.mozilla.org/show_bug.cgi?id=1845309
#asahi-gpu · 2023-07-25 13:45
linano16 not working
#asahi-gpu · 2023-07-25 13:44
linaAs long as we fix it to actually work ^^
#asahi-gpu · 2023-07-25 13:44
linaYeah...
#asahi-gpu · 2023-07-25 13:41
lina*that* one
#asahi-gpu · 2023-07-25 13:41
linahttps://searchfox.org/mozilla-central/source/dom/canvas/DrawTargetWebgl.cpp#1319
#asahi-gpu · 2023-07-25 13:41
linaLet me see where the clamp comes from
#asahi-gpu · 2023-07-25 13:41
linaYeah

plus ›