#
✕ nick:knedlik
#asahi-gpu · 2024-01-08 17:50
knedlikI'll take a look, thanks
#asahi-gpu · 2024-01-08 17:48
knedlikWould the zero properties be just 0 in memory, or some different default value?
#asahi-gpu · 2024-01-08 17:47
knedlikOh right
#asahi-gpu · 2024-01-08 16:58
knedlikSo I added a guard clause that checks if the format is equal to the undefined value (I believe it is 0, not sure though), and if it is, set the pointer to a nullptr and return. Unfortunately, that does not solve the error of returning non-zero properties. Any ideas? I'm really learning a lot about mesa as I go, so please excuse me if this is something obvious.
#asahi-gpu · 2024-01-06 20:55
knedlikShould I make a pull request with the change to agxv/main once finished?
#asahi-gpu · 2024-01-06 20:54
knedlikI'm starting to get tired, but tommorow I'll do a quick test if the guard clause clears the test
#asahi-gpu · 2024-01-06 19:49
knedlikNevermind, it's a pointer... :facepalm:
#asahi-gpu · 2024-01-06 19:49
knedlikI need clarification here - the error is about returning non-zero properties, but the function is declared as void, where exactly is it returning the properties?
#asahi-gpu · 2024-01-06 19:42
knedlikI have a suspicion NVK does it in the image functions, which means we could just do a guard clause assuming it won't be needed elsewhere
#asahi-gpu · 2024-01-06 19:08
knedlikAlright
#asahi-gpu · 2024-01-06 19:05
knedlikI'd assume it should be as easy as adding a guard clause to check for the undefined format?
#asahi-gpu · 2024-01-06 19:03
knedlikIt makes sense for a project like this to be honest
#asahi-gpu · 2024-01-06 19:03
knedlikThere it is, I found it, thanks for the help
#asahi-gpu · 2024-01-06 19:02
knedlikThat makes sense now
#asahi-gpu · 2024-01-06 19:00
knedlikSo I'm supposed to patch some function outside the asahi-specific tree and point it to some file in the asahi tree?
#asahi-gpu · 2024-01-06 18:54
knedlikHmm, I may be blind, but is the function not implemented yet at all? I'd assume "returning non-zero properties" doesn't happen in an unimplemented function
#asahi-gpu · 2024-01-06 18:47
knedlikI'll try taking a look at the 'vkGetPhysicalDeviceFormatProperties' from line 49 as you said
#asahi-gpu · 2024-01-06 18:46
knedlikAlright, I was using the binary directly without deqp-runner, so I guess that was my issue
#asahi-gpu · 2024-01-06 10:56
knedlikOkay, now it should be complete
#asahi-gpu · 2024-01-06 10:52
knedlikOh wait... forgot to include failed tests, one sec
#asahi-gpu · 2024-01-06 10:50
knedlikWhich of these would be a good thing to get started with?
#asahi-gpu · 2024-01-06 10:50
knedlikSo I have successfully run the tests, and made a deduped text file of the non-passing ones: https://gist.github.com/KnedlikMCPE/4c4fffa220a668d0bb48851c77bb2062
#asahi-gpu · 2024-01-05 19:19
knedlikthere I have cloned the mesa and CTS repos
#asahi-gpu · 2024-01-05 19:19
knedlikI already closed the terminal, but it was in the root dir of my external SSD, so /run/media/knedlik/LinuxEXT/
#asahi-gpu · 2024-01-05 19:14
knedlikI specified the absolute path
#asahi-gpu · 2024-01-05 19:13
knedlikIt isn't, should it be?
#asahi-gpu · 2024-01-05 18:46
knedlikSo considering this is pretty new territory to me, I'm gonna need some help - when I try to run deqp-vk with the params listed in the README, I get 'FATAL ERROR: Failed to initialize dEQP: Failed to open file: './vk-default/api.txt' at tcuResource.cpp:53'...
#asahi-gpu · 2024-01-05 18:38
knedlikAlright, thanks
#asahi-gpu · 2024-01-05 18:36
knedlikSo I have successfully compiled the VK Mesa and the test suite... now, could someone help me with which binary I should run for the CTS?
#asahi-gpu · 2024-01-05 17:32
knedlikWill try to compile it now, I'll get back if I need any help
#asahi-gpu · 2024-01-05 17:20
knedlikIs it the asahi/mesa repo under freedesktop?
#asahi-gpu · 2024-01-05 17:14
knedlikAlright, just to make sure, where can I find the current Vulkan implementation? Last time I looked in the upstream Mesa repo, the Asahi dir didn't contain a Vulkan dir
#asahi-gpu · 2024-01-05 13:56
knedlikHey there! Is there any way I could contribute to the Vulkan drivers becoming a thing? I'd say I'm a pretty good programmer, although I don't have much knowledge in low-level stuff...