#
✕ nick:karolherbst
#asahi-gpu · 2024-08-08 15:01
karolherbstthat one
#asahi-gpu · 2024-08-08 15:01
karolherbstyep
#asahi-gpu · 2024-08-08 15:01
karolherbsthow is that called
#asahi-gpu · 2024-08-08 15:01
karolherbstthat's uhhh
#asahi-gpu · 2024-08-08 15:01
karolherbstI've seen that one
#asahi-gpu · 2024-08-08 15:01
karolherbstohh wait
#asahi-gpu · 2024-08-08 14:49
karolherbstjust some scaling like nir_scale_fdiv or something more complex?
#asahi-gpu · 2024-08-08 14:48
karolherbst:3
#asahi-gpu · 2024-08-08 14:40
karolherbstand we can safely assume they emit it directly without any funky lowering?
#asahi-gpu · 2024-08-08 14:40
karolherbstor just the hw not being precise enough
#asahi-gpu · 2024-08-08 14:37
karolherbstmaybe something with rounding?
#asahi-gpu · 2024-08-08 14:37
karolherbstfunky
#asahi-gpu · 2024-08-08 14:26
karolherbsthuh.. this blit bug is weird...
#asahi-gpu · 2024-08-08 13:30
karolherbsthow rude
#asahi-gpu · 2024-08-08 13:27
karolherbstand then just bin/cl-program-tester
#asahi-gpu · 2024-08-08 13:26
karolherbstneeds -DPIGLIT_BUILD_CL_TESTS=ON
#asahi-gpu · 2024-08-08 13:25
karolherbstthe piglit one helps, because you won't have to run it for a minute until hitting it :D
#asahi-gpu · 2024-08-08 13:24
karolherbstin the CL CTS it's integer_ops/test_integer_ops uint_math int_math
#asahi-gpu · 2024-08-08 13:24
karolherbstwith piglits cl-program-tester: https://gist.githubusercontent.com/karolherbst/f49e8f5091887d60bd88da58f54d5b7e/raw/c55ef2d681c3eb6481a0645cf7beb71556181157/test.cl
#asahi-gpu · 2024-08-08 13:17
karolherbstat least reverting 65e431e61a3bace7e50c11d699880ae860f76133 doesn't help.. but maybe the other changes might? But I'm not in the mood of doing reverts across the big nir rename...
#asahi-gpu · 2024-08-08 13:13
karolherbstthat's gonna be pain to debug
#asahi-gpu · 2024-08-08 13:12
karolherbstI've asked austriancoder if it also happens on etnaviv...
#asahi-gpu · 2024-08-08 13:09
karolherbstprobably something wrong in nir_lower_idiv
#asahi-gpu · 2024-08-08 13:07
karolherbstoh no.. it's a real bug..
#asahi-gpu · 2024-08-08 11:57
karolherbstsomething with block/grid sizes
#asahi-gpu · 2024-08-08 11:57
karolherbstokay.. I think the int bug above is a rusticl one
#asahi-gpu · 2024-08-08 10:15
karolherbstahh.. and 1Darray
#asahi-gpu · 2024-08-08 10:15
karolherbstbut mhh.. only fails for 1D and 2D
#asahi-gpu · 2024-08-08 10:15
karolherbstimage format that means
#asahi-gpu · 2024-08-08 10:14
karolherbstalyssa: okay, your block/blit stuff works for fp32, but not for fp16
#asahi-gpu · 2024-08-08 09:24
karolherbst"Testing "/" cl_int Verification failed at element 1749980: 0x2ba97a73 / 0xfa8d9df5 = 0xfffffff8, got 0xffffffef" noooo
#asahi-gpu · 2024-08-07 22:41
karolherbstnot sure if he is open for backporting, because uhh.. ABI breakage or something.. but we'll see
#asahi-gpu · 2024-08-07 22:40
karolherbstlol
#asahi-gpu · 2024-08-07 22:40
karolherbstI think I can make it work :D
#asahi-gpu · 2024-08-07 22:40
karolherbstairlied is the maintainer 🙃
#asahi-gpu · 2024-08-07 22:39
karolherbstlet's see...
#asahi-gpu · 2024-08-07 22:39
karolherbstmhh maybe?
#asahi-gpu · 2024-08-07 22:38
karolherbstahh and the spirv-link stuff
#asahi-gpu · 2024-08-07 22:38
karolherbsta lot of upstream rusticl cherry-picks
#asahi-gpu · 2024-08-07 22:38
karolherbstbut I have like 25 patches on top of asahi/main atm or so :D
#asahi-gpu · 2024-08-07 22:37
karolherbstI only care about the test printing PASSED
#asahi-gpu · 2024-08-07 22:37
karolherbstdon't care
#asahi-gpu · 2024-08-07 22:37
karolherbstor maybe something with nir changed dunno
#asahi-gpu · 2024-08-07 22:36
karolherbstI did update the CTS in the meantime though
#asahi-gpu · 2024-08-07 22:36
karolherbstdoesn't seem to be broken anymore? lol
#asahi-gpu · 2024-08-07 22:36
karolherbstno idea?
#asahi-gpu · 2024-08-07 22:36
karolherbstuhhh
#asahi-gpu · 2024-08-07 22:36
karolherbst(which I can fix by just exposing less memory I guess)
#asahi-gpu · 2024-08-07 22:36
karolherbstthough mhh.. I have test_allocations failing after it tried to allocate 12GiB of GPU memory or something 🙃
#asahi-gpu · 2024-08-07 22:34
karolherbstnice, will check it out tomorrow after the CTS run completes in like 15 hours or so

plus ›