#
✕ nick:i509VCB
#asahi-gpu · 2024-01-08 23:43
i509vcbOnly the first layer is correct
#asahi-gpu · 2024-01-08 23:21
i509vcbtime to open up gdb again to compare the memory
#asahi-gpu · 2024-01-08 23:17
i509vcbhttps://usercontent.irccloud-cdn.com/file/1xlF2ywk/image.png
#asahi-gpu · 2024-01-08 23:17
i509vcbsome more basic 3d related copy tests are giving me the funny results again
#asahi-gpu · 2024-01-08 22:30
i509vcbhnm no different qpa output
#asahi-gpu · 2024-01-08 22:24
i509vcbI guess the bug for layered rendering is elsewhere, setting viewport_target and render_target based on the vs changes nothing
#asahi-gpu · 2024-01-08 17:51
i509vcbYou might be able to get away with initializing a zeroed struct of that type on the stack and then doing a memcpy
#asahi-gpu · 2024-01-08 17:49
i509vcbYou probably want to zero the formatProperties field
#asahi-gpu · 2024-01-08 17:47
i509vcbI think you'll want memset? Or was it called something else in C?
#asahi-gpu · 2024-01-08 17:47
i509vcbknedlik: setting the pointer to zero does not change the data referenced by the pointer
#asahi-gpu · 2024-01-06 20:42
i509vcbThe properties are returned via one of the pointers
#asahi-gpu · 2024-01-06 20:42
i509vcbI guess we could just do the quick guard clause
#asahi-gpu · 2024-01-06 19:08
i509vcbI guess take a peek at nvk
#asahi-gpu · 2024-01-06 19:08
i509vcbUhh I'd wonder what other drivers do here actually
#asahi-gpu · 2024-01-06 19:04
i509vcbMesa is also used for several other vulkan implementations so people do want to yeet some boilerplate
#asahi-gpu · 2024-01-06 19:03
i509vcbTLDR: Mesa makes a big function pointer lookup table for us
#asahi-gpu · 2024-01-06 19:02
i509vcbPretty much look at agxv_GetPhysicalDeviceFormatProperties2
#asahi-gpu · 2024-01-06 19:01
i509vcbYou just need to do stuff inside the agxv_ prefixed functions
#asahi-gpu · 2024-01-06 19:01
i509vcbIt's all linked for you
#asahi-gpu · 2024-01-06 18:58
i509vcbSearch for vk_common_GetPhysicalDeviceFormatProperties to see where that forwarding is done
#asahi-gpu · 2024-01-06 18:56
i509vcbVulkan has a few of these vkWhatever2 functions since 1.0 didn't consider adding pointer chains to some types or expected all data to be specified via a single fixed signature
#asahi-gpu · 2024-01-06 18:55
i509vcbThat function is delegated to the FormatProperties2 function by mesa for us
#asahi-gpu · 2024-01-06 18:38
i509vcb(That "Fail (Fail)" dedup is doing some heavy lifting)
#asahi-gpu · 2024-01-06 18:33
i509vcbdeqp-runner gives you a results and failures.csv with every test name and whether it failed, crashed, flakes or passed
#asahi-gpu · 2024-01-06 18:33
i509vcbI guess the problem you have there is that you know how many failed but not what specific test did
#asahi-gpu · 2024-01-06 18:32
i509vcbAnd the tests below testing for required format feature bits
#asahi-gpu · 2024-01-06 18:32
i509vcbhttps://gist.github.com/KnedlikMCPE/4c4fffa220a668d0bb48851c77bb2062#file-deduped-txt-L49 seems like something you could do
#asahi-gpu · 2024-01-06 18:31
i509vcbhttps://gist.github.com/KnedlikMCPE/4c4fffa220a668d0bb48851c77bb2062#file-deduped-txt-L48 ignore this, that's something to fix when we are 90% done
#asahi-gpu · 2024-01-06 18:30
i509vcbYou can run individual tests with the -n argument on dEQP-vk to avoid running the entire suite every time
#asahi-gpu · 2024-01-06 18:29
i509vcbknedlik: VK_EXT_global_priority(_query) the promoted KHR extension for that is implemented. If you did want to implement the older EXT extension I think you just need to enable those two extensions and test if anything changed during promotion?
#asahi-gpu · 2024-01-05 19:55
i509vcbOk
#asahi-gpu · 2024-01-05 19:17
i509vcbwhat does pwd say?
#asahi-gpu · 2024-01-05 19:17
i509vcbAnd you did ./path/to/caselist
#asahi-gpu · 2024-01-05 19:13
i509vcbCheck --help
#asahi-gpu · 2024-01-05 19:13
i509vcbAlthough last I recall caselist files aren't just specified that way?
#asahi-gpu · 2024-01-05 19:13
i509vcbknedlik: your current directory is the same location as dEQP-vk?
#asahi-gpu · 2024-01-05 18:39
i509vcbAlthough I've found if you start too many jobs with deqp-runner your gpu hangs and the kernel can't recover it without a hard reboot
#asahi-gpu · 2024-01-05 18:38
i509vcbIt could also be useful to grab deqp-runner
#asahi-gpu · 2024-01-05 18:38
i509vcbit should be under external/vulkancts/modules/vulkan
#asahi-gpu · 2024-01-05 18:38
i509vcbdEQP-VK
#asahi-gpu · 2024-01-05 18:18
i509vcbI think .64 is the one where we start seeing uses of layer reads: https://usercontent.irccloud-cdn.com/file/EgxJlqzk/3d_to_3d.a2r10g10b10_sint_pack32.a2r10g10b10_sint_pack32.zip
#asahi-gpu · 2024-01-05 18:16
i509vcbhttps://usercontent.irccloud-cdn.com/file/knju3cGX/image.png
#asahi-gpu · 2024-01-05 18:16
i509vcbalthough the output in the viewer shows something odd
#asahi-gpu · 2024-01-05 18:16
i509vcbalyssa: yes, it is an int, did the change and still no dice
#asahi-gpu · 2024-01-05 17:12
i509vcbAreas to avoid: the entire vkCmdCopy family of commands, I am currently working on those
#asahi-gpu · 2024-01-05 17:11
i509vcbOr you could try to implement extensions, although there is a lot of core API that these need to make that truly work
#asahi-gpu · 2024-01-05 17:11
i509vcbknedlik: build the vulkan cts, find a group of failing tests and try to fix those
#asahi-gpu · 2024-01-05 04:05
i509vcbI think I might have forgotten something, but I think this is all the compiler related stuff for layers: https://gitlab.freedesktop.org/i509VCB/mesa/-/commit/02528b81be23d2b71ad8542f1e66c286e13df83d
#asahi-gpu · 2024-01-04 22:46
i509vcbcan't get the instance id in a fragment shader...
#asahi-gpu · 2024-01-04 22:26
i509vcbvk_meta_draw_volume seems to do an instance per layer, I guess that's whats stopping 3D from working since I see nothing related to getting the instance number in the shader so far

plus ›