#
✕ nick:alyssa
#asahi-gpu · 2022-10-12 19:07
alyssa WARN(!dcp->connector->connected, "can't flush if disconnected")) {
#asahi-gpu · 2022-10-12 19:07
alyssa if (WARN(dcp_channel_busy(&dcp->ch_cmd), "unexpected busy channel") ||
#asahi-gpu · 2022-10-12 19:07
alyssathat is a legitimate assertion, it can only ever fail due to a bug in the dcp kernel driver
#asahi-gpu · 2022-10-12 19:06
alyssa{ WARN_ON((*depth) == 0);
#asahi-gpu · 2022-10-12 19:06
alyssastatic u8 dcp_pop_depth(u8 *depth)
#asahi-gpu · 2022-10-12 19:06
alyssaI see a bunch of legitimate asserions and a bunch of bogus ones that should indeed be dev_err, bah
#asahi-gpu · 2022-10-12 19:06
alyssano i'm looking now
#asahi-gpu · 2022-10-12 19:06
alyssaOkay, well, that's wrong, complain to Alyssa about that.
#asahi-gpu · 2022-10-12 19:05
alyssaThose should all be errors that become dev_err and should never be asserted it
#asahi-gpu · 2022-10-12 19:05
alyssaNOT a bug in the firmware or the device or the userspace
#asahi-gpu · 2022-10-12 19:05
alyssaAn assertion failure means a bug in my code.
#asahi-gpu · 2022-10-12 19:05
alyssaThat is the right behaviour yes
#asahi-gpu · 2022-10-12 19:04
alyssaI thought kernel C assert() is just WARN_ON(!)
#asahi-gpu · 2022-10-12 19:04
alyssaasserts are the best tool we have to write correct code
#asahi-gpu · 2022-10-12 19:04
alyssasven: what is the right way to do asserts then
#asahi-gpu · 2022-10-12 19:02
alyssathis thing really wants to be rust doesn't it.
#asahi-gpu · 2022-10-12 19:02
alyssareads the code
#asahi-gpu · 2022-10-12 19:00
alyssa(I don't remember how the parser worked ..)
#asahi-gpu · 2022-10-12 18:59
alyssaor more precisely WARN_ON(IS_ERR(mode))
#asahi-gpu · 2022-10-12 18:59
alyssamaybe we need a WARN_ON(mode < 0) in there
#asahi-gpu · 2022-10-12 18:59
alyssajannau: ...no, that does not indeed.
#asahi-gpu · 2022-10-12 17:03
alyssawhat a delight
#asahi-gpu · 2022-10-12 16:54
alyssadelightful
#asahi-gpu · 2022-10-12 16:54
alyssa(but of course cursors are differently broken in DCP hence the copy?)
#asahi-gpu · 2022-10-12 16:53
alyssaor is there a bug drawing the cursor in GL and using a plane offloads from AGX to DCP to workaround?
#asahi-gpu · 2022-10-12 16:53
alyssaWhat do cursor planes have to do with it?
#asahi-gpu · 2022-10-12 16:53
alyssaI assumed glamor was blocked on mesa bugs
#asahi-gpu · 2022-10-12 16:53
alyssaI am missing a lot of context I think
#asahi-gpu · 2022-10-12 16:50
alyssai've got macOS side work to do, not actually looking forward to fixing glamor anyway :p
#asahi-gpu · 2022-10-12 16:49
alyssasure
#asahi-gpu · 2022-10-12 16:45
alyssahmm, ok
#asahi-gpu · 2022-10-12 16:44
alyssai haven't uprevved in a while, will need to for agx though ;)
#asahi-gpu · 2022-10-12 16:44
alyssaOK
#asahi-gpu · 2022-10-12 16:43
alyssamight that be the same bug as glmark2 is hitting?
#asahi-gpu · 2022-10-12 16:43
alyssajannau: even without agx in the loop, closing compositors (eg quitting sway to return to the tty) crashes dcp... I don't think that happened on my original prototype but IDK what would've changed. I think you mentioned you know about this issue?
#asahi-gpu · 2022-10-12 16:42
alyssaoh, yeah, ok
#asahi-gpu · 2022-10-12 16:39
alyssawhat's the issue?
#asahi-gpu · 2022-10-07 15:36
alyssaI think I know but jekstrand is the expert here
#asahi-gpu · 2022-10-07 15:36
alyssanod
#asahi-gpu · 2022-10-07 15:11
alyssa[If I were writing the VK driver myself, I'd figure this out over a 1-on-1 call with jekstrand :-p]
#asahi-gpu · 2022-10-07 15:11
alyssabut neither is clear from the GL driver
#asahi-gpu · 2022-10-07 15:11
alyssaI know the hw and jekstrand knows the Vulkan so together we should figure out the right way to do it
#asahi-gpu · 2022-10-07 15:10
alyssaWe should get on a call with jekstrand about descriptor sets
#asahi-gpu · 2022-10-07 15:10
alyssaMmh, ok
#asahi-gpu · 2022-10-07 15:05
alyssa(and honestly I much prefer those two topics to either GL or VK driver dev so..)
#asahi-gpu · 2022-10-07 15:04
alyssa(There is a LOT of work to do for both compiler and r/e stuff and it's all needed regardless of API so I guess there's that..)
#asahi-gpu · 2022-10-07 15:03
alyssaor would it be more helpful for me to stay on compiler + r/e duty and continue with the GL driver as reference code for you?
#asahi-gpu · 2022-10-07 15:03
alyssalet me know how I can help
#asahi-gpu · 2022-10-07 15:03
alyssaassuming you've gotten enough done that helping you is less work than starting from scratch myself
#asahi-gpu · 2022-10-07 15:03
alyssaElla[m]: Also, the good folk at XDC convinced me that I should write a Vulkan driver actually

plus ›