#asahi-gpu · 2023-01-15 17:08
alyssageneric on the fragment pipe.#asahi-gpu · 2023-01-15 17:08
alyssa2. hw that can't. obviously this class of hw can still do uncompressed -- at worst, linear -- texture views. so the sane option here is to eat the bandwidth hit -- allocate an uncompressed staging resource and lower compressed->compressed copies to a pair of copies compressed->uncompressed + uncompressed->compressed because you can do views for each of those. and those simpler copies are easy and #asahi-gpu · 2023-01-15 17:06
alyssa1. hw that can do compressed texture views. in this case, img2img copies are just blits! you might need to munge the dest format into something renderable with the same size, maybe munge the dimensions in some evil cases, but by and large this is generic blitting on the fragment pipe, where a texture view (with view format != original format) on the sampling image for casting#asahi-gpu · 2023-01-15 17:04
alyssaright, so, there are basically 2 classes of hardware#asahi-gpu · 2023-01-15 17:02
alyssaimplementing that efficiently requires being able to "cast" framebuffer compressed images to different formats#asahi-gpu · 2023-01-15 17:02
alyssathe only spicy thing is vkCmdCopyImageToImage#asahi-gpu · 2023-01-15 17:02
alyssavkCmdCopyBufferToBuffer is also a totally generic compute kernel#asahi-gpu · 2023-01-15 17:01
alyssaalso I would expect vk_meta can do those because they're pretty general#asahi-gpu · 2023-01-15 17:01
alyssaexcept maybe some little details about ASTC/BCn formats? but I think you can just munge the dimensions?#asahi-gpu · 2023-01-15 17:01
alyssaprobably#asahi-gpu · 2023-01-15 17:01
alyssavkCmdCopyBufferToImage should be a fragment shader#asahi-gpu · 2023-01-15 17:01
alyssavkCmdCopyImageToBuffer should probably be a compute kernel#asahi-gpu · 2023-01-15 17:00
alyssavkCmdCopy* sucks.#asahi-gpu · 2023-01-15 17:00
alyssaRight..#asahi-gpu · 2023-01-15 16:50
alyssao #asahi-gpu · 2023-01-15 16:33
alyssamake sure my baby can grow without me, yknow#asahi-gpu · 2023-01-15 16:30
alyssaI was hoping the combination of you, Lina, Karol, and Dougall would be able to finish off compute support without me ^.^#asahi-gpu · 2023-01-15 16:29
alyssamakes sense#asahi-gpu · 2023-01-15 16:28
alyssakie#asahi-gpu · 2023-01-15 16:22
alyssai.e. when should I pull your tree and start hacking on deqp-vk, versus continuing to support more and better gl in the interest of agxv#asahi-gpu · 2023-01-15 16:22
alyssaby the way.. at what point will we be bottlenecked on agxv specific stuff#asahi-gpu · 2023-01-15 16:15
alyssaand obviously it solves a problem I had in GL lol#asahi-gpu · 2023-01-15 16:15
alyssabut if you say it's right and Jason says it's right that is good for me#asahi-gpu · 2023-01-15 16:15
alyssaI still don't really get how#asahi-gpu · 2023-01-15 16:15
alyssaHmmm ok#asahi-gpu · 2023-01-15 16:07
alyssaI've never written a VK driver lol#asahi-gpu · 2023-01-15 16:07
alyssaIs it, like... better than what we had before?#asahi-gpu · 2023-01-15 16:07
alyssaella-0: awesome!#asahi-gpu · 2023-01-15 15:54
alyssathis should be predicated on stage == COMPUTE, you're writing into a union#asahi-gpu · 2023-01-15 15:54
alyssahttps://gitlab.freedesktop.org/asahi/mesa/-/commit/e4a856e52ac8d88b3af6b5c4cad0534d01edac96#89b6e919adec3916dacf34377fe9e0036bd40140_89_89#asahi-gpu · 2023-01-15 15:52
alyssathis should be _writes, not _reads#asahi-gpu · 2023-01-15 15:52
alyssalina: https://gitlab.freedesktop.org/asahi/mesa/-/commit/fe3eed5f527cf51f8a45b2ad24ba5a79eb7e71c3#89b6e919adec3916dacf34377fe9e0036bd40140_42_47#asahi-gpu · 2023-01-13 16:30
alyssathough I suspect the extra abstraction layers would be worse than the copy/paste#asahi-gpu · 2023-01-13 16:30
alyssaand if it's worth sharing lay_out_uniforms let me know#asahi-gpu · 2023-01-13 16:29
alyssaella-0: especially you, AGXV is one of the motivations of that change so if it doesn't do what you want please let me know how to fix it :)#asahi-gpu · 2023-01-13 16:29
alyssalina: ella-0: ^^#asahi-gpu · 2023-01-13 16:28
alyssaplease review https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20562#asahi-gpu · 2023-01-09 19:15
alyssaeric_engestrom: oh uh oops#asahi-gpu · 2023-01-09 19:06
alyssahttps://i.imgur.com/FcHRnQE.png#asahi-gpu · 2023-01-09 19:05
alyssathe way communist software [1] is meant to be maintained#asahi-gpu · 2023-01-09 19:05
alyssalina: so. co-maintainers :-)#asahi-gpu · 2023-01-09 14:14
alyssalina: "compare mode" is a 1-bit enum in gallium but idk that seems a little silly so maybe compare enable is ok#asahi-gpu · 2023-01-08 15:26
alyssaif you're having troubles beyond that, lina can help ou#asahi-gpu · 2023-01-08 15:26
alyssa(if you do a full deqp-gles3 run, you'll see why ;) )#asahi-gpu · 2023-01-08 15:25
alyssahampus: oh, one more thing, to run the gles3 tests on asahi you'll want to set the `ASAHI_MESA_DEBUG=deqp MESA_GLES_VERSION_OVERRIDE=3.0` env vars, since asahi/mesa only advertises gles2 support#asahi-gpu · 2023-01-08 04:11
alyssagood luck!#asahi-gpu · 2023-01-08 04:11
alyssaand I think that's all I have to say :-)#asahi-gpu · 2023-01-08 04:11
alyssaAt this point, any other questions/review/etc should be directed at Lina#asahi-gpu · 2023-01-08 04:11
alyssait's a bit harder but now you're setup ;)