#
✕ nick:alyssa
#asahi-gpu · 2023-02-15 16:09
alyssaYeah, I see that
#asahi-gpu · 2023-02-15 16:01
alyssapossibly some of the agx_batch stuff could too? IDK
#asahi-gpu · 2023-02-15 16:00
alyssasince there's nothing downstream specific about drmSyncobjWait
#asahi-gpu · 2023-02-15 16:00
alyssaand agx_fence.h
#asahi-gpu · 2023-02-15 16:00
alyssaagx_fence.c can probably go upstream
#asahi-gpu · 2023-02-15 15:58
alyssathose 2/3 patches can probably go in now
#asahi-gpu · 2023-02-15 15:58
alyssaditto for shader key clone overread
#asahi-gpu · 2023-02-15 15:58
alyssaDefinitely the memctx bug fix is, and should be split off into its own MR (this can happen ahead of the macOS stuff)
#asahi-gpu · 2023-02-15 15:57
alyssaOnly question then is whether any of the code from agx/linux-explicit-sync is *not* specific to the UAPI (and should be upstreamed ahead of the new UAPI)
#asahi-gpu · 2023-02-15 15:57
alyssaOnly question then is whether any of the code from agx/linux-explicit-sync is *not* specific to the UAPI (and should be upstreamed ahead of the new UAPI)
#asahi-gpu · 2023-02-15 15:57
alyssa5. I use agx/linux-explicit-sync as the new base for my feature work and pick on top.
#asahi-gpu · 2023-02-15 15:56
alyssa4. You rebase explicit sync on top of agx/linux and squash everything down to a new agx/linux-explicit-sync branch, that is just the new UAPI and not the old.
#asahi-gpu · 2023-02-15 15:56
alyssa3. Rebase my agx/next upstream. It now consists of Linux UAPI patches + some feature work that's not yet ready. I drop the feature work and push an agx/linux branch.
#asahi-gpu · 2023-02-15 15:55
alyssa2. Land my outstanding asahi MRs upstream
#asahi-gpu · 2023-02-15 15:55
alyssa1. Remove macOS upstream
#asahi-gpu · 2023-02-15 15:55
alyssalina: As for how to land this... what's easiest for me is going to be
#asahi-gpu · 2023-02-15 15:54
alyssabuilds new kernel
#asahi-gpu · 2023-02-15 15:52
alyssasweats
#asahi-gpu · 2023-02-15 15:52
alyssayeah I get the warning too
#asahi-gpu · 2023-02-15 15:51
alyssaI'm regretting the unsafe union
#asahi-gpu · 2023-02-15 15:51
alyssalina: "asahi: Fix shader key cloning overreads"
#asahi-gpu · 2023-02-15 15:49
alyssaThanks
#asahi-gpu · 2023-02-15 15:48
alyssaand rebase your branch on top of that
#asahi-gpu · 2023-02-15 15:48
alyssalina: Please send the "drop macOS" MR, I'll review and merge
#asahi-gpu · 2023-02-15 15:48
alyssanice
#asahi-gpu · 2023-02-15 15:43
alyssaa few more fps is good ;0
#asahi-gpu · 2023-02-15 15:43
alyssayeah that's a nice bump
#asahi-gpu · 2023-02-15 15:42
alyssawill this make my supertuxkart go brr
#asahi-gpu · 2023-02-15 15:42
alyssasounds like I got a kernel upgrade to do
#asahi-gpu · 2023-02-15 15:42
alyssaahahahah got it nice
#asahi-gpu · 2023-02-15 15:40
alyssaheh
#asahi-gpu · 2023-02-15 15:39
alyssaas long as the fault handling is nice and robut that sounds fine :)
#asahi-gpu · 2023-02-15 15:39
alyssathanks for the heads up about exit faults
#asahi-gpu · 2023-02-15 15:38
alyssalina: niiiiice :)
#asahi-gpu · 2023-02-15 12:52
alyssa(unlikely to be today)
#asahi-gpu · 2023-02-15 12:52
alyssalina: K, will look when I get a chance
#asahi-gpu · 2023-02-15 03:26
alyssalina: Any chance I could get some pre-stream code review? *sweats*
#asahi-gpu · 2023-02-14 21:59
alyssasee https://developer.apple.com/documentation/metal/mtlrenderpipelinedescriptor?language=objc for the pseudo code, of course the actual expression is implementation-defined
#asahi-gpu · 2023-02-14 21:58
alyssahttps://backtick.town/~bloom/alpha-to-coverage.txt
#asahi-gpu · 2023-02-14 21:57
alyssaIt just doesn't make sense what's happening
#asahi-gpu · 2023-02-14 21:57
alyssadottedmag: No, I don't have any reason to think it's wrong
#asahi-gpu · 2023-02-14 21:47
alyssathis, this doesn't make sense to me why they would do that, which makes me think i'm missing something
#asahi-gpu · 2023-02-14 21:47
alyssaso end up with a float in the range [0, 1132462080.0) i guess
#asahi-gpu · 2023-02-14 21:46
alyssamantissa is free (save for denormals which have been flushed), so we end up encoding [0, 135 << 23)
#asahi-gpu · 2023-02-14 21:45
alyssaand then adding back 0 we get an exponent range of [0, 134]
#asahi-gpu · 2023-02-14 21:45
alyssasign bit is clear
#asahi-gpu · 2023-02-14 21:45
alyssaencoded as [1, 134]
#asahi-gpu · 2023-02-14 21:44
alyssaRange (0.0, 255.0] corresponds to an exponent of [-126, 7]
#asahi-gpu · 2023-02-14 21:42
alyssaThen they... reinterpret the float as a 32-bit integer and convert it to a float?
#asahi-gpu · 2023-02-14 21:41
alyssaSo now they have a 32-bit float in the range of [0.0, 255.0]

plus ›