#
✕ nick:alyssa
#asahi-gpu · 2023-02-26 01:41
alyssathis stuff is way too complicated
#asahi-gpu · 2023-02-26 01:39
alyssamaybe if I fix that, firefox will fix itself
#asahi-gpu · 2023-02-26 01:39
alyssaand all this ctx->syncobj stuff doesn't make much sense to me in an explicit sync world
#asahi-gpu · 2023-02-26 01:38
alyssaI'm especially suspicious of agx_fence_create
#asahi-gpu · 2023-02-26 01:36
alyssadoesn't trust any of the fencing code
#asahi-gpu · 2023-02-26 01:27
alyssaso what other fence is freedreno using that we're not
#asahi-gpu · 2023-02-26 01:26
alyssaoh but holy broken
#asahi-gpu · 2023-02-26 01:26
alyssai think
#asahi-gpu · 2023-02-26 01:26
alyssathis is worth another 6% on manhattan
#asahi-gpu · 2023-02-26 01:26
alyssafreedreno + explicit sync doesn't seem to do anything for flush resource
#asahi-gpu · 2023-02-26 01:26
alyssaAlso, I am not convinced that it's necessary to sync in flush_resource
#asahi-gpu · 2023-02-26 01:19
alyssaoh well
#asahi-gpu · 2023-02-26 01:19
alyssamaybe I screwed something up
#asahi-gpu · 2023-02-26 01:19
alyssacan't reproduce now
#asahi-gpu · 2023-02-26 00:59
alyssascratch #2
#asahi-gpu · 2023-02-26 00:59
alyssahm wait the apitrace might be from my sysval rewrite being broken
#asahi-gpu · 2023-02-26 00:49
alyssaOnce the Firefox regression is sorted, asusming no other regressions come up this week, I'll cut a new asahi/main release on top of the explicit sync UAPI and that should be good to go then
#asahi-gpu · 2023-02-26 00:47
alyssa2. For some reason one of the apitraces I have runs fine (and much faster I think!) in debugoptimized, but faults in release. I have not yet root caused this one. This is not blocking.
#asahi-gpu · 2023-02-26 00:46
alyssaI'm unsure if {Plasma, Firefox without WebRender} are affected but IMO this regression is blocking even if it's not ... and unless this is a Firefox bug it seems likely it can be hit with things other than Firefox, this is just what I noticed on day #1 of testing
#asahi-gpu · 2023-02-26 00:45
alyssa(and the glitching when typing is especially noticeable so probably easier to work with)
#asahi-gpu · 2023-02-26 00:44
alyssaThere are other visual artefacts with Firefox in GNOME, but I assume they have the same root cause
#asahi-gpu · 2023-02-26 00:44
alyssaThis is especially noticeable when typing into chat in discord.com
#asahi-gpu · 2023-02-26 00:43
alyssaThe most obvious symptom is typing into some input fields and not seeing the most recently typed character
#asahi-gpu · 2023-02-26 00:43
alyssaAt least with (explicit sync + Firefox + WebRender + GNOME), the rendered content is sometimes from a previous frame instead of a current frame, or at least partially so
#asahi-gpu · 2023-02-26 00:42
alyssa1. Even with ASAHI_MESA_DEBUG=sync, there are serious sync glitches with Firefox, at least when WebRender is used (as is the case on agx/next, didn't test without). This is a WSI issue: it happens in GNOME but not in Sway. It might also have to do with Xwayland vs native wayland.
#asahi-gpu · 2023-02-26 00:40
alyssaHowever, there are some regressions
#asahi-gpu · 2023-02-26 00:40
alyssaand agx/next has everything integratino
#asahi-gpu · 2023-02-26 00:39
alyssahttps://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21538 has the subset that I think can be upstreamed
#asahi-gpu · 2023-02-26 00:32
alyssa(the mesa ones, obviously didn't touch the kernel)
#asahi-gpu · 2023-02-26 00:32
alyssalina: I've squashed+rebased your explicit sync patches
#asahi-gpu · 2023-02-20 21:21
alyssaI'm suspicious I'm actually hitting a kernel bug here ..
#asahi-gpu · 2023-02-20 21:20
alyssaunk 1 true
#asahi-gpu · 2023-02-20 21:20
alyssabytes per threadgroup 16384
#asahi-gpu · 2023-02-20 21:20
alyssasample count 4
#asahi-gpu · 2023-02-20 21:20
alyssalayout 32x16
#asahi-gpu · 2023-02-20 21:20
alyssatile height=16
#asahi-gpu · 2023-02-20 21:20
alyssasample positions set
#asahi-gpu · 2023-02-20 21:20
alyssasample count=4
#asahi-gpu · 2023-02-20 21:19
alyssaunk 212=8
#asahi-gpu · 2023-02-20 21:19
alyssaz32f+s8 msaa4x has, notably
#asahi-gpu · 2023-02-20 19:06
alyssalina: thanks for the review, your reward is... more patches to review ;p
#asahi-gpu · 2023-02-20 02:43
alyssashrug
#asahi-gpu · 2023-02-20 02:42
alyssathe valhall model i mean
#asahi-gpu · 2023-02-20 02:42
alyssaI guess it's also like heaps in some ways
#asahi-gpu · 2023-02-20 02:42
alyssanah, mali is ... a mix of models that has changed over time
#asahi-gpu · 2023-02-20 02:40
alyssamy brain is very much still in Arm mode
#asahi-gpu · 2023-02-20 02:40
alyssamaybe it is in line with the hardware
#asahi-gpu · 2023-02-20 02:39
alyssaso, shrug
#asahi-gpu · 2023-02-20 02:39
alyssain that you only get 32-bits of VA but can place it wherever you want
#asahi-gpu · 2023-02-20 02:39
alyssaOTOH, shader code and pipelines and things use a heap-like model too

plus ›