#
✕ nick:alyssa
#asahi-gpu · 2023-06-14 19:47
alyssa* threads_per_threadgroup defined in fragment shaders as the tile size
#asahi-gpu · 2023-06-14 19:47
alyssa* thread_position_in_threadgroup.xy defined in fragment shaders as relative to the current tile
#asahi-gpu · 2023-06-14 19:46
alyssasr32 assigns an ID to each tile from 0 to max_concurrent_tiles - 1, such that each concurrently processed tile has a unique index
#asahi-gpu · 2023-06-14 19:46
alyssaup to max_concurrent_tiles
#asahi-gpu · 2023-06-14 19:45
alyssain each core (cluster?), there can be multiple tiles being processed concurrently
#asahi-gpu · 2023-06-14 19:45
alyssathis one is pretty subtle
#asahi-gpu · 2023-06-14 19:45
alyssa* special register 32 giving a sort of tile ID
#asahi-gpu · 2023-06-14 19:45
alyssa(and documented it)
#asahi-gpu · 2023-06-14 19:45
alyssalina already found that one
#asahi-gpu · 2023-06-14 19:45
alyssa* special register 20 given the core (or cluster? what's the difference?) index
#asahi-gpu · 2023-06-14 19:44
alyssait relies on a few hardware features to work:
#asahi-gpu · 2023-06-14 19:44
alyssaIDK if we'll do the same thing. But understanding first.
#asahi-gpu · 2023-06-14 19:44
alyssaI have a good handle on the transform they're doing for the fragment shaders
#asahi-gpu · 2023-06-14 19:44
alyssaI'm combing through a trace of emrt this afternoon
#asahi-gpu · 2023-06-14 16:52
alyssabut first, lunch
#asahi-gpu · 2023-06-14 16:52
alyssaso eMRT is up next
#asahi-gpu · 2023-06-14 16:47
alyssabut CTS seems happy with this if you are
#asahi-gpu · 2023-06-14 16:45
alyssaI'll revisit this post-CTS to deal with the performance hit
#asahi-gpu · 2023-06-14 16:44
alyssacheers
#asahi-gpu · 2023-06-14 16:44
alyssa(I repushed)
#asahi-gpu · 2023-06-14 16:44
alyssatry again with the fix :-D
#asahi-gpu · 2023-06-14 16:44
alyssalina: hold on i fixed the thing steven pointed out
#asahi-gpu · 2023-06-14 16:43
alyssayep definitely not
#asahi-gpu · 2023-06-14 16:43
alyssaprobably not
#asahi-gpu · 2023-06-14 16:40
alyssawe make a good team, you and me :~)
#asahi-gpu · 2023-06-14 16:40
alyssalina: i must say i would not have had the persistence to work through the Darwinia side of this
#asahi-gpu · 2023-06-14 16:39
alyssawe can recover that later. correctness first.
#asahi-gpu · 2023-06-14 16:39
alyssaand I expect that code to regress performance somewhat
#asahi-gpu · 2023-06-14 16:39
alyssaas predicted, it's not a quickfix
#asahi-gpu · 2023-06-14 16:39
alyssarunning through CTS now
#asahi-gpu · 2023-06-14 16:38
alyssabut yknow. should work. probably
#asahi-gpu · 2023-06-14 16:38
alyssaI have not really tested this
#asahi-gpu · 2023-06-14 16:38
alyssalina: steven: https://gitlab.freedesktop.org/asahi/mesa/-/merge_requests/86
#asahi-gpu · 2023-06-14 16:18
alyssaif you don't/can't fix it, i'll merge your disable patch
#asahi-gpu · 2023-06-14 16:18
alyssaregardless I can't help with msrtt
#asahi-gpu · 2023-06-14 16:18
alyssafun
#asahi-gpu · 2023-06-14 16:18
alyssaif you could do that I'd appreciate it!
#asahi-gpu · 2023-06-14 16:18
alyssashould be easy to fix hopefully if it's broken
#asahi-gpu · 2023-06-14 16:17
alyssaI would believe it
#asahi-gpu · 2023-06-14 16:17
alyssathere's an unmerged piglit that has problems on other drivers
#asahi-gpu · 2023-06-14 16:17
alyssathere are like, no tests for this ...
#asahi-gpu · 2023-06-14 16:17
alyssafor depth buffers I thought it did but I could've been wrong
#asahi-gpu · 2023-06-14 16:16
alyssafor colour render targets it should Just Work
#asahi-gpu · 2023-06-14 14:21
alyssaare you still live?
#asahi-gpu · 2023-06-14 14:21
alyssathat's fine
#asahi-gpu · 2023-06-14 11:17
alyssalike I believe it, some webrender shaders are chunky
#asahi-gpu · 2023-06-14 11:17
alyssafirefox has worked fine for me so I wonder how that one reproduced
#asahi-gpu · 2023-06-14 11:17
alyssaI admit that's a terrible error message but what that means is that "this shader needs to spill registers and there's no spilling implemented"
#asahi-gpu · 2023-06-14 11:16
alyssa 08:46 <lina> firefox: ../src/asahi/compiler/agx_performance.c:30: agx_occupancy_for_register_count: Assertion `!"" "Register count must be less than the maximum"' failed.
#asahi-gpu · 2023-06-14 11:15
alyssalina: https://github.com/apitrace/apitrace/wiki/Glamor

plus ›