#
✕ nick:alyssa
#asahi-gpu · 2023-07-05 18:56
alyssaare we sure it doesn't flake like that, though?
#asahi-gpu · 2023-07-05 18:52
alyssaI could easily believe that
#asahi-gpu · 2023-07-05 18:50
alyssayou going to write the patch then?
#asahi-gpu · 2023-07-05 18:48
alyssa\o/
#asahi-gpu · 2023-07-05 18:46
alyssaor maybe need even more bits set. IDK
#asahi-gpu · 2023-07-05 18:45
alyssa[encoder memoryBarrier: MTLBarrierScopeBuffers afterStages: MTLRenderStageVertex beforeStages: MTLRenderStageVertex]
#asahi-gpu · 2023-07-05 18:43
alyssamay be necessary to see what metal does after all :|
#asahi-gpu · 2023-07-05 18:43
alyssainteresting
#asahi-gpu · 2023-07-05 18:42
alyssathat's still setting all the other bits too?
#asahi-gpu · 2023-07-05 18:42
alyssauhoh
#asahi-gpu · 2023-07-05 18:37
alyssaella-0: thx
#asahi-gpu · 2023-07-05 18:21
alyssayes
#asahi-gpu · 2023-07-05 18:19
alyssaso sorry about that X_X
#asahi-gpu · 2023-07-05 18:19
alyssahopefully that makes more sense X_X
#asahi-gpu · 2023-07-05 18:18
alyssahttps://gitlab.freedesktop.org/alyssa/mesa/-/blob/agx/es31-v2/src/gallium/drivers/asahi/agx_state.c#L3228-3241
#asahi-gpu · 2023-07-05 18:18
alyssaok i was definitely way off
#asahi-gpu · 2023-07-05 18:17
alyssaam i wrong the wrong branch
#asahi-gpu · 2023-07-05 18:17
alyssauh, no
#asahi-gpu · 2023-07-05 18:10
alyssajannau: any luck?
#asahi-gpu · 2023-07-05 17:48
alyssabut in this case since we know what we're looking for bruteforcing might be faster anyway lol
#asahi-gpu · 2023-07-05 17:47
alyssaIf someone has the ability to run wrap.dylib + agxdecode against t600x this corresponds to a metal memory barrier, that's where I got those magic bits in the first place
#asahi-gpu · 2023-07-05 17:47
alyssatry setting more bits (this will require adding extra fields in asahi/lib/cmdbuf.xml)
#asahi-gpu · 2023-07-05 17:46
alyssaSee line 2892 of agx_state.c
#asahi-gpu · 2023-07-05 17:46
alyssathe barrier we're using is strong enough to flush a cluster but not the whole system
#asahi-gpu · 2023-07-05 17:45
alyssaI'm wondering if this is morally the same issue as the atomics
#asahi-gpu · 2023-07-05 17:45
alyssasince we dispatch xfb with the VDM (i.e. as vertex shaders with no fragment output), that's a forward VDM->VDM dependency, that does not require a full flush of the batch, but it does require a memory barrier
#asahi-gpu · 2023-07-05 17:44
alyssajannau: The potentially "spicy" part of those tests is that they feed transform feedback results into the inidrect draw
#asahi-gpu · 2023-07-05 17:43
alyssadefinitely passes on M1
#asahi-gpu · 2023-07-05 17:43
alyssaInteresting
#asahi-gpu · 2023-07-05 17:41
alyssaoof
#asahi-gpu · 2023-07-05 17:41
alyssawhat this time?
#asahi-gpu · 2023-07-05 17:41
alyssa:'(
#asahi-gpu · 2023-07-05 17:40
alyssaM1 seemed to finish
#asahi-gpu · 2023-07-05 16:49
alyssadeqp-runner does a bunch of debug stuff for failing tests, idk what the real CTS runner is doing
#asahi-gpu · 2023-07-05 16:49
alyssasure
#asahi-gpu · 2023-07-05 16:48
alyssaso..
#asahi-gpu · 2023-07-05 16:47
alyssanominally the ultra but the CTS is completely single threaded CPU bound
#asahi-gpu · 2023-07-05 16:47
alyssawho will win? =D
#asahi-gpu · 2023-07-05 16:47
alyssaanyway, M1 CTS is running
#asahi-gpu · 2023-07-05 16:47
alyssaeasier just to do the x11_egl run for now
#asahi-gpu · 2023-07-05 16:47
alyssameh
#asahi-gpu · 2023-07-05 16:47
alyssaanyway, M1 CTS is running
#asahi-gpu · 2023-07-05 16:46
alyssa(Strictly you could do a Wayland run with your patch and point to it and say "look it's your bug" but it would complicate things.)
#asahi-gpu · 2023-07-05 16:45
alyssabut... should pass, probably, maybe? O:)
#asahi-gpu · 2023-07-05 16:45
alyssaThat doesn't have your wide_color fix on the mesa side, and the 10-bit thing still hasn't landed upstream anyway, so unfortunately still an x11_egl run
#asahi-gpu · 2023-07-05 16:43
alyssajannau: alyssa/mesa:agx/es31-v2
#asahi-gpu · 2023-07-05 16:43
alyssakicking off CTS on M1 to break sure I didn't break anything in the meantime
#asahi-gpu · 2023-07-05 16:38
alyssajannau: Let me get you a non-stupid branch to use
#asahi-gpu · 2023-07-05 16:36
alyssathen https://rosenzweig.io/0001-asahi-agx-Set-coherency-bit-for-clustered-targets.patch should work everywhere
#asahi-gpu · 2023-07-05 16:35
alyssak, yeah

plus ›