#
✕ nick:alyssa
#asahi-gpu · 2023-08-22 02:26
alyssa~= if the pass made any change to the shader
#asahi-gpu · 2023-08-22 02:26
alyssai509vcb: Typically, whether the pass made "progress"
#asahi-gpu · 2023-08-21 22:55
alyssanod
#asahi-gpu · 2023-08-21 22:55
alyssae.g. you will never see a load_ssbo_address in Vulkan
#asahi-gpu · 2023-08-21 22:55
alyssaPart of it is that a big chunk of agx_nir_lower_sysvals is descriptor-related, and VK doesn't want any of that code because the equivalent lowering happens in the descriptor set code
#asahi-gpu · 2023-08-21 22:54
alyssaagx_nir_lower_sysvals.c was designed for vk's benefit :)
#asahi-gpu · 2023-08-21 22:54
alyssathe whole reason that sysvals get lowered in the gl driver is *because* i'm under the impression agxv will want to do something different than gl
#asahi-gpu · 2023-08-21 22:53
alyssai509vcb: Almost certainly should *not* be common
#asahi-gpu · 2023-08-20 15:35
alyssajannau: Alright. Worth looking into why mesa/st is falling down into software, I guess.
#asahi-gpu · 2023-08-20 14:16
alyssaoh no apple's compiler strongly disagrees with that
#asahi-gpu · 2023-08-20 14:08
alyssaooh, for the specific range of [0, 31) it might be doable in 1 IC + 1 SCIB with the `extr` instruction and some magic constants
#asahi-gpu · 2023-08-20 14:07
alyssathis is not relevant :~)
#asahi-gpu · 2023-08-20 14:04
alyssawhich is actually faster? who knows
#asahi-gpu · 2023-08-20 14:04
alyssathe two obvious approaches are multiply-and-shift (2 IC operations) or convert-multiply-convert (2 SCIB + 1 F16)
#asahi-gpu · 2023-08-20 14:04
alyssameanwhile i'm trying to figure out the fastest way for AGX assembly to divide/modulo a small integer by 3
#asahi-gpu · 2023-08-20 13:58
alyssaok, umm
#asahi-gpu · 2023-08-20 13:58
alyssajannau: ..Right, I also forgot the uapi bump. Uff.
#asahi-gpu · 2023-08-20 13:37
alyssa:+1:
#asahi-gpu · 2023-08-20 13:15
alyssaotherwise, I guess try to figure out why st_GetTexSubImage is bailing to software
#asahi-gpu · 2023-08-20 13:15
alyssaI don't /think/ so, but..
#asahi-gpu · 2023-08-20 13:15
alyssaI'm wondering if the fast path needs GLES3.1
#asahi-gpu · 2023-08-20 13:14
alyssacan you try building asahi/mesa:main and seeing if it still reproduces?
#asahi-gpu · 2023-08-20 13:14
alyssajannau: oh, hmm
#asahi-gpu · 2023-08-20 13:14
alyssasee st_getTexSubImage
#asahi-gpu · 2023-08-20 13:12
alyssaoff hand i'm not 100% sure why that isn't happening / how to make it happen
#asahi-gpu · 2023-08-20 13:11
alyssaideally, the format conversion would happen as part of the blit on the GPU
#asahi-gpu · 2023-08-20 13:11
alyssajannau: that would indeed be CPU format conversion :|
#asahi-gpu · 2023-08-20 00:20
alyssamight be worth fiddling with PIPE_CAP_TEXTURE_TRANSFER_MODES
#asahi-gpu · 2023-08-20 00:20
alyssaworth checking a profiler (I like sysprof) to see what's going wrong
#asahi-gpu · 2023-08-20 00:19
alyssaI thought we did that properly, but it's possible we're going down a slow path somewhere deep in mesa .. CPU format conversion directly from write-combine memory, for ex, would cause unusable slow..
#asahi-gpu · 2023-08-20 00:19
alyssajannau: that 'should' be implemented by a blit on the GPU to a writeback buffer and then a CPU read from the writeback buffer, which is b/w heavy but should not cause unusable slowness on m1-class hardware
#asahi-gpu · 2023-08-17 23:58
alyssaIDK why they're checking only the renderer
#asahi-gpu · 2023-08-17 23:58
alyssathis has the commit hash
#asahi-gpu · 2023-08-17 23:58
alyssaOpenGL core profile version string: 3.1 Mesa 23.3.0-devel (git-2866d6991e)
#asahi-gpu · 2023-08-17 23:56
alyssathanks :)
#asahi-gpu · 2023-08-17 23:56
alyssahere I was worried this was a regression I introduced ;~P
#asahi-gpu · 2023-08-17 23:56
alyssajannau: oh, good
#asahi-gpu · 2023-08-17 23:46
alyssaThe on-screen symptom is that Chromium rendering is totally broken
#asahi-gpu · 2023-08-17 23:45
alyssaMESA_SHADER_CACHE_DISABLE=1 'seems' to workaround which points at a Mesa bug but it's hard to say
#asahi-gpu · 2023-08-17 23:45
alyssaI can't tell if this a Mesa bug or a Chromium one
#asahi-gpu · 2023-08-17 23:45
alyssa[4983:4983:0817/194416.716259:ERROR:shared_context_state.cc(81)] Skia shader compilation error
#asahi-gpu · 2023-08-17 23:45
alyssalink failed but did not provide an info log
#asahi-gpu · 2023-08-17 23:45
alyssaErrors:
#asahi-gpu · 2023-08-17 23:45
alyssasometimes it fails to start properly and spams stderr with messages like
#asahi-gpu · 2023-08-17 23:45
alyssasince rebasing I'm getting weird Chromium issues
#asahi-gpu · 2023-08-17 21:29
alyssahttps://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22334
#asahi-gpu · 2023-08-17 21:29
alyssanot compute
#asahi-gpu · 2023-08-17 21:29
alyssathat's an optimization for mesh shaders
#asahi-gpu · 2023-08-17 21:28
alyssawhich again you don't know for indirect dispatch
#asahi-gpu · 2023-08-17 21:27
alyssait just relies on the driver passing in a constant count

plus ›