#asahi-dev · 2026-11-12 13:28
yukafrustrating#asahi-dev · 2026-11-12 13:28
yukacheckpatch.pl --strict, make dt_binding_check, make dtbs_check, make dtbs W=1 all pass#asahi-dev · 2026-11-12 13:27
yukanope I can not find any checks producing any warnings on this#asahi-dev · 2026-11-12 13:18
yukaI also just don't see what could be wrong with it :/#asahi-dev · 2026-11-12 13:16
chaos_princesswell, something needs to run it, don't remember what exactly#asahi-dev · 2026-11-12 13:16
yukaI think that's dtbs_check if anything#asahi-dev · 2026-11-12 13:16
yukacheckpatch.pl does not do any yamllint?#asahi-dev · 2026-11-12 13:15
chaos_princessdo you have yamllint installed?#asahi-dev · 2026-11-12 13:15
yukaIs my checkpatch.pl somehow borked?#asahi-dev · 2026-11-12 13:14
yukacheckpatch.pl --strict does not show a single warning?#asahi-dev · 2026-11-12 13:13
yukadoes anyone see any possible problems with this?#asahi-dev · 2026-11-12 13:13
yukahttps://lore.kernel.org/asahi/20261106-apple-dts-m4-m5-nvme-v1-0-22f4827b4ece@cyberchaos.dev/T/#asahi-dev · 2026-11-12 13:12
yukaI don't get it#asahi-dev · 2026-11-11 17:24
svendidn't realize they released it afterwards#asahi-dev · 2026-11-11 17:24
svenyeah, that's what I hope as well#asahi-dev · 2026-11-11 17:23
jannauI can trace atc on m3 ultra. given that m3 ultra was released after m4 pro/max I think (hope?) it's unlikely that differs significantly#asahi-dev · 2026-11-11 17:14
sventhis looks different enough such that if/then in the dt-binding would get annoying#asahi-dev · 2026-11-11 17:14
svenwe should probably rename apple,atcphy.yaml to apple,t8103-atcphy.yaml as well since I'll probably create apple,t6040-atcphy.yaml (or whatever m3 ultra is if it's really the same there)#asahi-dev · 2026-11-11 17:11
svenat least XNU is very verbose again, still need to map MMIO pokes to register names though#asahi-dev · 2026-11-11 17:10
svenugh... let's see then :d#asahi-dev · 2026-11-11 17:10
chaos_princessso, pmpv2 also looked like that before i realized that you also need to poke it via a random pmgr mapping :P#asahi-dev · 2026-11-11 17:09
svenand the co-processor seems to be very useless, you start it with the usual rtkit dance and then never interact with it again before shutdown afaict#asahi-dev · 2026-11-11 17:09
chaos_princessyea, i don't think we can sweep the differences under a m1n1-shaped rug there#asahi-dev · 2026-11-11 17:09
sventunables look very different fwiw#asahi-dev · 2026-11-11 17:08
svenneed to stare a bit more at traces anyway#asahi-dev · 2026-11-11 17:08
svenokay, nice, I'll wait for that then#asahi-dev · 2026-11-11 17:04
chaos_princesswill probably just replace all if (hw->gen == whatever) with callbacks to things in hw#asahi-dev · 2026-11-11 17:03
chaos_princessunless phy maintainers have something else to say - yes, i will be splitting it up#asahi-dev · 2026-11-11 17:03
svenchaos_princess: do you plan to split atc.c for v2? asking because I'll definitely need to do that for m4 pro I think#asahi-dev · 2026-11-11 13:25
jannauonly checked bugzilla after writing a similar patch#asahi-dev · 2026-11-11 13:24
jannausomeone already wrote a patch for Firefox sandbox HW decoding: https://bugzilla.mozilla.org/show_bug.cgi?id=2080696#asahi-dev · 2026-11-11 10:14
MichaelReeves[m]we tested it and it worked so I will send it on-list Friday AEST, unless anyone would like more time to review at the code beforehand (which is totally fine).#asahi-dev · 2026-11-11 07:45
yukacompiling it now#asahi-dev · 2026-11-11 07:35
MichaelReeves[m]code review / feedback also appreciated if anyone has any#asahi-dev · 2026-11-11 07:35
MichaelReeves[m]it should work, but I did make some changes so I might've made a mistake somewhere#asahi-dev · 2026-11-11 07:26
MichaelReeves[m]yuka: thank you! I've uploaded them here: https://github.com/IntegralPilot/linux/pull/2#asahi-dev · 2026-11-11 07:19
yukadoesn't actually seem too difficult though#asahi-dev · 2026-11-11 07:18
yukawas a bit surprised there is not much prior art for unit testing code dealing with MMIO accesses#asahi-dev · 2026-11-11 07:18
yukaBtw I didn't forget about the pcie init code cleanup, I'm just looking into options for writing unit and/or integration tests before I actually touch any of this#asahi-dev · 2026-11-11 06:47
yukaI can test them#asahi-dev · 2026-11-11 06:09
MichaelReeves[m]unfortunately I checked and none of the devices in my house can be a 6 GHz AP. if I upload my draft series, is anyone OK to test it out (I will add you as Tested-By)?#asahi-dev · 2026-11-10 20:36
svenI was worried they changed that part#asahi-dev · 2026-11-10 20:36
svenall the sequencing with dwc3, etc. seems to be just the same#asahi-dev · 2026-11-10 20:36
svenm4 pro atcphy really doesn't look too bad. different MMIO pokes and you need to start a random co-processor in the middle and then just not interact with it :D#asahi-dev · 2026-11-10 17:52
chaos_princessdm#asahi-dev · 2026-11-10 17:52
jgoyvaertsits only in asahi#asahi-dev · 2026-11-10 17:52
svenif it’s upstream just follow the usual Linux stuff #asahi-dev · 2026-11-10 17:52
chaos_princessis it asahi-specific, or linux in general?#asahi-dev · 2026-11-10 17:42
jgoyvaertshey guys is there a security contact for security issues in asahi kernel?#asahi-dev · 2026-11-10 17:38
danield75Great, thank you. I’ll take a look and see where I get, might be later this week but I really appreciate the guidance!