#
#asahi-dev · 2024-05-11 10:04
chadmedeugh and kwin is actively trying to do away with the distinction to match the universal plane api anyway
#asahi-dev · 2024-05-11 09:57
jannaufalling back to an overlay plane if no cursor plane is provided would be reasonably
#asahi-dev · 2024-05-11 09:56
jannau"For userspace which is universal plane aware and which is using that atomic IOCTL there’s no difference between these planes"
#asahi-dev · 2024-05-11 09:56
jannauhttps://www.kernel.org/doc/html/latest/gpu/drm-kms.html?highlight=drm_plane_type_overlay#c.drm_plane_type
#asahi-dev · 2024-05-11 09:56
jannauuser space applications could, the kernel documentation doesn't require anything
#asahi-dev · 2024-05-11 09:29
chadmedthe only reason i added them in the first place was because MPV can't do ARGB and all i needed was to see if applications would pick up and use the plane. but then it just ended up working as it should :p
#asahi-dev · 2024-05-11 09:25
chadmedlike if other applications arent going to behave and we cant assume that they will initialise the X channel, then i will just remove the XRGB formats from the list
#asahi-dev · 2024-05-11 09:24
chadmedwell yeah thats what i was sort of asking. mpv's initialises things properly but if we cant rely on other applications doing the same then i assume we're just going to get a framebuffer-sized black square?
#asahi-dev · 2024-05-11 09:23
jannauhow are your X pixels initialized when using XBGG or XRGB? if they are set to 0 of course it will work
#asahi-dev · 2024-05-11 09:22
chadmedxorg, kwin and weston all behave correctly wrt cursor. the plane is not being instantiated as a cursor plane so no compositor should be trying to use it like that
#asahi-dev · 2024-05-11 09:20
chadmedno theres another comment in apple_drv.c that says overlays "must not" advertise XRGB at all
#asahi-dev · 2024-05-11 09:19
jannauare you referring to "DCP doesn't support XBGR8 / XRGB8 natively."
#asahi-dev · 2024-05-11 09:19
chadmedwhich compositors try to use DRM_PLANE_TYPE_OVERLAY for cursors?
#asahi-dev · 2024-05-11 09:17
jannauI don't understand what your referring to. you can't enable overlays because it certainly will break HW cursors with some compositors
#asahi-dev · 2024-05-11 09:15
chadmedlike if its going to break some other use case it's no trouble to just get rid of it of course
#asahi-dev · 2024-05-11 09:13
chadmedjannau, alyssa: was there a technical reason dcp overlay planes shouldnt advertise support for/implement premultiplied RGB formats? ive been dicking around with mpv's osd/subtitle overlay and it all seems to work as intended even when in XRGB8888
#asahi-dev · 2024-05-11 07:24
jannaubut that means that the patches will be rebased on each v6.x.y release and change commit ids but not contents
#asahi-dev · 2024-05-11 07:23
jannauI'm unsure which is the better model. since stable patches can introduce regressions (see bt in v6.8.9) I see use in rebasing on stable releases
#asahi-dev · 2024-05-11 07:20
jannaujohn-cabaj: I started doing rebases onto linux stable releases. For two reasons, 1. the wifi branch conflicted non-trivially with 6.8.4 2. some distro's are consuming the tags as is, i.e. don't get any linux stable fixes themself
#asahi-dev · 2024-05-11 00:33
chadmedhehe were plain ARGB/ABGR formats ever tested
#asahi-dev · 2024-05-10 18:41
john-cabajjannau: When new release tags are made, I notice previous commits have changed history - not necessarily content, but the commit dates. Do commits from previous release tags get updated frequently enough that it would be better to always update every Asahi patch for each Ubuntu Asahi release, or is it safe to just find the new commits with different commit messages and assume those are new, and the old commits are s
#asahi-dev · 2024-05-10 13:13
leio(typically a graphics/display driver bug)
#asahi-dev · 2024-05-10 13:12
leiobut I just get a bunch of green
#asahi-dev · 2024-05-10 13:12
leioI mean, might be just a matter of something like `gst-launch-1.0 uridecodebin3 uri=file:///path/to/file ! videoconvertscale ! gldownload ! 'video/x-raw(memory:DMABuf)' ! waylandsink fullscreen=true`
#asahi-dev · 2024-05-10 13:06
chadmedrather than mess about with trying to pipe gstreamer's buffers into dmabuf or whatever
#asahi-dev · 2024-05-10 13:06
chadmedi think therefore the easiest option will be to teach mpv's drm backend about planar formats
#asahi-dev · 2024-05-10 13:06
chadmedez clap overlay planes work
#asahi-dev · 2024-05-10 12:54
leiobut then we'd still need the compositor to put it in an overlay plane, perhaps waylandsink fullscreen=true is sufficient for that
#asahi-dev · 2024-05-10 12:53
leiobut I guess the tricky part was also to integrate with GTK, so maybe if we skip that and send straight to waylandsink maybe.
#asahi-dev · 2024-05-10 12:52
leiowe might be able to sneak in a gldownload element in a gst-launch-1.0 pipeline which seems to be able to copy from GL memory to DMABuf memory
#asahi-dev · 2024-05-10 12:51
chadmedlet me see how mpv does it. it has a drm backend and already supports a bunch of drm formats, just not planar yuv
#asahi-dev · 2024-05-10 12:51
leiofor testing
#asahi-dev · 2024-05-10 12:51
leiobut with a custom pipeline we might be able to make a copy to dmabuf memory
#asahi-dev · 2024-05-10 12:50
chadmedyeah figured that from the blog posts :c
#asahi-dev · 2024-05-10 12:50
leioI mean the stuff described in those blog posts
#asahi-dev · 2024-05-10 12:50
leiochadmed: I think with gstreamer you can't really get it to dmabuf and offload without something like VAAPI either
#asahi-dev · 2024-05-10 12:35
chadmedit really annoys me that nothing in plasma has any of this hooked up yet
#asahi-dev · 2024-05-10 12:34
leio(note that I don't have gst 1.24 in gentoo yet)
#asahi-dev · 2024-05-10 12:33
leioI don't know whether it works that way
#asahi-dev · 2024-05-10 12:33
leiohttps://blog.gtk.org/2023/11/15/introducing-graphics-offload/ + https://blog.gtk.org/2024/04/17/graphics-offload-revisited/
#asahi-dev · 2024-05-10 12:33
chadmedi assume gstreamer can grab a drm device directly?
#asahi-dev · 2024-05-10 12:32
leiochadmed: latest gnome-shell and gstreamer-1.24 should be able to.
#asahi-dev · 2024-05-10 12:03
chadmedfor context ive hooked up surf.has_planes and family and it works for our single-plane fb formats but i cant test it for planar yuv since nothing seems to want to draw a yuv framebuffer
#asahi-dev · 2024-05-10 12:02
chadmedunless they just took that away between last time i tried and now for some reason
#asahi-dev · 2024-05-10 12:02
chadmedsmh i cant remeber how i got weston to output YUV video from vlc to an overlay plane
#asahi-dev · 2024-05-09 17:30
nicolas17macOS 14.5 RC is out
#asahi-dev · 2024-05-09 10:26
chadmeda lot of whacky symbols with "fence" in them :p
#asahi-dev · 2024-05-09 10:25
chadmedthat seems to line up with whats in the bunched up call graph
#asahi-dev · 2024-05-09 10:24
jannaumarcan identified a possible explanation for it in #asahi-fedora-dev
#asahi-dev · 2024-05-09 10:24
sam_oh u

plus ›