#asahi-dev · 2024-05-12 09:53
chadmedfor_each_oldnew_plane_in_state seems to not have a set order, and dcp seems to expect to receive surfaces in order#asahi-dev · 2024-05-12 09:52
chadmedvery funny and silly fix: l = new_state->zpos#asahi-dev · 2024-05-12 09:52
chadmedit even works with small cursors#asahi-dev · 2024-05-12 09:52
chadmedi tamed the beast! (kinda) #asahi-dev · 2024-05-12 09:49
svenI guess we can at least send the two fixes after the 4388 support commit as well#asahi-dev · 2024-05-12 09:46
sveni'm glad we're doing this now before git send-email ;)#asahi-dev · 2024-05-12 09:45
jannausven: typo "Broadcpm" in include/net/bluetooth/hci.h#asahi-dev · 2024-05-12 09:44
svenalright, i'll wait another day or so and see if luiz replies again and submit it otherwise#asahi-dev · 2024-05-12 09:43
jannauyes, schould be only bcm4387. I have a fixup commit for our out of tree bcm4388 support#asahi-dev · 2024-05-12 09:42
svenyup#asahi-dev · 2024-05-12 09:41
jannaushouldn't the fixes tag be Fixes: 2e7ed5f5e69b ("Bluetooth: hci_sync: Use advertised PHYs on hci_le_ext_create_conn_sync")? also please add "Cc: stable@vger.kernel.org"#asahi-dev · 2024-05-12 09:41
svenso I guess only enable it for 4387#asahi-dev · 2024-05-12 09:41
svengreat, thanks! and I confused 4377 with 4378 :D#asahi-dev · 2024-05-12 09:38
jannausven: feel free to add my Tested-by:#asahi-dev · 2024-05-12 09:37
jannauI think it's not necessary on bcm4378, at least bt le still worked on j274#asahi-dev · 2024-05-12 09:35
jannausven: works, I confused myself for a moment by the missing bcm4388 support upstream#asahi-dev · 2024-05-12 09:22
svenjannau: compile-tested fix for that bluetooth issue: http://f.svpe.de/86097ca156aeb7c02f1e781c2ba290a0f338c6101c912a09b688d10230b78b06_0001-Bluetooth-Add-quirk-to-ignore-reserved-PHY-bits-in-L.patch#asahi-dev · 2024-05-12 08:53
chadmedsimple enough to recompile and check...#asahi-dev · 2024-05-12 08:53
chadmedyeah thats why i asked about 16.16. the arguments to FRAC_16_16 look the wrong way around too?#asahi-dev · 2024-05-12 08:51
jannauI always forget if I already checked if the comment matches the code. looks to me like it might be checking for 4x downscaling and 2x upscaling#asahi-dev · 2024-05-12 08:50
jannauI don't think dcp is complaining about what apple_plane_atomic_check is checking#asahi-dev · 2024-05-12 08:49
chadmedeither way apple_plane_atomic_check doesnt appear to be doing what it's supposed to #asahi-dev · 2024-05-12 08:47
jannauthis has nothing to do with scaling on DRM/KMS level. dcp interprets sizes smaller than 32 as requests for scaling#asahi-dev · 2024-05-12 08:44
chadmed1/2 in 16.16 is ((1 << 16) / 2) right#asahi-dev · 2024-05-12 08:31
chadmedalso not sure why it tolerates some of these but then crashes on others#asahi-dev · 2024-05-12 08:31
chadmedthe fun thing is i can freely wiggle the cursor around with no issues until one of these swaps fails, then the planes swap and dcp treats the cursor as the primary plane until the next failed swap. not sure what is trying to make the fb 64x9 either since the cursor is not actually changing #asahi-dev · 2024-05-12 08:29
chadmedi suspect theres some horsin around with the "legacy" ioctls not calling some atomic helper function because this _only_ happens when setting up the plane as a cursor plane#asahi-dev · 2024-05-12 08:29
chadmedso the check just... isnt checking? #asahi-dev · 2024-05-12 08:29
chadmedIOMFB verify_scaling: layer 1[ARGB]: (64x32) -> (64x9) (min_scale=1/2, max_scale=4): illegal scaling requested#asahi-dev · 2024-05-12 07:36
jannauapparently page flips are slower on dcpext compared to dcp, no or less issues on m1 mac mini#asahi-dev · 2024-05-12 07:23
jannaumin_width/height are checked in addfb2 but we might need to check the plane's CRTC_W/CRTC_H#asahi-dev · 2024-05-12 07:10
chadmedunless it's just crashing for some other reason now#asahi-dev · 2024-05-12 07:10
chadmedjannau: that was the first thing i tried since it is the "correct" way to do it, no dice :p#asahi-dev · 2024-05-12 07:08
jannauchadmed: reject it in apple_plane_atomic_check() then#asahi-dev · 2024-05-12 06:31
chadmedand rejecting the framebuffer in iomfb_flush doesnt seem to do anything? e.g. the text entry beam/resize cursors cause dcp to crash due to being too narrow in one dimension#asahi-dev · 2024-05-12 06:29
chadmedjannau: unfortunately it looks like planes are unaffected by the mode min and max. drm_info reports that the src rectangle can still be [0, UINT32_MAX] in both x and y#asahi-dev · 2024-05-12 05:58
jannaunicolas17: macos uses hw cursors but switches to sw cursors when the cursor hits the screen edges#asahi-dev · 2024-05-12 05:57
jannauthe default cursor size is 64x64, I would expect drm helpers already check / enforce mode_config.min_width / mode_config.min_height#asahi-dev · 2024-05-12 05:27
Wolfram:#asahi-dev · 2024-05-12 00:32
chadmed_im not sure if it's going to be better to put in the work to add like min_x min_y specifications to planes generically or just make the dcp driver reject a swap if the source fb is too small. will compositors respect that? might just test it later#asahi-dev · 2024-05-12 00:22
chadmed_unfortunately this doesnt really explain why it cant do audio bitstream formats. this has been a critical shortcoming of the apple tv for a very long time#asahi-dev · 2024-05-12 00:22
chadmed_this is an issue for dcp as it does not support swap surfaces smaller than 32x32, likely owing to its original use case in apple tvs and idevices. just like how no one needs 4K RAM, who needs a 32x32 framebuffer on a television#asahi-dev · 2024-05-12 00:20
chadmed_but that's kind of irrelevant for us. for optimal video playback etc we need an overlay plane and compositors need to know about it. the issue here is that drm has moved to "universal" planes because most modern hardware doesnt have special snowflake planes _just_ for cursors#asahi-dev · 2024-05-12 00:19
chadmed_nicolas17: i have a suspicion that it doesnt just based on the cursor's behaviour, but i havent traced it or anything#asahi-dev · 2024-05-11 23:48
nicolas17does macOS use hardware cursors?#asahi-dev · 2024-05-11 23:39
chadmedon the other hand, the odd provenance of dcp probably makes it unique in not having been designed with cursors in mind perhaps?#asahi-dev · 2024-05-11 23:39
chadmedi wonder if something like this warrants a drm api. we surely cant be the only hardware that has restrictions like this, and with planes now being fungible...#asahi-dev · 2024-05-11 23:37
chadmedohhh the minimum surface size is 32x32 thats less insurmountable than i thought#asahi-dev · 2024-05-11 10:04
chadmedwell thats no good for us