#
#asahi-dev · 2024-05-12 20:52
chadmedthere is primary, overlay, and cursor
#asahi-dev · 2024-05-12 20:52
leiooh, me not knowing the types thjere maybe? do you mean there's a cursor planer, generic plane and universal plane?
#asahi-dev · 2024-05-12 20:52
chadmedthe problem with consuming an overlay with the cursor is that most hardware either doesnt support them at all or only has two or three planes
#asahi-dev · 2024-05-12 20:51
chadmedi mean overlay planes in general, the point is for that use case
#asahi-dev · 2024-05-12 20:50
leiochadmed: not following now, as you seem to be saying kind of the opposite of what I thought we both meant
#asahi-dev · 2024-05-12 20:49
chadmedi think "universal" really is a misnomer here
#asahi-dev · 2024-05-12 20:49
chadmedleio: that is the point yeah. i dont think it is reasonable for compositors to use generic overlays for the cursor. planes have been universal since 3.x and neither xorg nor any wayland compositor has yet to use overlay planes for the cursor
#asahi-dev · 2024-05-12 18:31
nicolas17sounds like a fun feature /s
#asahi-dev · 2024-05-12 18:30
nicolas17"when you move to the right of the screen, rather than clip out past the bounds of the primary plane as youd expect, the cursor just gets compressed along the x axis" I want to see that :D
#asahi-dev · 2024-05-12 13:49
leioI believe mutter/gnome-shell uses only cursor plane for cursor, but are open to using a generic one for it when needed; I gather it would give more freedom too, so you have more planes available when e.g. mouse cursor is hidden cause you are watching a video and can then put shell chrome in one plane, zero-copy video in another and subtitles on another on top of it, while otherwise it might only work when video is fullscreen
#asahi-dev · 2024-05-12 13:44
leiorighto, was still catching up, sorry
#asahi-dev · 2024-05-12 13:43
svenyeah, see backlog
#asahi-dev · 2024-05-12 13:43
leiosven: "Broadcpm" in one of the comments
#asahi-dev · 2024-05-12 13:22
jannauthe plane types are not going away but it would be reasonable for universal planbe aware user space client to fallback using an overlay plane for HW cursor
#asahi-dev · 2024-05-12 12:36
chadmedso we're still "good" :)
#asahi-dev · 2024-05-12 12:36
chadmedit doesnt mean that all plane types will be treated the same
#asahi-dev · 2024-05-12 12:36
chadmedoh i think we misunderstood the docs. plane types havent/arent going away, userspace just gets to see all of them rather than kms tying the primary and cursor to the crtc internally and using unique ioctls for them
#asahi-dev · 2024-05-12 12:18
chadmedi am slightly worried about universal planes though...
#asahi-dev · 2024-05-12 12:17
chadmedhw cursor specifically is no big deal right now but fixing as much as we can for multiple planes in general will make it less painful to wire them up for video playback and such when we want that eventually
#asahi-dev · 2024-05-12 12:16
chadmedno (obvious) colour space issues observed here, but obv the pros have different screens. will test tomorrow on j314.
#asahi-dev · 2024-05-12 12:15
svenhuh, i didn't realize b4 supports submission via web endpoint instead of smtp. that's very convenient
#asahi-dev · 2024-05-12 12:12
jannauthe issue with with surface 0 is that x2rgb10 wasn't respectinmg the color space and was always using apple's wide rgb space
#asahi-dev · 2024-05-12 12:04
jannauchadmed: the squishing at the edges is dcp's doing. it requires that 32x32 of the cursor plane are on the screen. This is the reason why there is no HW cursor support
#asahi-dev · 2024-05-12 11:39
chadmedi was just about ready to give up too!
#asahi-dev · 2024-05-12 11:38
LarstiQprogress is finding the next problem
#asahi-dev · 2024-05-12 11:38
chadmedbut at least it doesnt just crash now :)
#asahi-dev · 2024-05-12 11:37
LarstiQright
#asahi-dev · 2024-05-12 11:37
chadmedanyway the issue is that dcp does _not_ like framebuffers smaller than 32x32, and will fail to swap. kwin is squishing the cursor down past 8x64
#asahi-dev · 2024-05-12 11:37
LarstiQchadmed: doh :)
#asahi-dev · 2024-05-12 11:36
chadmedtheres no point until at least kwin supports universal planes, as the old api that distinguishes between overlays and cursors is dead
#asahi-dev · 2024-05-12 11:36
LarstiQor at least not such that it's obvious to my eye
#asahi-dev · 2024-05-12 11:36
chadmedyou wont see it happen, we havent wired up hardware planes yet :p
#asahi-dev · 2024-05-12 11:36
LarstiQhmm, not seeing that happen on river I think
#asahi-dev · 2024-05-12 11:35
chadmedits very odd and im sure its not _supposed_ to do that (we are probably doing something odd)
#asahi-dev · 2024-05-12 11:35
chadmedLarstiQ: when you move to the right of the screen, rather than clip out past the bounds of the primary plane as youd expect, the cursor just gets compressed along the x axis such that the rightmost edge of its framebuffer never clips outside the rightmost edge of the primary below it
#asahi-dev · 2024-05-12 11:34
LarstiQhah, nice commit message :)
#asahi-dev · 2024-05-12 11:33
LarstiQchadmed: squishing in which way?
#asahi-dev · 2024-05-12 11:20
chadmedalso surface 0 works on m2 on 13.5. it's getting late now but i will build this patch on j314 and see if it works there now too with 13.5 fw
#asahi-dev · 2024-05-12 11:18
chadmedonly two issues left: stupid behaviour near the edge of the screen (why tf do compositors try to squish the cursor? just noclip out of the bounds of the primary plane), and the fact that alpha doesn't seem to work as it should (the cursor plane is filled with black instead of transparency)
#asahi-dev · 2024-05-12 11:16
chadmedof any size btw
#asahi-dev · 2024-05-12 11:16
chadmedthis fixes dcp crashing when using hardware cursors
#asahi-dev · 2024-05-12 11:16
chadmedhttps://github.com/chadmed/linux/commit/36a275ae2a4a4dd599360fd413b8c1813c886321
#asahi-dev · 2024-05-12 09:59
jannauwhich apparently takes around 0.7 ms longer from swap_submit ot swap_complete
#asahi-dev · 2024-05-12 09:59
jannaufixes the the half rate display on on devices where dcpext is used
#asahi-dev · 2024-05-12 09:58
jannaupushed out asahi-6.8.9-5 with this bt le fix and some "fixups" for the flip complete timestamps so that kwin commits in time
#asahi-dev · 2024-05-12 09:55
svenyeah, same
#asahi-dev · 2024-05-12 09:55
jannausven: I've switched to b4 (https://b4.docs.kernel.org/en/latest/) and that beats manual git format-patch/send-email use by heaps and bounds. especially for cover letter composing and revisions
#asahi-dev · 2024-05-12 09:55
chadmedbut at least it doesnt crash
#asahi-dev · 2024-05-12 09:54
chadmednew issue: alpha doesn't alpha and the cursor plane is filled with black
#asahi-dev · 2024-05-12 09:53
chadmeduserspace will always want the cursor over the primary plane, so just feed the planes into req->surf[] in the order userspace tells us!

plus ›