#asahi-dev · 2025-03-18 21:53
fl0_idoh this is probably the real fix for M3 adt dumping (and M4) instead of just ignoring the error. @mischa85 did you do this or just ignore the error? https://github.com/AsahiLinux/m1n1/pull/418/commits/69f3e4d24bf6c1be686fc1a94e27c5c5b4ef9df0#asahi-dev · 2025-03-18 21:49
fl0_idsven well, it would look like that, because it just put the macros/constants back into midr.h / removed them from the file where the original author duplicated them. so the only remaining part of that is https://github.com/AsahiLinux/m1n1/pull/450/commits/fa3cd4b96fd6acaeb4eca7eeccb2e4ec595b7f24#diff-81896a3d888013ed9999381fea7e22d11b2de48149444a059a54bc37de4814e5#asahi-dev · 2025-03-18 20:44
alyssaah#asahi-dev · 2025-03-18 20:32
jannauyes, make dtbs_check comaplains about "local-mac-address" in the wifi node#asahi-dev · 2025-03-18 20:31
svenwhich we're supposed to do before picking up any updates to the .dts files in our tree#asahi-dev · 2025-03-18 20:31
svenit removes an annoying warning whenever we have to run dt_check (or however that target is called)#asahi-dev · 2025-03-18 20:28
alyssajannau: do we need that for the asahi DTs?#asahi-dev · 2025-03-18 20:24
jannaunice, David Heidelberg picked up my local-mac dt-bindings changes#asahi-dev · 2025-03-18 20:14
svenfl0_id: okay, CI is fixed but I think you have to rebase on master to fix it in your PR as well#asahi-dev · 2025-03-18 20:09
alyssasven: real.#asahi-dev · 2025-03-18 20:07
svenoh well, let's just merge the fix#asahi-dev · 2025-03-18 20:04
jannauI suspected the image switched to a distro installed cargo and thus was missing rustfmt there. so sourcing the env made sense but it used `$HOME/.cargo/bin/cargo`#asahi-dev · 2025-03-18 20:01
svendebugging kernel code on a separate mac is less painful and faster than debugging CI issues for me *sigh*#asahi-dev · 2025-03-18 20:01
svenme neither, but that's common whenever I have to fix something in CI :/#asahi-dev · 2025-03-18 19:59
jannauI don't really understand why that's an issue#asahi-dev · 2025-03-18 19:56
svenhah, nice#asahi-dev · 2025-03-18 19:55
jannauhttps://github.com/AsahiLinux/m1n1/actions/runs/13932265988/job/38992058379?pr=452#asahi-dev · 2025-03-18 19:54
jannausven: looks like `. "$HOME/.cargo/env"` fixes it#asahi-dev · 2025-03-18 19:40
jannauoh, ubuntu latest is 24.04. we should update the llvm install#asahi-dev · 2025-03-18 19:38
sventried it in a ubuntu vm and it worked there as well#asahi-dev · 2025-03-18 19:37
jannauI can't reproduce it in an ubuntu jammy container after installing rustup and nightly toolchain#asahi-dev · 2025-03-18 19:26
svenyeah, i wish i could just ssh into that actions runner and actually debug what's going on#asahi-dev · 2025-03-18 19:24
jannausven: looks more like an rustup issue or change regarding rustfmt#asahi-dev · 2025-03-18 19:19
svenhate debugging CI issues#asahi-dev · 2025-03-18 18:17
svenand I guess we’ll have to figure out how to fix the CI :/#asahi-dev · 2025-03-18 18:16
svenit looks like you just dropped that commit instead of squashing it into the first one #asahi-dev · 2025-03-18 17:38
fl0_idsven squashed that one commit. rebase -i <3#asahi-dev · 2025-03-18 14:03
fl0_idthat's why I wasn't sure what was going on#asahi-dev · 2025-03-18 14:01
fl0_idnickchan ok. yeah I just checked commits just before that and those still worked and I didn't see any workflow changes#asahi-dev · 2025-03-18 14:00
nickchanhttps://github.com/AsahiLinux/m1n1/actions/runs/13925026152/job/38967139843?pr=440#asahi-dev · 2025-03-18 14:00
nickchanfl0_id: nope the ci is just broken not fluke#asahi-dev · 2025-03-18 13:57
fl0_idsven sure that's no problem.#asahi-dev · 2025-03-18 13:55
sveni'm also not the only one who can review these things, even getting someone to test it on M1/M2/whatever and confirm nothing broke would help#asahi-dev · 2025-03-18 13:52
svenprobably not today since those probably need a more careful review since they also touch general code#asahi-dev · 2025-03-18 13:51
nickchanfirst one is uncore pmc because it's different on a11 and the second one fixes the proxyclient by adding support for parsing pmu & pmgr + making the cpu faster#asahi-dev · 2025-03-18 13:50
nickchansven: would you happen to have any time to look at https://github.com/AsahiLinux/m1n1/pull/440 too? https://github.com/AsahiLinux/m1n1/pull/446#asahi-dev · 2025-03-18 13:50
svenrest looks reasonable#asahi-dev · 2025-03-18 13:50
svenfrom a very brief glance i'd probably squash the last commit into the first one#asahi-dev · 2025-03-18 13:47
fl0_idnickchan that issue seems pretty helpful and they have a link to docs#asahi-dev · 2025-03-18 13:47
fl0_idsven ok cool :)#asahi-dev · 2025-03-18 13:45
sven(the PR, not testing on t6030 ;))#asahi-dev · 2025-03-18 13:45
sveni can take a look at it this evening #asahi-dev · 2025-03-18 13:44
fl0_idsven it should. someone on #asahi also said they would test for t6030 but they haven't been online yet again, maybe can tell them later#asahi-dev · 2025-03-18 13:43
nickchan(so this makes s3_4_c15_c14_5 = AGTCNTRDIR_EL2, and s3_4_c15_c14_6 = AGTCNTRDIR_EL12)#asahi-dev · 2025-03-18 13:43
nickchanif this is to be trusted#asahi-dev · 2025-03-18 13:43
nickchanhttps://github.com/utmapp/UTM/issues/6942#asahi-dev · 2025-03-18 13:42
nickchan"s3_1_c15_c1_5 = AGTCNTRDIR_EL1"#asahi-dev · 2025-03-18 13:42
svenyeah, no need to have a perfect pull request. I’m happy as long as it doesn’t break anything and looks like it gets us closer to m3/m4 support #asahi-dev · 2025-03-18 13:36
fl0_idthe different clock frequencies i mean#asahi-dev · 2025-03-18 13:35
fl0_idassuming this counterscaling things is also present on m4, maybe mischa can also contribute to that