#asahi-dev · 2025-03-29 02:30
nicolas17ah I see, only privileges it needs are granted by the "audio" group?#asahi-dev · 2025-03-29 02:25
chadmedyeah #asahi-dev · 2025-03-29 02:19
nicolas17was it root before?#asahi-dev · 2025-03-29 01:57
chadmedive pushed and released speakersafetyd 1.1.0 which runs as the speakersafetyd user by default#asahi-dev · 2025-03-27 22:38
chaos_princessbut, like, why is there a dma attach fail first, and then a aop attach fail?#asahi-dev · 2025-03-27 22:38
chaos_princesslike, ok, i got that wrong at first and dma channels are probed after aop devices are attached#asahi-dev · 2025-03-27 22:38
chaos_princessi am so confused too#asahi-dev · 2025-03-27 22:34
jannauI'm still confused. probe() is only called once but `let dma_chan = data.request_dma_channel()?;` doesn't return. a print on the next line is seen in the log#asahi-dev · 2025-03-27 22:32
chaos_princessok, how many times is probe called#asahi-dev · 2025-03-27 22:32
chaos_princessaaaa#asahi-dev · 2025-03-27 22:32
chaos_princessoh#asahi-dev · 2025-03-27 22:31
jannauthe audio device is created before SndSocAopDriver::new(). that's the last call in probe. not to confuse with SndSocAopData::new() which is called earlier#asahi-dev · 2025-03-27 22:26
chaos_princesscant be, otherwise https://github.com/AsahiLinux/linux/blob/asahi/sound/soc/apple/aop_audio.rs#L377 wouldnt get hit #asahi-dev · 2025-03-27 22:25
jannauno#asahi-dev · 2025-03-27 22:24
jannaufrom_err_ptr(ERR_PTR(-PROBE_DEFER)).is_err() is false?#asahi-dev · 2025-03-27 22:16
chaos_princesslike, i do not see the way to get the output above w/o calling probe() twice?#asahi-dev · 2025-03-27 22:15
chaos_princessbut "Unable to attach device 1885629744..." is an error from line https://github.com/AsahiLinux/linux/blob/asahi/sound/soc/apple/aop_audio.rs#L673#asahi-dev · 2025-03-27 22:15
chaos_princessi just do not understand how you got the output above then. "Unable to get dma channel" is printed from https://github.com/AsahiLinux/linux/blob/asahi/sound/soc/apple/aop_audio.rs#L377 , which is called here https://github.com/AsahiLinux/linux/blob/asahi/sound/soc/apple/aop_audio.rs#L595 and since it got an error, it should exit both SndSocAopData::new and SndSocAopDriver::probe.#asahi-dev · 2025-03-27 22:10
jannauyes#asahi-dev · 2025-03-27 22:02
chaos_princessonly once and fails?#asahi-dev · 2025-03-27 22:02
chaos_princessinteresting#asahi-dev · 2025-03-27 22:02
jannauit's only called once#asahi-dev · 2025-03-27 22:01
chaos_princessi wouldn't be#asahi-dev · 2025-03-27 22:00
jannaudo you expect it to be called more than once? I'd be surprised if it did#asahi-dev · 2025-03-27 21:58
chaos_princess(without your fixes, ofc)#asahi-dev · 2025-03-27 21:57
chaos_princessjannau: mind adding a debug print to https://github.com/AsahiLinux/linux/blob/asahi/sound/soc/apple/aop_audio.rs#L517, and telling me how many times that gets called?#asahi-dev · 2025-03-27 21:51
jannaureproduced without pdm syslog messages: https://paste.centos.org/view/1ac5e5a1#asahi-dev · 2025-03-27 21:42
chaos_princessok, yep, thats a case of someone (me) not handling eprobe_defer correctly. would be annoying to fix though unfortunatelty#asahi-dev · 2025-03-27 21:37
jannauyes, unable to get dma channel. failed to attach devicem and than probe failed with -5#asahi-dev · 2025-03-27 21:36
chaos_princessif so, that is enough#asahi-dev · 2025-03-27 21:36
chaos_princess"Unable to get dma channel", something something?#asahi-dev · 2025-03-27 21:35
jannaufasiled to get dma channel, than aop syslog pdm errors. let me see if I can reproduce it#asahi-dev · 2025-03-27 21:35
chaos_princesscan you still look in dmesg, and how exactly is it failing?#asahi-dev · 2025-03-27 21:34
jannauthe platform/of probe code uses some properties like iommus, dmas, ... for probe ordering. I've worked with https://paste.centos.org/view/8db1f78f around for now#asahi-dev · 2025-03-27 21:32
chaos_princessanything else in dmesg?#asahi-dev · 2025-03-27 21:29
jannaunot sure how the error is propagated. it ended up with returning -EIO#asahi-dev · 2025-03-27 21:28
chaos_princessand, like, does it matter? if platform device is created before admac comes up, should it not just probe later?#asahi-dev · 2025-03-27 21:27
chaos_princessshould it not do that automatically?#asahi-dev · 2025-03-27 21:26
jannauissue is likely that nothing enforces the order from the "dmas" for the manual platformdevice creation#asahi-dev · 2025-03-27 21:26
chaos_princessno, never seen that one before, does aop handle EPROBE_DEFER incorrectly?#asahi-dev · 2025-03-27 21:25
jannauchaos_princess: have you seen a probe order issue between aop_audio and aop_admac? Not sure if I were just lucky to hit that in 6.14 or if it's a 6.14 driver-core/platform probe change#asahi-dev · 2025-03-27 10:44
chadmedthat sorta never happened :p #asahi-dev · 2025-03-27 10:44
chadmednickchan: yeah... when i wrote that we were eager to get some sort of psci thing working #asahi-dev · 2025-03-27 06:13
nickchanin any case id rather for the cursed a10 cpufreq to be fully released into mainline first#asahi-dev · 2025-03-27 06:12
nickchanor I can take that up myself given a10 and a11 only have el0 and el1#asahi-dev · 2025-03-27 06:09
nickchan[cpuidle situtation]#asahi-dev · 2025-03-27 06:08
nickchanprobably not near future#asahi-dev · 2025-03-27 06:08
nickchan>This can never be upstreamed, however the hope is that this hacked together driver becomes unnecessary at some point in the near future.#asahi-dev · 2025-03-27 03:06
nicolas17oh cool#asahi-dev · 2025-03-27 03:06
chadmed_nickchan: nicolas17: ive got a local branch with all the feature support pages cleaned up, just havent had time to do a final check and push