#asahi-dev · 2025-08-03 09:15
svenclosed one minor fix PR that's been stale for 2 years#asahi-dev · 2025-08-03 09:12
jannaueven though they are mostly documentation / examples at this point#asahi-dev · 2025-08-03 09:12
svenif someone runs into the same problem they're probably gonna fix it before noticing there's already a stale PR around#asahi-dev · 2025-08-03 09:11
svenfor the minor fixes I don't care either way#asahi-dev · 2025-08-03 09:11
svenack#asahi-dev · 2025-08-03 09:11
jannauI think the stale trace PRs are useful to keep as open as that makes them easier to discover#asahi-dev · 2025-08-03 09:11
sventrue. doesn't hurt to leave them around though#asahi-dev · 2025-08-03 09:10
chadmedive found that whenever we ask for an S-o-b or minor fixes they usually go AWOL #asahi-dev · 2025-08-03 09:10
chadmedyeah we can do a label and tag the author asking if theyre gonna come back to it #asahi-dev · 2025-08-03 09:10
sven(plus the old stale PRs, i'd just leave them around just in case someone does come back to them. maybe add a stale label or something)#asahi-dev · 2025-08-03 09:09
svenyeah, i wasn't going to suggest to just merge it. just mentioned it because that's the only one no one reviewed so far :)#asahi-dev · 2025-08-03 09:09
chadmedwrt 457 id like some feedback before we merge it obviously. also not sure if we want to do a more modern/rust-y API and bind that back to the libfdt API for C code or just stick with what's in there which is basically 1:1 the libfdt API translated to rust#asahi-dev · 2025-08-03 09:07
svenalright, so from the non-stale PRs we have two for pre-M1 support (where i just left comments), the gpu one, the packit one, the rust compiler warnings, and finally https://github.com/AsahiLinux/m1n1/pull/457#asahi-dev · 2025-08-03 08:55
svenfair enough#asahi-dev · 2025-08-03 08:55
jannausure, was more a reminder for myself to add them#asahi-dev · 2025-08-03 08:55
svenand the current kernel we ship reads the fuses itself anyway#asahi-dev · 2025-08-03 08:54
svenso we can always just add them later#asahi-dev · 2025-08-03 08:54
svenyes, but it won't fail without these#asahi-dev · 2025-08-03 08:54
jannau469 still needs fuses for t600x and t8112 or?#asahi-dev · 2025-08-03 08:53
svenwhat about 471? looks reasonable to me as well#asahi-dev · 2025-08-03 08:49
svenack#asahi-dev · 2025-08-03 08:48
jannauand the kernel is not ready either. My plan was to see if we can have at least for a while both variants supported#asahi-dev · 2025-08-03 08:48
svenok, i'll just ignore that one then and you can merge it whenever you think it's ready :)#asahi-dev · 2025-08-03 08:47
jannauplease wait on GPU init one. I need go through all devices again to verify that the paramters are unchanged#asahi-dev · 2025-08-03 08:47
svenoh right, the gpu stuff fails due to packit as well right now#asahi-dev · 2025-08-03 08:46
svenyeah#asahi-dev · 2025-08-03 08:46
jannauyes, but to avoid the annoying false failures for every PR#asahi-dev · 2025-08-03 08:45
sven*also#asahi-dev · 2025-08-03 08:45
sventhen probably als 474 (unvendor a bunch of stuff) after the packit thing is merged#asahi-dev · 2025-08-03 08:44
svenwe can always fix any bugs, etc. in main later#asahi-dev · 2025-08-03 08:44
svenunless there are objections i'd also merge 460 (chickens cleanup) and 469 (atcphy fuses as tunable). is 466 (gpu blobs in m1n1) ready as well now that the gpu dt bindings are upstream?#asahi-dev · 2025-08-03 08:42
svenyeah, sounds good to me #asahi-dev · 2025-08-03 08:35
jannauposted to #fedora-asahi-devel as well, let's wait a few days before merging it#asahi-dev · 2025-08-03 08:30
jannauhttps://github.com/AsahiLinux/m1n1/pull/477#asahi-dev · 2025-08-03 08:23
jannauI agree#asahi-dev · 2025-08-03 08:21
sventrue #asahi-dev · 2025-08-03 08:13
chadmedit also binds us to fedora more than i would like the upstream project to be#asahi-dev · 2025-08-03 08:12
chadmedi would like to disable packit in our repos tbh. its not useful for what we do because the repos do not host the specfiles#asahi-dev · 2025-08-03 08:10
svenagreed #asahi-dev · 2025-08-03 08:08
jannauI think we should solve that differently, i.e. either not run those checks in github or use a rpm spec inside the github m1n1 repo#asahi-dev · 2025-08-03 08:07
svenbut I can live with that if it’s not easy to fix #asahi-dev · 2025-08-03 08:07
jannaubut overall the checks are bad because they are using an out of sync rpm .spec#asahi-dev · 2025-08-03 08:06
svenI just don’t like the red x there :D#asahi-dev · 2025-08-03 08:06
jannauthey are just warnings in the sense that the failures do not block merging#asahi-dev · 2025-08-03 07:54
svenhttps://github.com/AsahiLinux/m1n1/pull/474 Can we somehow disable that rpm stuff or mark fails there as warning only?#asahi-dev · 2025-08-02 17:09
sveni guess that worked#asahi-dev · 2025-08-02 17:09
svenhttps://github.com/AsahiLinux/m1n1/releases/tag/v1.5.0#asahi-dev · 2025-08-02 17:06
svenlet's merge it and tag the release then#asahi-dev · 2025-08-02 16:49
jannauhttps://github.com/AsahiLinux/m1n1/pull/476 would make my life a little easier but I can deal with it until the next release#asahi-dev · 2025-08-02 16:48
jannausven: I think so. marcan or I also took care of updating the fedora package but that's a separate task anyway