#
#asahi-dev · 2025-08-16 13:11
svenshouldn't it live somewhere more generic in the form of helpers?"
#asahi-dev · 2025-08-16 13:11
svendriver. Is this specific to this device? If it's generic math stuff,
#asahi-dev · 2025-08-16 13:11
sven"This seems like it's to technical / generic to live in a lowly device
#asahi-dev · 2025-08-16 13:11
svenhttps://lore.kernel.org/asahi/20250509135104.GC2492385@google.com/
#asahi-dev · 2025-08-16 13:09
svenbut i kinda agreed that we would not increase the smc api
#asahi-dev · 2025-08-16 13:09
chadmedi think its kinda gross and stupid to have this _one_ solitary core smc function live inside the hwmon driver
#asahi-dev · 2025-08-16 13:09
svenlet me see if i can find lee's objection to that function again and what he suggested instead
#asahi-dev · 2025-08-16 13:08
chadmeddepends on if we expect apple to make any other keys we might require floats
#asahi-dev · 2025-08-16 13:08
sven*hwmon
#asahi-dev · 2025-08-16 13:08
svendo we need that anywhere outside of hwmod?
#asahi-dev · 2025-08-16 13:07
chadmedkinda a hard requirement
#asahi-dev · 2025-08-16 13:07
chadmedthe f32 stuff is uhhh
#asahi-dev · 2025-08-16 13:06
chadmedack
#asahi-dev · 2025-08-16 12:47
svenand maybe reorder the commits so that the dt-binding changes all come directly after the cover letter
#asahi-dev · 2025-08-16 12:47
svenyou should also pick up the tags that the rtc series already got
#asahi-dev · 2025-08-16 12:40
svencheck the SMC series, that f32 stuff isn’t going be accepted inside mfd
#asahi-dev · 2025-08-16 11:54
chadmedwip branch is here https://github.com/chadmed/linux/commits/b4/macsmc-subdevs/
#asahi-dev · 2025-08-16 11:42
chadmedokay that was pretty trivial actually
#asahi-dev · 2025-08-16 10:31
jannauI've pushed `asahi-6.16.1-1` to github, rebase, a few kernel-robot fixes squashed in and imported the btrfs log replay fix (not in v6.16.1)
#asahi-dev · 2025-08-16 10:29
svensounds good
#asahi-dev · 2025-08-16 10:29
svenyeah
#asahi-dev · 2025-08-16 10:29
chadmedill make sure the series as a whole applies cleanly though
#asahi-dev · 2025-08-16 10:29
svenanyway, i'll push the commits later. feel free to either add hid or keep it separate and i'll then upstream it later
#asahi-dev · 2025-08-16 10:29
chadmedif they all end up being pulled via different trees, yeah
#asahi-dev · 2025-08-16 10:28
svennow that i'm thinking about it we may even get (trivial) conflicts adding the various drivers' MFD_CELL to macsmc.c
#asahi-dev · 2025-08-16 10:27
sveneh, multiple drivers for mfd seems to be quite common
#asahi-dev · 2025-08-16 10:26
chadmedkinda feel like even this approach will end up pissing someone off because we are submitting multiple drivers at once but eh
#asahi-dev · 2025-08-16 10:26
chadmedsven: yeah no worries just point me in the direction of the patches i need to pull
#asahi-dev · 2025-08-16 09:58
svenchadmed: might even make sense to add hid to that series while we're at it. i can push the version i was going to submit and i'll take care of all review comments ofc
#asahi-dev · 2025-08-16 07:17
jannauthe non-desktop property might break things as well but weston at least starts after deinstalling tiny-dfr (which needs convinincing on FAR since it's a dependency of the meta package)
#asahi-dev · 2025-08-16 07:14
jannaulooks like the seat-touchbar trickery in tiny-dfr breaks using the touchbar display with compositors: https://www.reddit.com/r/AsahiLinux/comments/1mrjybj/touchbar_as_drm_device_backend_for_wayland/
#asahi-dev · 2025-08-16 07:01
svengreat, I’ll reply to the rtc series later
#asahi-dev · 2025-08-16 06:32
chadmedezpz ive already rebased on -rc1
#asahi-dev · 2025-08-16 06:28
svenand thanks :)
#asahi-dev · 2025-08-16 06:28
svenyes, just make sure all the other patches apply cleanly to -rc1
#asahi-dev · 2025-08-16 00:15
chadmeds/and,/,/
#asahi-dev · 2025-08-16 00:14
chadmedsven: so is the strat here to base the hwmon and rtc patches on 6.17 and, ignore the missing SMC dt nodes, and just note that we will take the dts patches ourselves once theyre reviewed?
#asahi-dev · 2025-08-15 21:06
chadmedsven: yeah no stress
#asahi-dev · 2025-08-15 17:07
svenchadmed: robher wants to review all additional mfd subnodes for smc at once. do you mind submitting RTC together with hwmon? that's the only other sub-device that needs dt bindings and probably needs more discussion that the rather simple rtc subnode
#asahi-dev · 2025-08-15 14:15
chadmedi fixed the other one by simply deleting it :P
#asahi-dev · 2025-08-15 12:08
chadmedokay all cleaned up
#asahi-dev · 2025-08-15 11:40
chadmedwhat ive done here ensures that we will never cut a m1n1 release with buggy ffi btw, ive just kept it in the "intermediate" commits for storytelling and to not break rebases/bisects
#asahi-dev · 2025-08-15 11:40
chadmedive only found load-bearing UB in two functions so far, one of which can be fixed by just factoring out some code. let me finish the git surgery and you can review the MR and see if you'd prefer to fix the C side versus what ive done here
#asahi-dev · 2025-08-15 11:32
jannauhow much additional effort would be to fix C completely first? it would be a little cleaner because it avoids supporting buggy behavior in rust/ffi
#asahi-dev · 2025-08-15 11:25
chadmedholy shit fixing that actually made things noticeably faster too
#asahi-dev · 2025-08-15 11:11
chadmedmakes bisecting a hell of a lot easier
#asahi-dev · 2025-08-15 11:11
chadmedi could just do the classic enterprise b2b saas `git commit -m "fixes"` strat but i think its nice when every commit actually builds and works
#asahi-dev · 2025-08-15 11:10
chadmedi need to recreate the UB in the FFI binding intially, then once i fix the caller relying on that UB refactor the callee and then fix the original binding to use the sound version
#asahi-dev · 2025-08-15 11:10
chadmedits okay i can fix it, its just a messy commit history
#asahi-dev · 2025-08-15 11:04
LarstiQyikes

plus ›