#
#asahi-dev · 2025-12-21 20:07
oliverCould be
#asahi-dev · 2025-12-21 19:55
jannauI think we're speaking past each other
#asahi-dev · 2025-12-21 19:46
oliverbut they are not. all tsX are in the same ballpark. ts2-ts1 and ts3-ts1 are always about 12-14ms
#asahi-dev · 2025-12-21 19:45
jannauI mean relative to one of the ts fields. i.e. ts_X is the current time and the other fields are relative to it
#asahi-dev · 2025-12-21 19:44
oliveror 60hz, depending on what content is visible
#asahi-dev · 2025-12-21 19:43
oliverand with rrate i mean 120hz here, not the real swap rate
#asahi-dev · 2025-12-21 19:41
oliver * i get about ~5 swap submit commands per second with ts1 increasing by exactly 1/rrate on each command. if they were related to any realtime-like clock, again, the difference between two swap commands would not be exactly 1/rrate.
#asahi-dev · 2025-12-21 19:41
oliverbut that does not make sense:
#asahi-dev · 2025-12-21 19:41
oliver * if they were relative, ts1 wouldn't increment by exactly 1/rrate.
#asahi-dev · 2025-12-21 19:38
jannaubut I wouldn't rule out that the timestamps are all relative. that would explain why setting a static value works
#asahi-dev · 2025-12-21 19:37
jannauoliver: I wouldn't necessarily trust timestamps vs real time relations from traces
#asahi-dev · 2025-12-21 19:31
oliverthe dcp tracing values need more interpretation?
#asahi-dev · 2025-12-21 19:31
oliverjannau, chadmed: just reading the conversation here. "setting ts1 = now + (1 / refresh rate) * 1e9, ts2 = last time we got dcp_swapped and ts3 = now" it just doesn't match the data from dcp trace at all. i wrote this on github: ts1 does not depend on real time and only increments by 1 / desired refresh rate. ts2 is approx ts1+14ms and ts3 is approxy ts1+12ms. Both are slightly varying from frame to frame. or do i missing something and
#asahi-dev · 2025-12-21 19:30
jannaumacbook pro hdmi out fixed
#asahi-dev · 2025-12-21 17:58
nickchana small patch will make the existing code work
#asahi-dev · 2025-12-21 17:57
nickchanalright figured rtkit v10 (iOS 11-13); only critical difference is epmap is completed within 1 message so MGMT_MSG_EPMAP_REPLY_DONE and MGMT_MSG_EPMAP_REPLY_MORE doesn't exist
#asahi-dev · 2025-12-21 17:13
amarioguyCLUSTER_PRIO makes sense, that's easy enough to test, but i guess the symbol is what's unclear to me because mailing list seems to imply cpu groups can be prioritized, but the symbol implies it can only do a delay
#asahi-dev · 2025-12-21 17:11
amarioguysince the linux driver doesn't use it, trying to get any info i can before i have to resort to bit twiddling to find out specifics
#asahi-dev · 2025-12-21 17:11
amarioguybtw for AIC2, is AIC2_DELAY_GROUPS in the linux driver that "grouping" register mentioned in the mailing list discussion?
#asahi-dev · 2025-12-21 15:15
jannauI've tagged and pushed u-boot asahi-v2025.10-1
#asahi-dev · 2025-12-21 13:38
jannauI'll first look into u-boot and afterwards into the hdmi out
#asahi-dev · 2025-12-21 13:34
jannaunot yet tagged because the usb changes are expected to break usb in u-boot and the macbook pro HDMI output is very likely broken as well
#asahi-dev · 2025-12-21 13:32
jannauI've pushed a v6.18.2 based tree to asahi-wip (untagged). Most signifant changes: upstream(-ish) dwc3/atc USB support and asahi GPU driver updates in preparation for upstreaming
#asahi-dev · 2025-12-21 13:17
chadmed(enabling tearing in the surfaces seems to fix the laggy brightness changing and some other weird stuff btw)
#asahi-dev · 2025-12-21 13:16
jannaushould not make much of a difference in practice
#asahi-dev · 2025-12-21 13:16
chadmedwould the timeout always be exactly one frame in the future though even if we're disallowing tearing
#asahi-dev · 2025-12-21 13:15
jannauinstead of submit and present time I could imagine present time and timeout
#asahi-dev · 2025-12-21 13:13
jannauI suspect last_present_time might be render start time (i.e. just informative)
#asahi-dev · 2025-12-21 13:11
chadmedi dont really see how they could be anything else given the tight timing but sure
#asahi-dev · 2025-12-21 13:09
jannauoliver: I pulled the PR and modified it as suggested
#asahi-dev · 2025-12-21 13:08
jannauI think I want to have a better understanding what the timestamps mean before setting them for all displays
#asahi-dev · 2025-12-21 12:51
chadmedmacos doesnt like my vrr monitors though so i cant really test that with varying times between swaps for a given mode
#asahi-dev · 2025-12-21 12:50
chadmedts2 is the only one im not _too_ sure is real but it seems to line up
#asahi-dev · 2025-12-21 12:49
chadmedoliver, jannau: setting ts1 = now + (1 / refresh rate) * 1e9, ts2 = last time we got dcp_swapped and ts3 = now does not break anything on any of the hdmi displays ive tested
#asahi-dev · 2025-12-21 07:36
chadmedthe firmware prints a "tiling unsupported" error message to its rtk syslog
#asahi-dev · 2025-12-21 07:36
chadmedso dcp will happily scan out a DRM_FORMAT_MOD_APPLE_GPU_TILED{,_COMPRESSED} framebuffer but actually setting the tiled flag on the surface makes it very unhappy
#asahi-dev · 2025-12-20 17:37
svenmight just be a bug
#asahi-dev · 2025-12-20 17:36
svendon’t remember
#asahi-dev · 2025-12-20 17:36
nickchansven: any reason why cmd.cdw12 is 1 in the first place? the normal nvme spec does say it is 0-indexed and linux's behavior is also 0-index
#asahi-dev · 2025-12-20 17:34
nickchanand linux's behavior would be 0 there for a 4096-byte read there's no special 1-index treatment
#asahi-dev · 2025-12-20 17:34
nickchan4096 bytes of data gets read and dma'd
#asahi-dev · 2025-12-20 17:34
nickchanon t6000 with or without this line: <https://github.com/AsahiLinux/m1n1/blob/3ef4357c6b7ec727d06a57d698aa5c98258ef7e4/src/nvme.c#L547>
#asahi-dev · 2025-12-20 17:29
nickchanuh
#asahi-dev · 2025-12-20 16:50
nickchanin this case i need to check linux to see there's no overflow issues there
#asahi-dev · 2025-12-20 16:47
jannaumerged. I guess we don't really call proxy.free() that often
#asahi-dev · 2025-12-20 16:24
nickchanthis nvme is less quirky so it is 0 based as described in the spec
#asahi-dev · 2025-12-20 16:24
nickchanfor 4096 bytes i should set cdw12 to 0 instead of 1
#asahi-dev · 2025-12-20 16:24
nickchananyways i think i found the actual issue im experiencing with t8015 nvme
#asahi-dev · 2025-12-20 15:25
nickchanfix https://github.com/AsahiLinux/m1n1/pull/526
#asahi-dev · 2025-12-20 15:09
nickchangit blame says that it's like this since the beginning of time

plus ›