#
#asahi-dev · 2026-01-15 14:04
NickChan[m]first it's 0x100 bytes long then it gets changed to 0x270 bytes long and then later it finally got changed to 0x400 bytes long
#asahi-dev · 2026-01-15 14:03
NickChan[m]cmdline is in bootargs struct
#asahi-dev · 2026-01-15 14:03
Shize.g. if you add a really long kernel cmdline :D
#asahi-dev · 2026-01-15 14:02
Shizin practice it may be always smaller, but maybe not :P
#asahi-dev · 2026-01-15 14:02
jannauthe commit changed the ADT data which is unexpected
#asahi-dev · 2026-01-15 14:02
Shizbecause it allocates *the original adt size* to put the *rebuilt* adt in
#asahi-dev · 2026-01-15 14:02
Shizyea, I think some of that logic for guest booting needs fixing
#asahi-dev · 2026-01-15 14:01
jannauthe size differs because adt.build() can't replicate the exact number of trailing zeros
#asahi-dev · 2026-01-15 14:01
NickChan[m]adt related already don't work properly on my downstream so that went under the radar
#asahi-dev · 2026-01-15 14:01
NickChan[m]I really should properly fix all the downstream adt hacks I have
#asahi-dev · 2026-01-15 14:00
Shizmight be able to take a look at things tomorrow
#asahi-dev · 2026-01-15 14:00
ShizI came down with a headache yesterday & today so wasn't able to do proper testing after my initial suspicion yet, apologies
#asahi-dev · 2026-01-15 14:00
Shizwyep, that was what it caught
#asahi-dev · 2026-01-15 13:59
NickChan[m]and it hit an assert
#asahi-dev · 2026-01-15 13:59
NickChan[m]the adt size somehow changed after a round of parsing by m1n1.adt
#asahi-dev · 2026-01-15 13:59
sven🙃
#asahi-dev · 2026-01-15 13:57
Shiz(m1n1.adt did catch it indeed)
#asahi-dev · 2026-01-15 13:57
Shizyeah, scrolling up that was an issue we discovered
#asahi-dev · 2026-01-15 13:56
Shizyeah, and it was even related ot the pmgr stuff :D
#asahi-dev · 2026-01-15 13:56
sveniirc shiz suspected something with our adt handling was off
#asahi-dev · 2026-01-15 13:55
svennice, wonder if this also caused issues with m3
#asahi-dev · 2026-01-15 13:55
jannaumacos hotplugs fixed
#asahi-dev · 2026-01-15 13:45
jannauIASInstallPhaseList I suppose they are using the same thing on intel macs
#asahi-dev · 2026-01-15 13:45
NickChan[m]maybe it's a leftover
#asahi-dev · 2026-01-15 13:45
NickChan[m]efi firmware is shipped in bridgeOS so there's that
#asahi-dev · 2026-01-15 13:43
svenlol, what
#asahi-dev · 2026-01-15 13:40
jannauwhy is there a plist with "EFI Firmware Update" in the ADT?
#asahi-dev · 2026-01-15 13:40
jannaunot sure if fetching parts of the ipsw from apple's cdn is a good idea
#asahi-dev · 2026-01-15 13:38
NickChan[m]* from the remote zip during
#asahi-dev · 2026-01-15 13:33
NickChan[m]using something like ipsw
#asahi-dev · 2026-01-15 13:33
NickChan[m]But if it's IPSW I suppose can just rip it out from the zip during CI
#asahi-dev · 2026-01-15 13:33
NickChan[m]sven: was thinking more from copyright perspective
#asahi-dev · 2026-01-15 13:31
sventrue, even better!
#asahi-dev · 2026-01-15 13:31
jannaushould be fine to use a template ADT from the ipsw
#asahi-dev · 2026-01-15 13:31
svenor just use one from a machine that's exclusive for development anyway
#asahi-dev · 2026-01-15 13:30
svenshould be fine as long as we remove nvram and stuff like that
#asahi-dev · 2026-01-15 13:30
NickChan[m]s/an/adt(s)/, s/adt/to use in the test/
#asahi-dev · 2026-01-15 13:30
NickChan[m]but that has the issue of shipping an adt
#asahi-dev · 2026-01-15 13:27
NickChan[m]right I think that should be done
#asahi-dev · 2026-01-15 13:27
NickChan[m]that fixes a sanity check assertion for me
#asahi-dev · 2026-01-15 13:25
jannaumaybe time to add a -m m1n1.adt test to the CI
#asahi-dev · 2026-01-15 13:24
jannauhttps://github.com/AsahiLinux/m1n1/pull/532 I can test macos hotplug irqs later today as well
#asahi-dev · 2026-01-15 13:19
svenlater this afternoon
#asahi-dev · 2026-01-15 13:19
jannauthat fixes at least the m1n1.adt issue
#asahi-dev · 2026-01-15 13:18
jannaucan you quickly test https://paste.debian.net/hidden/94ccc61e
#asahi-dev · 2026-01-15 13:17
NickChan[m]how does underscrores even work in construct
#asahi-dev · 2026-01-15 13:17
sveneven better if you fix the issues it has ;)
#asahi-dev · 2026-01-15 13:17
jannaujust 3 missing underscores
#asahi-dev · 2026-01-15 13:16
jannauthat's an easy fix
#asahi-dev · 2026-01-15 13:14
svenlet's revert it for now then

plus ›