#
#asahi-dev · 2026-06-14 19:11
sveni'd just use the first device where it was noticed
#asahi-dev · 2026-06-14 19:04
chaos_princesswe briefly had something similar in admac
#asahi-dev · 2026-06-14 19:03
yukaI don't know for sure if some M4 / Pro / Max laptop doesn't have the same
#asahi-dev · 2026-06-14 19:03
yukaI have not seen this on any other device, so I would name it after t8140?
#asahi-dev · 2026-06-14 19:02
chaos_princessyes
#asahi-dev · 2026-06-14 19:02
yukabecause then the old driver which does not support the property yet will not attempt to operate on this device tree node?
#asahi-dev · 2026-06-14 19:01
chaos_princessnew compat
#asahi-dev · 2026-06-14 19:01
yukacrash
#asahi-dev · 2026-06-14 19:01
chaos_princesshow bad it is if you do read/write it?
#asahi-dev · 2026-06-14 19:01
yukaor is adding an optional property possible in the existing compatible?
#asahi-dev · 2026-06-14 19:00
yukaAnother question regarding upstream stuff (device tree bindings): I discovered some time ago that on A18 Pro we need to take into account the no-restore-gpio-pins adt property and tell the regmap to not read and write the regs of the gpios listed there. So essentially we would need a new apple,t????-pinctrl compatible to be able to express this, correct?
#asahi-dev · 2026-06-14 18:36
svenlooks good to me, will send r-b once it's on the list
#asahi-dev · 2026-06-14 18:22
chaos_princessReviewed-by: Sasha Finkelstein <k@chaosmail.tech>
#asahi-dev · 2026-06-14 18:22
chaos_princessah. if it is intentional, then ok
#asahi-dev · 2026-06-14 18:21
yukabelow the --
#asahi-dev · 2026-06-14 18:21
yukaI wanted at least the comment about the defines location to go into the comment field
#asahi-dev · 2026-06-14 18:20
chaos_princessfor single-commit series, do not use the cover letter, just leave it as "EDITME:" or whatever it generates by default, and instead write the whole thing in the patch description
#asahi-dev · 2026-06-14 18:19
yukaWell b4 and then send the eml files using git send-email because I already configured that
#asahi-dev · 2026-06-14 18:19
yukaYep
#asahi-dev · 2026-06-14 18:19
chaos_princessyuka: using b4 now?
#asahi-dev · 2026-06-14 17:57
jannaum4 has WFxT
#asahi-dev · 2026-06-14 17:57
yukaregardless of cpuidle
#asahi-dev · 2026-06-14 17:57
yukawfit is used in delay
#asahi-dev · 2026-06-14 17:56
nickchannohlt should work with m4 too shouldn't it
#asahi-dev · 2026-06-14 17:55
jannaustill needs the fixup but someone might argue that those cores should boot with nohlt
#asahi-dev · 2026-06-14 17:55
nickchani do know that but the workaround is still as valid as on m1,m2,m3
#asahi-dev · 2026-06-14 17:54
jannaunickchan: if the older CPU cores go through reset that's not not architecturally unsound as the wfi never completes
#asahi-dev · 2026-06-14 17:54
nickchanenable it for cpu implementer 0x61 specifically
#asahi-dev · 2026-06-14 17:51
nickchanyuka: just in case here are the midrs https://github.com/HoolockLinux/linux/commits/wfi-state-pre-m1/
#asahi-dev · 2026-06-14 17:51
nickchani think that can work
#asahi-dev · 2026-06-14 17:50
sventhat works I guess
#asahi-dev · 2026-06-14 17:46
yukaThen we could just enable it for apple midr unconditionally? As I understand, there's no plan to change/fix this behavior anyways, and if they do change it we can always add an upper bound later.
#asahi-dev · 2026-06-14 17:44
nickchanbut on m1 the cpu really only looses gpr and simd state
#asahi-dev · 2026-06-14 17:43
nickchanas in, lose all state and restart from rvbar and highest EL on older
#asahi-dev · 2026-06-14 17:43
nickchanthe only difference is on older socs the consequence of losing state is more severe
#asahi-dev · 2026-06-14 17:43
nickchani think everything with apple midr has the wfi lose state behavior
#asahi-dev · 2026-06-14 17:41
chaos_princessi think all of them? at least all arm64 ones
#asahi-dev · 2026-06-14 17:40
yukaI mean, how far back did they use the Apple MIDR, and when did they introduce the deep wfi...
#asahi-dev · 2026-06-14 17:39
yukaDo we know if there are _any_ devices with Apple MIDR which do _not_ have this behavior?
#asahi-dev · 2026-06-14 17:32
chaos_princesssomething something kernel is american congress where you need to stuff a year full of legislation^W patches into one bill :P
#asahi-dev · 2026-06-14 17:32
sveni still think that "the only way to get cpu midr into the kernel is to lump them together with M-series" conclusion is wrong at the very best. but i also don't see how adding them hurts *shrug*
#asahi-dev · 2026-06-14 17:31
nickchanyuka: i am preparing it
#asahi-dev · 2026-06-14 17:31
yukaAh, finally, my irc is also working again
#asahi-dev · 2026-06-14 17:30
yukanickchan: do you have a link to the patch adding the other MIDRs?
#asahi-dev · 2026-06-14 17:29
nickchanand by adding a workaround for all the apple silicon cpus which could all lose state on wfi, I can upstream that midr patch
#asahi-dev · 2026-06-14 17:28
nickchan(i am using those midrs to ban executing aarch32 on a10 but that's besides the point)
#asahi-dev · 2026-06-14 17:28
nickchani am looked at chance to upstream the patch that added all the pre-M1 midrs
#asahi-dev · 2026-06-14 17:27
nickchanit is not
#asahi-dev · 2026-06-14 17:26
sveni'm very confused how any of this is related to the wfi errata thing
#asahi-dev · 2026-06-14 17:26
nickchanwell, the server is accessible now

plus ›