#
✕ nick:yuka
#asahi-dev · 2026-09-25 10:55
yukafwiw this is not even dtbs_check, just normal make dtbs
#asahi-dev · 2026-09-25 10:55
yukaif I rename it to protected-pins, the warning disappears
#asahi-dev · 2026-09-25 10:55
yukaI think the reason is just that the property contains the string "gpio"
#asahi-dev · 2026-09-25 10:54
yukaYes
#asahi-dev · 2026-09-25 10:54
yuka"Warning (gpios_property): /soc/pinctrl@31a000000:apple,protected-gpios: cell 0 is not a phandle reference"
#asahi-dev · 2026-09-25 10:54
yuka"apple,protected-gpios = <134>;"
#asahi-dev · 2026-09-25 10:54
yukathough it gives me a warning when compiling the device tree
#asahi-dev · 2026-09-25 10:53
yukaI have the pinctrl protected-gpios thingy working
#asahi-dev · 2026-09-25 09:15
yuka(the progress)
#asahi-dev · 2026-09-25 09:15
yukanice!
#asahi-dev · 2026-09-25 08:21
yukayeah probably doesn't work at all, so device tree property it is
#asahi-dev · 2026-09-25 08:21
yukabut doesn't seem easy to do that
#asahi-dev · 2026-09-25 08:20
yukaOr I also considered if it would be possible to get a list of all gpios the which _are actually used_ and then ignoring all others
#asahi-dev · 2026-09-25 08:20
yukaI think device tree property is nicer
#asahi-dev · 2026-09-25 08:19
yukaso my solution for that is adding .readable_reg to the regmap_config, but the question is where to source the list of gpios not to read
#asahi-dev · 2026-09-25 08:19
yukaOn this device it seems to actually matter
#asahi-dev · 2026-09-25 08:18
yukabut we ignored it
#asahi-dev · 2026-09-25 08:18
yukayes
#asahi-dev · 2026-09-25 08:18
yukawhich happens to be listed in the adt under "no-restore-gpio-pins"
#asahi-dev · 2026-09-25 08:18
yuka* of a specific pinctrl_ap gpio
#asahi-dev · 2026-09-25 08:18
yuka(background: on the MacBook Neo you get SErrors trying to read the REG_GPIOx of a specific pinctrl_ap pin
#asahi-dev · 2026-09-25 08:17
yukatrying to determine if it really needs a new device tree property but I think yes
#asahi-dev · 2026-09-25 08:17
yukaon A18 Pro
#asahi-dev · 2026-09-25 08:16
yukaI'm looking into the pinctrl 'protected' pins
#asahi-dev · 2026-09-25 08:16
yukanice nice
#asahi-dev · 2026-09-25 08:16
yukasven: you mean A18 Pro?
#asahi-dev · 2026-09-25 08:11
yukaM5 Pro/Max/Ultra are probably all T6050 but it's a bit unclear at this point
#asahi-dev · 2026-09-25 08:10
yukaM5 base is T8142
#asahi-dev · 2026-09-24 19:35
yukayeah okay I aligned the model/compatible order to the old version in the patch series I sent out earlier
#asahi-dev · 2026-09-24 18:31
yukaI don't remember
#asahi-dev · 2026-09-24 18:31
yukabut possibly same chip id
#asahi-dev · 2026-09-24 18:31
yukaM5 Pro and M5 Max cores definitely have different MIDR part numbers
#asahi-dev · 2026-09-24 18:19
yukaHmm okay
#asahi-dev · 2026-09-24 18:16
yukaah but this was already the case for M3 Ultra for example
#asahi-dev · 2026-09-24 18:16
yuka> do I call the M5 Max SoC t6051? there is no single mention of t6051 in an M5 Max adt
#asahi-dev · 2026-09-24 18:00
yukaBut I think it did have a different chip id?
#asahi-dev · 2026-09-24 17:59
yukado I call the M5 Max SoC t6051? there is no single mention of t6051 in an M5 Max adt
#asahi-dev · 2026-09-24 17:58
yukaAhh
#asahi-dev · 2026-09-24 16:45
yukaLiterally the M4 Pro Mac mini (j773s) has compatible = [arm-io,t6041]
#asahi-dev · 2026-09-24 16:44
yukado we follow apple's odd naming of t6041 (not t6040) for t604x base compatibles?
#asahi-dev · 2026-09-24 16:15
yukalet's close the m1n1 PR as well then, since jannau and you are both slightly against it?
#asahi-dev · 2026-09-24 16:15
yukaack
#asahi-dev · 2026-09-24 16:14
yukaIt's the same thing as in m1n1, the code is almost the same except different offsets
#asahi-dev · 2026-09-24 16:14
yuka*would you prefer
#asahi-dev · 2026-09-24 16:14
yukasven: for SARTv4 support in Linux, would you a refactor or just copy, paste and adjust the sartv3 defines and functions?
#asahi-dev · 2026-09-24 14:23
yukabut might need to stop properly aligning the properties with line breaks in the next device trees since that's not really universally possible with tabs-only
#asahi-dev · 2026-09-24 14:21
yukaI dislike it
#asahi-dev · 2026-09-24 14:21
yukawhich is not even strict-only
#asahi-dev · 2026-09-24 14:21
yukaAlso, they newly added a mixed-indent-chars?
#asahi-dev · 2026-09-24 14:20
yukaso depending on which branch I'm working on, I get errors or not

plus ›