#asahi-dev · 2026-01-06 15:38
svenno, and you really want to either single step the early kernel code or add uart prints (or anything similar) to your kernel to figure out what's going on#asahi-dev · 2026-01-06 15:23
sveni also wonder who should review this, it's in soc/apple but i don't feel comfortable just picking it up without understanding if what that driver doing is correct#asahi-dev · 2026-01-06 15:21
svenit should#asahi-dev · 2026-01-06 15:15
sveni meant drivers/platform/chrome/cros_ec.c#asahi-dev · 2026-01-06 15:13
svener wait..#asahi-dev · 2026-01-06 15:13
svenwas about to mention that since i just found it as well :)#asahi-dev · 2026-01-06 15:09
svensounds good then#asahi-dev · 2026-01-06 15:07
svendidn't find that example when i was looking#asahi-dev · 2026-01-06 15:07
svenah, if there's precedence in cros-ec then it's probably fine#asahi-dev · 2026-01-06 14:42
sveni also wonder if it's correct that we just create platform child devices in dockchannel, if you look at other things like e.g. spi or i2c they create their own bus type or e.g. mfd at least creates its own device_type#asahi-dev · 2026-01-06 14:41
sventhere's a built-time dependency and then they can both just be taken through the hid tree in the end instead of waiting a cycle or creating immutable branches#asahi-dev · 2026-01-06 14:40
svenI think i'd actually send dockchannel and dockchannel-hid together now that i'm looking at it#asahi-dev · 2026-01-06 11:01
sventhese things are annoying to get right#asahi-dev · 2026-01-06 11:01
svenyeah, and really give it a day or two before submitting#asahi-dev · 2026-01-06 10:57
sven*give it#asahi-dev · 2026-01-06 10:57
sveni'd strongly recommend to post them here and give a day or two before submitting to lkml#asahi-dev · 2026-01-06 10:57
svenyeah, dt-bindings take a while to get used to. i'm sure you can do them but there's a lot of pitfalls to avoid#asahi-dev · 2026-01-06 10:56
sventhese are, uh, a steep learning curve#asahi-dev · 2026-01-06 10:55
svenintegralpilot: do you have dt-bindings for mtp?#asahi-dev · 2026-01-06 09:49
sveninterestingly, tbt seems very reliable even as coldplug :D#asahi-dev · 2026-01-06 09:46
svenSounds about right #asahi-dev · 2026-01-06 09:44
svenI can only sometimes reproduce it here #asahi-dev · 2026-01-06 09:44
svenNot yet#asahi-dev · 2026-01-06 08:27
svenyeah :)#asahi-dev · 2026-01-06 08:26
svenall the others have the logic in their driver like NVMe or SMC do#asahi-dev · 2026-01-06 08:25
svenjust mtp#asahi-dev · 2026-01-06 07:37
svenit’s just that cpu control register which really should be part of mtp itself like we do for all other coprocs #asahi-dev · 2026-01-06 07:37
svenit just calls into rtkit.c like NVMe as well #asahi-dev · 2026-01-06 07:37
svenrtkit-helper doesn’t even implement anything afaict #asahi-dev · 2026-01-06 07:34
svenwhat’s separate and should remain separate is the mailbox hw itself #asahi-dev · 2026-01-06 07:34
svenAnd it’s only used that way for mtp #asahi-dev · 2026-01-06 07:33
svenit feel like abstraction for the sake of building an abstraction #asahi-dev · 2026-01-06 07:33
svenI would merge the helper stuff so that you don’t have another node in the device tree #asahi-dev · 2026-01-05 19:48
svenwell, 4.5 years. but it's rather simple and shouldn't really break#asahi-dev · 2026-01-05 19:47
sven*:D#asahi-dev · 2026-01-05 19:47
svenlooks like i added support for that 5 years ago and probably last tested it around that time as well :d#asahi-dev · 2026-01-05 19:46
svenset a breakpoint on kernel init, then just use step() from the hv shell#asahi-dev · 2026-01-05 19:45
svenif single stepping is still working (unlike el1 calls *cough*) you can also single step through the kernel#asahi-dev · 2026-01-05 19:44
svenkernel, you're already past m1n1 at this point#asahi-dev · 2026-01-05 19:39
svenyou're very blind otherwise#asahi-dev · 2026-01-05 19:39
svenstrongly recommend to always keep it enabled#asahi-dev · 2026-01-05 19:37
svenalso, do you have earlycon enabled?#asahi-dev · 2026-01-05 15:27
svenhttps://github.com/AsahiLinux/linux/tree/bits/080-wifi Is the branch with the wifi patches #asahi-dev · 2026-01-05 15:21
svenvery nice!#asahi-dev · 2026-01-05 14:53
sveni like that "submit right now" part 😁#asahi-dev · 2026-01-05 14:40
sveninitializing clusters is still inside m1n1, isn't it?#asahi-dev · 2026-01-05 13:41
svenit's going to be great!#asahi-dev · 2026-01-05 13:41
svenyup, and if I enable that power rail before the PHY is brought up the SoC just resets immediately#asahi-dev · 2026-01-05 13:39
sventhanks, will take a look#asahi-dev · 2026-01-05 13:39
sventhe weird special case here is that any access to the iommu MMIO before the NHI is powered on (which can only be done after the PHY is switched to tbt) results in an SError