#
✕ nick:sven
#asahi-dev · 2026-01-25 11:01
sveni'll bet at fosdem next weekend, so earliest probably the weekend after that
#asahi-dev · 2026-01-25 11:01
svenwill have to find a keyboard and mouse to get it back to m1n1
#asahi-dev · 2026-01-25 11:01
svennot sure, when i tried to speak to debugusb yesterday i somehow got my mac mini into recovery mode :D
#asahi-dev · 2026-01-25 10:58
sveni'll see if i can figure out how to talk to debugusb so that we see the other side of that serial
#asahi-dev · 2026-01-25 10:58
svenif we're using different callbacks apple,dockchannel = ... might be better
#asahi-dev · 2026-01-25 10:55
sven*custom
#asahi-dev · 2026-01-25 10:55
svenwe just re-use the original mbox device tree bindings
#asahi-dev · 2026-01-25 10:55
svenour mailbox is in drivers/soc/apple with a customer interface now fwiw
#asahi-dev · 2026-01-25 10:51
svenwe might also need more specialized callbacks and then maybe apple,dockchannel = <&dockchannel 0> is better, dunno
#asahi-dev · 2026-01-25 10:50
svenjust have to make sure we don't run into this if we put into the mailbox system <jannau> it wasn't just the atomic context. mailbox was overall a bad fit for asc: https://lore.kernel.org/asahi/20230328-soc-mailbox-v1-0-3953814532fd@marcan.st/
#asahi-dev · 2026-01-25 10:50
svenit's just that the correct parent/subnode thing and then calling dockchannel_init which requests irqs from the irq controller defined in the same file looks very weird to me
#asahi-dev · 2026-01-25 10:49
svenonly if you think it's reasonable, i'm not really sure about any of this :D
#asahi-dev · 2026-01-25 10:49
svenat least right now i think dockchannel should really be a mailbox-like thing, possibly inside the mbox system if it doesn't run into the same problems asc mailboxes did
#asahi-dev · 2026-01-25 10:48
svenmaybe i should continue figuring out that debug usb thing so that we can actually test that dockchannel uart
#asahi-dev · 2026-01-25 10:47
svenhttps://github.com/apple-oss-distributions/xnu/blob/d8b80295118ef25ac3a784134bcf95cd8e88109f/pexpert/arm/pe_serial.c#L406
#asahi-dev · 2026-01-25 10:46
svenjannau: oss xnu contains code to drive that dockchannel-uart fwiw
#asahi-dev · 2026-01-25 10:46
sven+use
#asahi-dev · 2026-01-25 10:45
svensure, but the serial driver would just dockchannel_await or whatever
#asahi-dev · 2026-01-25 10:42
svenlike for thunderbolt :D
#asahi-dev · 2026-01-25 10:41
svenyou don't want the PD_FLAG_NO_DEV_LINK flag though, i have that there because thunderbolt is special
#asahi-dev · 2026-01-25 10:40
svenhttps://github.com/AsahiLinux/linux/blob/5265e38457df79188be2e13870192a1d488831ac/drivers/thunderbolt/apple.c#L733
#asahi-dev · 2026-01-25 10:38
sventhere's code in nvme that does it, but there's a common helper function now
#asahi-dev · 2026-01-25 10:38
svenlooking for it right now :D
#asahi-dev · 2026-01-25 10:38
svenif it has more than a single domain you need to do some manual work
#asahi-dev · 2026-01-25 10:37
svennoopwafel: if your device has a single domain defined in the dts it'll just work
#asahi-dev · 2026-01-25 10:37
svenmight only be a bit strange to have a serial without a reg but oh well
#asahi-dev · 2026-01-25 10:36
svenit is.
#asahi-dev · 2026-01-25 10:36
svenit's not unusual that you don't replies for hours at times
#asahi-dev · 2026-01-25 10:36
svenirc is slow
#asahi-dev · 2026-01-25 10:36
svenno worries :)
#asahi-dev · 2026-01-25 10:36
svensure, anything that makes you think what i just made up isn't?
#asahi-dev · 2026-01-25 10:34
sven(maybe outside the mbox system if there's a mismatch like for asc)
#asahi-dev · 2026-01-25 10:34
svenall mtp and hid stuff happens in the apple,t8112-mtp-hid node, dockchannel is just a dumb mailbox
#asahi-dev · 2026-01-25 10:33
sveni wonder if something like this describes the hardware better: https://f.svpe.de/a96619430acabb2d85a9a5d54b8c1acbebc8cb3548fb7d7ffb3f94e32d0e02a7_mtp.txt
#asahi-dev · 2026-01-25 10:33
svenpretty sure that's what happens
#asahi-dev · 2026-01-25 10:30
svenand doesn't need to be an irq controller
#asahi-dev · 2026-01-25 10:30
sventhe more i look at it the more dockchannel looks like a weird mbox that just needs some callbacks
#asahi-dev · 2026-01-25 10:26
svendockchannel itself requests the interrupts
#asahi-dev · 2026-01-25 10:26
svenokay, that's weird
#asahi-dev · 2026-01-25 10:25
svenoh wait, lol
#asahi-dev · 2026-01-25 10:24
svenmaybe i'm blind but i just see the interrupts in the dts for apple,t8112-dockchannel-hid but don't see that code that uses them
#asahi-dev · 2026-01-25 10:23
svenintegralpilot: sure, is that used for e.g. hid though somehow?
#asahi-dev · 2026-01-25 10:19
svenstill not sure about the interrupt-controller part of dockchannel, will have to understand what it actually does and how it's used
#asahi-dev · 2026-01-25 10:19
svengood point
#asahi-dev · 2026-01-25 10:17
svenwe'll also have to take care of downstream u-boot/openbsd if we change the dts representation but we might just be able to keep both variants in our downstream releases
#asahi-dev · 2026-01-25 10:17
svendunno though
#asahi-dev · 2026-01-25 10:17
svenyeah, i wonder if a single "mtp coprocessor" that uses both the asc mailbox and the dockchannel mailbox and also does all the HID stuff is the way to go
#asahi-dev · 2026-01-25 10:15
svennow i'm not sure we want to use mailbox subsystem again, but i think the issues with the asc mailbox was mostly around atomic context handling iirc
#asahi-dev · 2026-01-25 10:13
svenand we don't do the parent/child node thing for mailboxes either
#asahi-dev · 2026-01-25 10:13
svenhttps://github.com/apple-oss-distributions/xnu/blob/main/pexpert/pexpert/arm/dockchannel.h dockchannel itself seems to be really like some mailbox with multiple channels

plus ›