#asahi-dev · 2022-02-12 21:31
sventhe public data sheet claims the irq will only trigger when event is not zero#asahi-dev · 2022-02-12 21:30
svenand it doesn’t trigger the spurious irq detection because i2c is just too slow #asahi-dev · 2022-02-12 21:29
svenI think so#asahi-dev · 2022-02-12 21:27
svenI was looking for the cd321x_irq #asahi-dev · 2022-02-12 21:26
svenalright. unhandled interrupt then#asahi-dev · 2022-02-12 21:03
svensomething like tp_printk trace_event=tps6598:* in the bootargs should work#asahi-dev · 2022-02-12 21:03
svencan anyone of you boot with tps6598 trace events enabled?#asahi-dev · 2022-02-12 21:02
svenand just plugging in a normal cable doesn't seem to trigger that here#asahi-dev · 2022-02-12 21:01
svenlooks like i can't easily convinced my mac mini to "charge" from a usb-c port :D#asahi-dev · 2022-02-12 20:58
sveni think only when running something in the hypervisor#asahi-dev · 2022-02-12 20:57
svenhrm, but that shouldn't matter since we hand over to linux with all irqs in that chip disabled#asahi-dev · 2022-02-12 20:56
svenhuh, m1n1 has #define CD3218B12_IRQ_WIDTH 9 but the kernel driver effectively only considers 8 bytes#asahi-dev · 2022-02-12 20:55
sveni don't think the i2c transaction it the problem. it should timeout and complain if it was#asahi-dev · 2022-02-12 20:50
svenbut we handle that one correctly#asahi-dev · 2022-02-12 20:50
svencd321x is that usb pd chip and there should be a "plug event" firing#asahi-dev · 2022-02-12 20:49
svenmy first guess was that we don't ack the interrupt in cd321x_interrupt correctly but I don't see how yet#asahi-dev · 2022-02-12 20:45
svenor does the interrupt just keep firing?#asahi-dev · 2022-02-12 20:45
svendoes it get stuck in that D state? it's waiting for an i2c transaction to finish there#asahi-dev · 2022-02-12 19:58
sventhat interrupt comes from the usb pd controller #asahi-dev · 2022-02-12 13:26
sveni'm just waiting for marcan to confirm that the rtkit library is in a good shape and for axboe (he's one of the nvme maintainers) to look into sharing tags across both queues to submit it#asahi-dev · 2022-02-12 13:23
svenin other news, the regs inside the phy-atc nodes in the ADT are a big mess. they have some entries that are e.g. 0xa4 byes long :/#asahi-dev · 2022-02-12 13:14
svenyeah, or that :D#asahi-dev · 2022-02-12 13:14
sventhey work fine but need some work to be accepted upstream and i've kinda abandoned them because nvme was more interesting#asahi-dev · 2022-02-11 16:02
svenhm.. AppleTypeCPhy. so maybe that? dunno#asahi-dev · 2022-02-11 16:01
svenyeah, could be either. i don't think i've seen any strings yet#asahi-dev · 2022-02-11 15:59
svenwe don't really know what ATC is, but I assumed Apple Thunderbolt Controller #asahi-dev · 2022-02-11 15:58
svenbut ATC requires different tunables for e.g. USB3 vs. thunderbolt#asahi-dev · 2022-02-11 15:57
svennot tunables. we just apply them in m1n1#asahi-dev · 2022-02-11 15:57
svenit's not hard, it's just gonna be ugly#asahi-dev · 2022-02-11 15:57
svenu-boot is already too late, this has to be done in m1n1#asahi-dev · 2022-02-11 15:50
sveneven worse: we'll have to somehow propagate these to the FDT because we can't just get away with applying them from m1n1 afaict#asahi-dev · 2022-02-11 15:49
svenI started looking into ATC in more detail and ofc they have yet another format for their ADT tunables :/#asahi-dev · 2022-02-07 21:09
svenalyssa: thanks for making my case! :D#asahi-dev · 2022-02-07 21:06
svenimho hacks like that are perfectly fine in proxyclient/#asahi-dev · 2022-02-07 21:05
svenLol :D#asahi-dev · 2022-02-07 21:00
svensounds like a good goal for everything we do here :p#asahi-dev · 2022-02-07 19:29
svenAh, that’s useful! Thanks!#asahi-dev · 2022-02-07 19:25
svenlet’s see if I can find my nvme WIP branch again. I vaguely remember fixing something else as well#asahi-dev · 2022-02-07 19:23
svenmarcan: ^— feel free to pull that into nvme once you rebase asahi, those changes look good to me#asahi-dev · 2022-02-07 19:21
svensounds good :)#asahi-dev · 2022-02-07 19:20
sventhanks!#asahi-dev · 2022-02-07 19:19
svenjannau: where were those rtkit/nvme changes you did again?#asahi-dev · 2022-02-06 17:02
svenI feel like half the ADT is just hacks to get something working :(#asahi-dev · 2022-02-06 13:39
svennvme probably. jannau did some changes to rtkit for DCP iirc, but once SMC also works with that setup we can figure out how to submit NVMe and SMC#asahi-dev · 2022-02-06 12:31
svenand I also need to re-send the usb stuff#asahi-dev · 2022-02-06 12:31
svenright#asahi-dev · 2022-02-06 11:52
svenjannau: sure, but in the setup translation function there’s also a brief race right now (see my GitHub comment)#asahi-dev · 2022-02-06 11:50
svenyou also have another race for non locked darts where you first update the TTBR and only then map everything