#
✕ nick:sven
#asahi-dev · 2022-09-30 16:16
svenessentially I hope that I can make dcp think that two separate displays connected to atcphy0 and atcphy1 are a single tiled display
#asahi-dev · 2022-09-30 16:15
svennice! i'll prepare something tomorrow or so
#asahi-dev · 2022-09-30 16:15
svendottedmag: you had that tiled thunderbolt display that worked on m1, didn't you? do you have time to generate another trace for me sometime?
#asahi-dev · 2022-09-30 16:08
svenoh, yeah, for now it'll only be atcphy1/dispext0
#asahi-dev · 2022-09-30 16:05
svenwhenever there's a new electrical hotplug just steal a dcpext or complain if none are available ;)
#asahi-dev · 2022-09-30 16:05
svensomething greedy should work at first though :D
#asahi-dev · 2022-09-30 16:04
sventrue
#asahi-dev · 2022-09-30 16:02
svenI also don't think we can hardcode the dcpext<->atcphy relationship because there are situations where a single atcphy wants streams from two separate dcpexts for usb4 tunneling
#asahi-dev · 2022-09-30 16:02
svenI think I confused myself somewhere along the way and switched the meaning of hotplug :)
#asahi-dev · 2022-09-30 16:00
svenbut it definitely only comes after atcphy is configured and the required methods on that dcpdptx-port-epic are called
#asahi-dev · 2022-09-30 16:00
svennot sure though
#asahi-dev · 2022-09-30 16:00
svenit maybe comes at the start of link training
#asahi-dev · 2022-09-30 15:59
sventrue
#asahi-dev · 2022-09-30 15:57
svenand then i think there's the drm hotplug which we only fire after the crossbar is configured and dcpext has done its link training
#asahi-dev · 2022-09-30 15:57
sventhere's the electrical hotplug that comes from tps6598x/thunderbolt-nhi. once we get that we know that there's something that wants a DP stream and we need to select a dcpext and configure the crossbar
#asahi-dev · 2022-09-30 15:56
svennow i'm confused :D
#asahi-dev · 2022-09-30 15:53
svenand I think I saw some patch series that introduced a OOB notification specifically for drm
#asahi-dev · 2022-09-30 15:53
sventhe typec subsystem will needs some adjustments to forward the required stuff to atcphy anyway
#asahi-dev · 2022-09-30 15:52
svenbut essentially we need to find a free dcpext and match that one to the atcphy input
#asahi-dev · 2022-09-30 15:52
svenespecially if I can actually hack dual external screens for the M1
#asahi-dev · 2022-09-30 15:51
sventhe how is going to be annoying
#asahi-dev · 2022-09-30 15:51
sventhen when is the easy part: when tps6598x or thunderbolt-nhi wants a stream
#asahi-dev · 2022-09-30 15:47
svenhrm, I guess we actually only fire that hotplug event after we've already configured the crossbar and everything I think
#asahi-dev · 2022-09-30 15:46
svenand I guess each of those can fire a hotplug event which we get from tps6598x for dp-altmode and thunderbolt-nhi for the others
#asahi-dev · 2022-09-30 15:39
svenoh, and that special HDMI port on uhhh.. the macbook pro
#asahi-dev · 2022-09-30 15:38
svenokay, so essentially we'll have one "internal screen" (macbooks) or "HDMI" (mac mini) connector and then "USB-C #n DP altmode", "USB-C #n USB4 Tunnel #0" and "USB-C #n USB4 Tunnel #1" for each atcphy
#asahi-dev · 2022-09-30 15:31
svenlikes drm already
#asahi-dev · 2022-09-30 15:31
svenwow, documentation with nice pictures :D
#asahi-dev · 2022-09-30 15:29
sven*atcphy1 actually
#asahi-dev · 2022-09-30 15:29
svenbut anyway, just the thoughts I had in the last days. there's still plenty of time to change it. as i said, i'll first hardcode everything for dcpext0->atcphy0-dpphy
#asahi-dev · 2022-09-30 15:27
svenhas no clue about drm so far
#asahi-dev · 2022-09-30 15:27
svenwhat is a drm level connector?
#asahi-dev · 2022-09-30 15:25
svenbecause we can mux any dispext to any atcphy afaict
#asahi-dev · 2022-09-30 15:25
svenyeah, i think so
#asahi-dev · 2022-09-30 15:25
svenand you can have multiple connections per port
#asahi-dev · 2022-09-30 15:24
sveniirc the bindings for that already exist. port@0 is usb2, port@1 is usb3/SS lanes with their default use and port@2 is "anything else"
#asahi-dev · 2022-09-30 15:23
svensimilar to how they're connected to e.g. dwc3 or atcphy right now
#asahi-dev · 2022-09-30 15:23
svenyes
#asahi-dev · 2022-09-30 15:22
svenwhat do you mean with connectors?
#asahi-dev · 2022-09-30 15:20
sventhe thing that also has apple,coprocessors or however it's called with the list of DCPs
#asahi-dev · 2022-09-30 15:20
svenso when I said "top level display subsytem node" above I meant that one
#asahi-dev · 2022-09-30 15:18
svenhuh, does that node already exists?
#asahi-dev · 2022-09-30 15:16
sven*i'll just hardcode
#asahi-dev · 2022-09-30 15:16
svenfor now i'll just a constant connection to atcphy1/dpphy anyway and just configure atcphy from python before I start linux ;)
#asahi-dev · 2022-09-30 15:16
sventhat's the top-level node, isn't it?
#asahi-dev · 2022-09-30 15:15
sventhen we'll probably need a connection from the thunderbolt NHI to the display-subsystem as well to trigger dcpext<->dpin0/1 connections
#asahi-dev · 2022-09-30 15:15
sventhe atcphy connection to configure the electrical side, the display-subsytem one to trigger the dcpext<->atcphy connection
#asahi-dev · 2022-09-30 15:14
sventhen tps6598x will be connected via those graph bindings to at least atcphy and the top-level dispay-subsystem node
#asahi-dev · 2022-09-30 15:14
sventhe atc-crossbar will probably be a separate node in the FDT. either we just stuff the driver into drm/apple as well or maybe it actually fits into drivers/mux (or possibly even somewhere else)
#asahi-dev · 2022-09-30 15:13
sveni've also thought a bit about how to hook this all up

plus ›