#
✕ nick:rmk
#asahi-dev · 2022-10-27 22:08
rmkkevans91: are you getting an exception (which exception?) while restoring the vfp state ?
#asahi-dev · 2022-10-27 15:08
rmkmarcan: I was stabbed with pfizer on tuesday... wednesday was utter crap so I had an early night.
#asahi-dev · 2022-10-27 15:07
rmkok, thanks, got all those updates in place now.
#asahi-dev · 2022-10-27 15:05
rmkalso, there's the usual linux/ includes before asm/ includes :)
#asahi-dev · 2022-10-27 15:05
rmkthanks.
#asahi-dev · 2022-10-27 15:04
rmkthe && 64BIT thing should be on the APPLE_PLATFORMS menuconfig?
#asahi-dev · 2022-10-27 15:01
rmkgo ahead
#asahi-dev · 2022-10-27 15:00
rmkOk, I'll try to do what I think makes sense and post a new patch series - if stuff has been missed then IMHO that's the fault of people making such a long thread about it and not summarising it towards the end.
#asahi-dev · 2022-10-27 14:58
rmkmarcan: that makes two of us then :)
#asahi-dev · 2022-10-27 14:58
rmkI think we need to move it from drivers/platform to drivers/mfd
#asahi-dev · 2022-10-27 14:58
rmkmarcan: what is your understanding of the changes needed to get the macsmc stuff into mainline? I got lost in that massive discussion about what the actual points that needed addressing were.
#asahi-dev · 2022-10-20 14:02
rmkmarcan: do you have any comments on Petr's review of the vsprintf patch, or shall I just make those changes?
#asahi-dev · 2022-10-12 17:08
rmksven: ok, I'll take a look, thanks.
#asahi-dev · 2022-10-12 16:35
rmkis it worth creating a library that could be used by both drivers? :D
#asahi-dev · 2022-10-12 16:35
rmkok, let me put it another way then :)
#asahi-dev · 2022-10-12 16:34
rmkis there any way we could share code between the two to reduce the probability of divergence?
#asahi-dev · 2022-10-12 16:31
rmkcan't really diff the two drivers, because diff can't cope with the changes
#asahi-dev · 2022-10-12 16:26
rmksven: I'll update the patch in a few days.
#asahi-dev · 2022-10-12 11:46
rmkpatch sent.
#asahi-dev · 2022-10-12 11:43
rmksven: can I add a suggested-by for you for that?
#asahi-dev · 2022-10-12 11:38
rmkyep, quite possibly
#asahi-dev · 2022-10-12 11:35
rmksven: http://www.home.armlinux.org.uk/~rmk/misc/nvme-apple.diff
#asahi-dev · 2022-10-12 11:33
rmksven: seems to be happy
#asahi-dev · 2022-10-12 11:28
rmkok, building...
#asahi-dev · 2022-10-12 11:26
rmkah, it uses its own
#asahi-dev · 2022-10-12 11:25
rmkthat's the theory...
#asahi-dev · 2022-10-12 11:24
rmkcould it be that we're accessing the nvme before nvme_reset_work() gets run?
#asahi-dev · 2022-10-12 11:23
rmkok
#asahi-dev · 2022-10-12 11:22
rmksupplier:platform:27bc50000.iommu/
#asahi-dev · 2022-10-12 11:22
rmkin /sys/bus/platform/drivers/nvme-apple/27bcc0000.nvme/:
#asahi-dev · 2022-10-12 11:22
rmkhmm.
#asahi-dev · 2022-10-12 11:20
rmkso I wonder why this warning is triggering
#asahi-dev · 2022-10-12 11:19
rmk dma_set_min_align_mask(dev->dev, NVME_CTRL_PAGE_SIZE - 1);
#asahi-dev · 2022-10-12 11:19
rmk dma_set_max_seg_size(dev->dev, 0xffffffff);
#asahi-dev · 2022-10-12 11:19
rmkI have:
#asahi-dev · 2022-10-12 11:17
rmkah
#asahi-dev · 2022-10-12 11:17
rmksven: it does use the DMA API
#asahi-dev · 2022-10-12 11:14
rmkor maybe its to do with the 4k iommu patch
#asahi-dev · 2022-10-12 11:13
rmksven: possibly but I think I've seen it occasionally with 5.19 as well
#asahi-dev · 2022-10-12 11:12
rmkhttp://www.home.armlinux.org.uk/~rmk/misc/0001-Support-IOMMU-page-sizes-larger-than-the-CPU-page-si.patch
#asahi-dev · 2022-10-12 11:11
rmkmps: one moment...
#asahi-dev · 2022-10-12 11:09
rmkdma_map_sg() called from apple_nvme_queue_rq()
#asahi-dev · 2022-10-12 11:08
rmkDMA-API: nvme-apple 27bcc0000.nvme: mapping sg segment longer than device claims to support [len=69632] [max=65536]
#asahi-dev · 2022-10-12 11:08
rmkhowever, I get this warning at boot:
#asahi-dev · 2022-10-12 11:08
rmkwell, 6.0.0+ booted with 4k page sizes...
#asahi-dev · 2022-10-11 16:28
rmk_jannau_: I worked out a resolution and it builds, so I'm going to be testing it, probably tomorrow now.
#asahi-dev · 2022-10-11 11:38
rmkHi, is there a replacement for "Support IOMMU page sizes larger than the CPU page size" for v6.0 ?
#asahi-dev · 2022-09-21 15:48
rmksorry for the distraction :p
#asahi-dev · 2022-09-21 15:48
rmkyep that was the issue
#asahi-dev · 2022-09-21 15:44
rmkkconfig issue I think :/

plus ›