#
✕ nick:rmk
#asahi-dev · 2022-09-05 16:58
rmkyea, and I should make my supper!
#asahi-dev · 2022-09-05 16:58
rmkthe only issue that was brought up with changing the way that stuff works is that it's also being used in openbsd
#asahi-dev · 2022-09-05 16:51
rmkI guess we'll see Andy pop up for those mailbox patches
#asahi-dev · 2022-09-05 16:50
rmkmarcan: yes, some companies do have a policy of tracking their involvement in the mainline kernel by monitoring mailing lists and counting messages.
#asahi-dev · 2022-09-05 16:44
rmkprobably best to send the first two only at the moment though.
#asahi-dev · 2022-09-05 16:40
rmkmarcan: I think the first three mailbox patches are reasonable
#asahi-dev · 2022-09-05 16:24
rmkah, so that's why shutdown doesn't work very well :D
#asahi-dev · 2022-09-05 16:18
rmkoh, let me dig that out.
#asahi-dev · 2022-09-05 16:18
rmkthose six.
#asahi-dev · 2022-09-05 16:18
rmkarm64: dts: apple: Add SMC node to t8103/t6001 devicetrees
#asahi-dev · 2022-09-05 16:17
rmkgpio: Add new gpio-macsmc driver for Apple Macs
#asahi-dev · 2022-09-05 16:17
rmkplatform/apple: Add new Apple Mac SMC driver
#asahi-dev · 2022-09-05 16:17
rmklib/vsprintf: Add support for generic FOURCCs by extending %p4cc
#asahi-dev · 2022-09-05 16:17
rmksoc: apple: rtkit: Add apple_rtkit_poll
#asahi-dev · 2022-09-05 16:17
rmkdt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC
#asahi-dev · 2022-09-05 16:17
rmkdt-bindings: mfd: add binding for Apple Mac System Management Controller
#asahi-dev · 2022-09-05 16:17
rmkokay, my v2 series will be:
#asahi-dev · 2022-09-05 15:49
rmkok, booted a kernel without, wifi still works so I'll drop that patch for now as it doesn't seem to be needed yet.
#asahi-dev · 2022-09-05 15:40
rmkdoes that mean that the patch adding IRQ support to macsmc-gpio hasn't been tested?
#asahi-dev · 2022-09-05 15:25
rmkwell, looking at the macsmc-gpio list on my mainline kernel, the only thing I have using it is the PWREN gpio, so no interrupts...
#asahi-dev · 2022-09-05 14:35
rmkHe could have looked up the definition himself which would've answered his question.
#asahi-dev · 2022-09-05 14:32
rmkmarcan: seems you're right - I just read another response of his on a different thread about someone using PTR_ERR_OR_ZERO(). His comment is utter trash, designed to waste the time of the patch submitter.
#asahi-dev · 2022-09-05 14:25
rmkI've made quite a few changes to the gpio driver... I'm going to boot test them soon.
#asahi-dev · 2022-09-05 14:23
rmkthanks.
#asahi-dev · 2022-09-05 14:23
rmkrushes to either end of the boat to close the cratch cover and the stern hatch... it's raining! :D
#asahi-dev · 2022-09-05 14:20
rmkmarcan: I agree, that thing about "%.4s" &cpu_to_be32(foo) was utterly idiotic
#asahi-dev · 2022-09-05 14:19
rmkj`ey: no, it's all on the mailing lists
#asahi-dev · 2022-09-05 13:44
rmkI'm getting pissed off with saying "that's for the Asahi people to decide" and similar
#asahi-dev · 2022-09-05 13:44
rmkUnless you speak up, I'm going to give up with trying to upstream this gpio driver
#asahi-dev · 2022-09-05 13:43
rmkthey do not care, why should we (as a community of upstream)?
#asahi-dev · 2022-09-05 13:43
rmkfrustrating me. They haven't participated in this discussion (yet?) so
#asahi-dev · 2022-09-05 13:43
rmkWhile I agree on technical aspects, this mythical "they" is
#asahi-dev · 2022-09-05 13:43
rmkwell, Andy Shevchenko is doubting that any of you exist...
#asahi-dev · 2022-09-05 09:58
rmkdo we have any documentation on the SMC keys? Andy was suggesting that we should be using the endian conversion macros with the keys - does that sound correct?
#asahi-dev · 2022-09-03 20:48
rmkmarcan: I'll keep an eye out for your responses... I'm busy this weekend rewriting the boat's domestic 12V batteries, which means I'm having to turn off my 'net router while modifying the battery wiring.
#asahi-dev · 2022-09-02 16:37
rmkI'll continue looking at it next week while I'm on the boat (still need to pack the m1 mini)
#asahi-dev · 2022-09-02 15:09
rmkkettenis: I think you're about to get a "DT describes the hardware" response :(
#asahi-dev · 2022-09-02 11:41
rmkthat's legal, because the precision is specified to limit the number of characters written, and it's permitted for the null byte to be absent
#asahi-dev · 2022-09-02 11:39
rmkmaybe rather than typedefing a u32 as smc_key, what about struct { char key[4]; } ? That can then be printed using "%.4s".
#asahi-dev · 2022-09-02 11:38
rmkI think a decision also needs to be reached about the %p4ch printf specifier and the smc_key thing (both points brought up by Andy)
#asahi-dev · 2022-09-02 09:40
rmkis there a reason that the child nodes of the smc device don't have compatibles? from what I can see, having compatibles would make the code easier and avoid stuff such as: pdev->dev.of_node = of_get_child_by_name(pdev->dev.parent->of_node, "gpio"); in the child drivers.
#asahi-dev · 2022-09-02 09:15
rmkah, helps to read the code comments... I wonder why Andy didn't
#asahi-dev · 2022-09-02 09:13
rmkit looks to me like a bug.
#asahi-dev · 2022-09-02 09:13
rmk> What is the meaning of val in this case?
#asahi-dev · 2022-09-02 09:13
rmk> > + return (!ret) ? GPIO_LINE_DIRECTION_IN : GPIO_LINE_DIRECTION_OUT;
#asahi-dev · 2022-09-02 09:13
rmk> > + ret = apple_smc_rw_u32(smcgp->smc, key, CMD_IRQ_MODE, &val);
#asahi-dev · 2022-09-02 09:13
rmksomeone needs to explain this:
#asahi-dev · 2022-09-01 22:51
rmkmarcan: any chance you could reply to Rob on my dt binding doc? He asks "How confident are the asahi folks that this is a complete binding?"
#asahi-dev · 2022-09-01 21:22
rmkloads of comments from Andy Shevchenko on the gpio driver...
#asahi-dev · 2022-08-31 20:44
rmk(and thanks for reminding me about that)

plus ›