#
✕ nick:povik
#asahi-dev · 2022-08-20 10:50
povikhaven't tested that extensively
#asahi-dev · 2022-08-20 10:50
povikthat the modules do not fully clean after themselves wouldn't surprise me
#asahi-dev · 2022-08-20 10:50
povikuserspace segfault?
#asahi-dev · 2022-08-20 10:44
povikreading https://docs.kernel.org/core-api/memory-allocation.html
#asahi-dev · 2022-08-20 10:39
poviknot sure that can happen. by that point we have requested admac channels so i would assume it's been fully probed
#asahi-dev · 2022-08-20 10:39
povik12:38 < chadmed> i assume its trying to allocate that buffer before admac is fully alive
#asahi-dev · 2022-08-20 10:39
povikah
#asahi-dev · 2022-08-20 10:37
povikchadmed: you know more why it fails?
#asahi-dev · 2022-08-20 10:37
povikthis boils down to allocating admac-usable buffer
#asahi-dev · 2022-08-20 10:37
povikhttps://github.com/AsahiLinux/linux/blob/asahi/sound/soc/apple/mca.c#L981
#asahi-dev · 2022-08-20 10:36
poviki would reckon
#asahi-dev · 2022-08-20 09:32
povikchadmed: scratching my head at the prealloc thing now
#asahi-dev · 2022-08-20 09:32
povikof course we don't want to disable it (2 hz appears default and was set already)
#asahi-dev · 2022-08-20 09:29
poviki agree, but i want to give chadmed a chance to play with the filter :p
#asahi-dev · 2022-08-20 09:28
povikyou mean that it would be good to assure the filter's not disabled on the woofers?
#asahi-dev · 2022-08-20 09:27
poviki don't know yet, got stopped by some other work on the drivers
#asahi-dev · 2022-08-20 09:26
povikat least initially
#asahi-dev · 2022-08-20 09:26
povikthe HFP i will lock on the highest setting for the tweeters, on the woofers i will let them be set from userspace
#asahi-dev · 2022-08-20 09:26
povikcommon volume cap
#asahi-dev · 2022-08-20 09:25
povikor rather set it from the j314/j316 specific files
#asahi-dev · 2022-08-20 09:25
povik^ here, we just change that
#asahi-dev · 2022-08-20 09:25
povikhttps://github.com/AsahiLinux/linux/blob/asahi/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi#L332
#asahi-dev · 2022-08-20 09:24
povikif you mean the j314/316 distinction, which is currently lost, that is just matter of modifying the model= property
#asahi-dev · 2022-08-20 09:24
povikwhat do you mean DT prop on audio node?
#asahi-dev · 2022-08-20 09:24
povikso far i have written in -3 dB cap below macOS values, still very loud, but that was mostly arbitrary while i am focusing on other issues
#asahi-dev · 2022-08-20 09:17
povikit's a frequency at which it has -3 dB attenuation
#asahi-dev · 2022-08-20 09:17
povikdon't forget that the codec doesn't filter all below the frequency we set
#asahi-dev · 2022-08-20 01:14
povikwell you needed the other changes still
#asahi-dev · 2022-08-20 01:14
povikamarioguy: congratulations!
#asahi-dev · 2022-08-19 23:58
povikyou need to call init_completion on it
#asahi-dev · 2022-08-19 23:58
poviksee https://www.kernel.org/doc/html/latest/scheduler/completion.html
#asahi-dev · 2022-08-19 23:56
povik*than :p
#asahi-dev · 2022-08-19 23:56
poviki don't see anything obvious to explain the lockups other then you may need to initialize the completion
#asahi-dev · 2022-08-19 23:55
povik(i meant squashing with the original changes)
#asahi-dev · 2022-08-19 23:29
povikamarioguy: it's best if you squash it for review
#asahi-dev · 2022-08-19 23:29
povikanyway... let's see the code
#asahi-dev · 2022-08-19 23:29
poviki think looking at 'alsa_card_mtpav_init' it's just another of those things you find out kernel runs every time
#asahi-dev · 2022-08-19 23:25
povikthat's a platform device
#asahi-dev · 2022-08-19 23:25
povikwhoa indeed
#asahi-dev · 2022-08-19 23:08
povikdo that, worst thing that can happen is noone will inspect it
#asahi-dev · 2022-08-19 22:45
poviksame here
#asahi-dev · 2022-08-19 21:12
povikthought it's i2c core calling the probe
#asahi-dev · 2022-08-19 21:12
povikah right
#asahi-dev · 2022-08-19 21:11
poviksven: hm? i don't understand that. how could any transaction occur before the controller's probed?
#asahi-dev · 2022-08-19 21:07
povikyeah, sven is right, 1 to enable
#asahi-dev · 2022-08-19 21:07
poviklooks into docs
#asahi-dev · 2022-08-19 12:17
povikso the same as UCM...
#asahi-dev · 2022-08-19 11:25
povikack
#asahi-dev · 2022-08-19 10:43
povikwhy can't policy-dsp.lua do what you describe?
#asahi-dev · 2022-08-19 10:39
povikyou mean there's different ways you identify cards?

plus ›