#
✕ nick:povik
#asahi-dev · 2022-10-22 09:35
povikthat's not the proper fix though -- the channel number needs to be explicitly constrained in macaudio, if we can't leave that up for userspace
#asahi-dev · 2022-10-22 09:34
povikwhat you did by adjusting the bclk ratio is making MCA driver remove those two extra channels since there's no space for them on the bus
#asahi-dev · 2022-10-22 09:34
povikframe size is 32 always
#asahi-dev · 2022-10-22 09:33
povikchadmed: you are confusing things
#asahi-dev · 2022-10-20 13:45
povikknows how to get lid angle measurements from AOP
#asahi-dev · 2022-10-20 13:45
povikbtw, talking about suspend
#asahi-dev · 2022-10-18 16:10
povikhttps://github.com/AsahiLinux/linux/blob/asahi-wip/sound/soc/apple/mca.c#L264
#asahi-dev · 2022-10-18 16:10
povikthe driver only turns those on after the clocks are up
#asahi-dev · 2022-10-18 16:10
povikmarcan: that's right, it's because the clocks are off. but why does it want to switch on those power domains?
#asahi-dev · 2022-10-18 07:32
povikdoes it sound good?
#asahi-dev · 2022-10-18 07:31
povikchadmed: you can open it for two more channels, but it shouldn't be outright broken like before
#asahi-dev · 2022-10-18 07:31
povikcase closed
#asahi-dev · 2022-10-18 07:31
povikyup, bclk divided by slotwidth
#asahi-dev · 2022-10-18 07:31
povikhttps://github.com/AsahiLinux/linux/blob/asahi-wip/sound/soc/apple/macaudio.c#L590
#asahi-dev · 2022-10-18 07:31
povikor rather here
#asahi-dev · 2022-10-18 07:30
povikhttps://github.com/AsahiLinux/linux/blob/asahi-wip/sound/soc/apple/macaudio.c#L523
#asahi-dev · 2022-10-18 07:30
povikhere we should be looking
#asahi-dev · 2022-10-18 07:30
povikwe are looking at old macaudio.c
#asahi-dev · 2022-10-18 07:27
povikso where do those two channels come from?!
#asahi-dev · 2022-10-18 07:27
povikchadmed: but you are right, nslots should be 6 there
#asahi-dev · 2022-10-18 07:27
poviki thought the machine driver commands an nslots higher than is used
#asahi-dev · 2022-10-18 07:27
poviknow MCA constrains the no. of channels so it can't enter the digital noise failure mode, but it doesn't all need to be usable channels
#asahi-dev · 2022-10-18 07:26
povikchadmed: earlier, when you opened it for 32 channels, you got the 'digital noise' sounds because it was misconfigured at MCA level -- the no. of channels couldn't be supported under the TDM parameters commanded to MCA by the machine driver, so it scrambled the samples across channels
#asahi-dev · 2022-10-18 07:14
povikhttps://github.com/AsahiLinux/linux/blob/asahi/sound/soc/apple/macaudio.c#L248
#asahi-dev · 2022-10-18 07:14
povikah of course
#asahi-dev · 2022-10-18 07:13
povikbet it's the bclk ratio divided by slot size
#asahi-dev · 2022-10-18 07:12
povikhow does that come about, i wonder?
#asahi-dev · 2022-10-18 07:12
povikchadmed: haha
#asahi-dev · 2022-10-18 07:10
poviki can delete mine later
#asahi-dev · 2022-10-18 07:10
povikmarcan: feel free to create it under AsahiLinux and push the current contents, giving me push permission
#asahi-dev · 2022-10-18 07:09
povik*shrug*
#asahi-dev · 2022-10-18 07:09
povikthen i got 'You don’t have the permission to create public repositories on AsahiLinux'
#asahi-dev · 2022-10-18 07:09
poviki pushed the 'Transfer' button, at first it seemed like i don't need any permissions on the target side, just that the new owner will need to approve it
#asahi-dev · 2022-10-18 07:06
poviklet's see what i need to do to initiate the move
#asahi-dev · 2022-10-18 07:06
povik06:55 <@marcan> povik: let me know if you want to move the ucm repo under the org so we can both push :)
#asahi-dev · 2022-10-17 22:01
povikquick glance over the datasheet didn't find anything suspicious though
#asahi-dev · 2022-10-17 22:00
povikthat is what i was thinking
#asahi-dev · 2022-10-17 22:00
povik23:40 < sven> maybe it’s too fast for the tps chips now? :D
#asahi-dev · 2022-10-17 13:58
poviksure, if you can spare a moment debugging pulse, i will take it
#asahi-dev · 2022-10-17 13:58
povikonly i had better experience running pulse + that UCM
#asahi-dev · 2022-10-17 13:58
povikyeah, neither am i
#asahi-dev · 2022-10-17 13:56
povikso as long as the jack was unplugged at any point it breaks?
#asahi-dev · 2022-10-17 13:51
povikargh
#asahi-dev · 2022-10-17 13:47
povikdarn
#asahi-dev · 2022-10-17 13:44
povikif you send a log from pulseaudio or similar i will look at it
#asahi-dev · 2022-10-17 13:44
poviki checked the name of the .conf but it matches the card model in DT exactly
#asahi-dev · 2022-10-17 13:41
povikwhat is the machine specifically? maybe the ucm doesn't get discovered at all
#asahi-dev · 2022-10-17 13:41
povikhuh, wonder what's going wrong there, it works on mac mini for me
#asahi-dev · 2022-10-17 13:40
povik*mean
#asahi-dev · 2022-10-17 13:40
poviki meam cs42l83

plus ›