#asahi-dev · 2022-10-24 10:49
povikyeah, i don't think you should be looking into hw_params at *that* stage#asahi-dev · 2022-10-24 10:46
poviki need to see that print#asahi-dev · 2022-10-24 07:41
povikas it's supposed to be ;)#asahi-dev · 2022-10-24 06:36
povikand don't worry about the runtime fe/be connections#asahi-dev · 2022-10-24 06:36
povikyou probably want to save the max channel number in parse_of, use that in startup of fe#asahi-dev · 2022-10-24 06:30
povikchadmed: you are trying to get to the channel number/#asahi-dev · 2022-10-24 06:30
povikit should#asahi-dev · 2022-10-24 06:30
poviki thought you were suspecting ->dai_link->num_codecs is not the same as what was in ->num_codecs#asahi-dev · 2022-10-24 06:29
povikno, that's not fine#asahi-dev · 2022-10-24 06:29
povikit should be equivalent#asahi-dev · 2022-10-24 06:26
povikchadmed: yes, you have to go through dai_link, so ->dai_link->num_codecs#asahi-dev · 2022-10-23 18:20
povik(i have been thinking the past few days about how we could crowdsource the description of the custom ISA it seems to have. we can single-step on the processor)#asahi-dev · 2022-10-23 18:19
povikand it's mostly repetitive#asahi-dev · 2022-10-23 18:19
povikLEAP does signal processing we probably don't want to skip over, and apple's firmware for it clocks at ~500 instructions#asahi-dev · 2022-10-23 18:18
povikwhat's LEAP you ask? it's another processor i discovered is on the SoCs!#asahi-dev · 2022-10-23 18:18
povikit's easy to do other than we should write our own LEAP firmware in that case, instead of needing the one that's embedded in AOP firmware#asahi-dev · 2022-10-23 18:17
poviki would love to skip it and "access" the mics directly#asahi-dev · 2022-10-23 18:17
povikChaosPrincess: yes. at least that's how macos does it#asahi-dev · 2022-10-23 18:17
povikthere's been a breaking change in the binding some time ago, dropping that irq-destination property#asahi-dev · 2022-10-23 18:17
povikjannau: yes. old driver seeing recent devicetree#asahi-dev · 2022-10-23 17:44
povikpushed AOP stuff: https://github.com/AsahiLinux/m1n1/pull/259#asahi-dev · 2022-10-23 09:37
povikthen call the alsa constraint function like in the recent channels-according-to-slots MCA patch#asahi-dev · 2022-10-23 09:36
povikchadmed: if you want to give implementing it a go, i think you should apply the constrain in .startup of macaudio_fe_ops#asahi-dev · 2022-10-23 09:27
povikbut it's better than to special-case#asahi-dev · 2022-10-23 09:27
povikon the primary, it will be a no-op, since it's already constrained by slots#asahi-dev · 2022-10-23 09:27
povikexactly. you can set the constrain on all frontends#asahi-dev · 2022-10-23 09:25
povikso there's not much we need to assume#asahi-dev · 2022-10-23 09:25
povikand that we can do to the maximum number of channels on a backend link, so to the number of speaker channels#asahi-dev · 2022-10-23 09:24
povikwe shouldn't enforce the slots (which would constrain the number of channels in mca.c), we should constrain the number of channels from macaudio.c directly#asahi-dev · 2022-10-23 09:24
povik11:13 < chadmed> but since the problem is on the frontends and not the backend DAIs, i cant really see how we would enforce the number of TDM slots unless we could make the safe assumption that the secondary frontend is always the internal speakers, which is why i asked about it#asahi-dev · 2022-10-23 09:23
povikincluding, as you point out, not having a DT representation for the frontend links, since those are an ASoC vehicle#asahi-dev · 2022-10-23 09:23
povikre dai-tdm-slot-num. i know it's there. i moved away from the approach of describing the DAI links in full in the DT since there's just too many details and they are tied to internal ASoC representation instead of being inherent to the hardware, so compatible="apple,j313-macaudio" must be where all those details are hidden in#asahi-dev · 2022-10-23 09:13
povikthose are beefy. patches to ease reading of them welcome#asahi-dev · 2022-10-23 09:11
povikhaha, hope it wasn't too bad an experience :p#asahi-dev · 2022-10-23 09:09
poviki guess you figured out some tools don't show the control name in full. if the caps weren't being applied, the driver would refuse probe. really, you should be giving more credit to the driver ;)#asahi-dev · 2022-10-23 09:08
povik06:10 < chadmed> also fwiw the amp gain kctls dont have Volume in their name, so those gain caps in the fixup methods werent applying#asahi-dev · 2022-10-23 09:08
povikarguably it's more useful on mac mini/studio than on the laptops, but i would rather not introduce additional differences into macaudio across models#asahi-dev · 2022-10-23 09:07
povikthat's the geneeral case for it#asahi-dev · 2022-10-23 09:07
povikchadmed: well, there's one weak case for when they could be useful: user not employing speaker EQ, feeding speakers directly, having both speakers and headphones on primary, switching between one and the other using 'pin' controls (which enable the endpoints) instead of restarting playback on different device#asahi-dev · 2022-10-22 09:46
povikyeah, you can try commenting things out to narrow down the cause -- if pipewire logging isn't helpful#asahi-dev · 2022-10-22 09:44
povik*as of now#asahi-dev · 2022-10-22 09:44
povikwhich is missing for the speakers as of know, which i had the idea may be the cause for pipewire ignoring it#asahi-dev · 2022-10-22 09:44
povikthere's the ~PlaybackChannels verb in UCM#asahi-dev · 2022-10-22 09:43
povikhaha#asahi-dev · 2022-10-22 09:42
povikincluding not opening it for extra dead channels#asahi-dev · 2022-10-22 09:41
povikso we can take the position that userspace needs to know how to drive the device usefully anyway#asahi-dev · 2022-10-22 09:40
poviksince those extra channels should be benign (if not, that's a kernel bug)#asahi-dev · 2022-10-22 09:40
povikchadmed: if we figured this out on the userspace side instead, i would find that neat#asahi-dev · 2022-10-22 09:35
povikwell, it's bit of additional code to constrain it in macaudio#asahi-dev · 2022-10-22 09:35
povikthat follows from: (1) MCA cares about the bus, not the overall audio system; (2) to simplify macaudio we should share bus settings across models