#
✕ nick:marcan
#asahi-dev · 2022-09-05 16:18
marcanI think you also need the mailbox patch? withotu that, apple_rtkit_poll won't work (and therefore shutdown/reboot won't work properly)
#asahi-dev · 2022-09-05 16:17
marcanand I pushed that patch through since it was "done" even though it doesn't have a consumer in the asahi DTs yet
#asahi-dev · 2022-09-05 16:16
marcanI did test it though.
#asahi-dev · 2022-09-05 16:16
marcanrmk: IIRC I added the GPIO IRQ stuff so that sdmmc could use them for card detect (instead of the internal one) and therefore power down the entire controller when no SD card is inserted, as part of the WIP PCIe power management stuff, but that didn't go into asahi yet since it's not done.
#asahi-dev · 2022-09-05 16:11
marcanrmk: fwiw everything I didn't comment on re:style and such is fine to do what Andy says, though I find it all *extremely* nitpicky and much of it a waste of time, but shrug
#asahi-dev · 2022-09-05 15:06
marcanrmk: sorry you had to deal with him
#asahi-dev · 2022-09-05 14:54
marcanbut now he's coming from gmail, so I don't know
#asahi-dev · 2022-09-05 14:53
marcanhe used to comment from an Intel email, and I was convinced Intel had him in some department twiddling his thumbs and he just decided to kill time reviewing random Linux patches
#asahi-dev · 2022-09-05 14:23
marcanis replying to Andy right now in case you didn't notice
#asahi-dev · 2022-09-05 14:22
marcanand he just drive-bys everything I do it seems
#asahi-dev · 2022-09-05 14:22
marcansome fraction of those actually taught me about some kernel functions I didn't know about, but let's just say the SNR on his reviews is abysmal
#asahi-dev · 2022-09-05 14:21
marcanand the other half are just nitpicks
#asahi-dev · 2022-09-05 14:21
marcanbut yeah, as far as I'm concerned Andy has been on every upstreaming thread I've had, and half his comments have been purely wasting my time explaining to him why he didn't actually read the code
#asahi-dev · 2022-09-05 14:20
marcanfound it
#asahi-dev · 2022-09-05 14:18
marcan(over half his review comments are completely useless, consistently - he doesn't seem to actually read the code he reviews beyond a 4-line context window)
#asahi-dev · 2022-09-05 14:18
marcan(conversely, I'm not sure what andy cares about - he seems to want to review as much code as possible, as sloppily as possibly. I often wonder if he has nothing better to do.)
#asahi-dev · 2022-09-05 14:17
marcanj`ey: where did he say that?
#asahi-dev · 2022-09-05 13:54
marcankettenis: I'll have good motivation to upstream stuff when DART t6k is finally merged :p
#asahi-dev · 2022-09-04 15:23
marcanI'm going to allocate tuesday to playing the merge game (rmk: haven't forgotten about you either, IRQs today, but I'll get to it before tuesday)
#asahi-dev · 2022-09-02 18:57
marcanpovik already implemented that stuff I think
#asahi-dev · 2022-09-02 18:57
marcanit's controlled by the driver
#asahi-dev · 2022-09-02 18:25
marcanrmk: I'll go over the discussion on sunday if that's okay
#asahi-dev · 2022-09-02 18:22
marcansven: lol
#asahi-dev · 2022-09-01 01:10
marcanthanks! :)
#asahi-dev · 2022-09-01 01:08
marcanyou actually have it backwards, that's a prior notification ACK and a new notification
#asahi-dev · 2022-09-01 01:08
marcaner sorry, 16 bytes before xcpi
#asahi-dev · 2022-09-01 01:07
marcanthe "Inline payload" should start with xcpi or 00 00 00 00 xcpi if I'm not wrong
#asahi-dev · 2022-09-01 01:07
marcansven: yes, and also, that's broken, try this: https://mrcn.st/p/4aF1ut5h
#asahi-dev · 2022-08-31 18:48
marcanat least that explicitly points towards trying something else as an option to explore :p
#asahi-dev · 2022-08-31 18:47
marcanlike "this is ugly but I don't have any better ideas"
#asahi-dev · 2022-08-31 18:26
marcanbut hopefully that won't happen
#asahi-dev · 2022-08-31 18:25
marcanwell, at least if v4 gets stuck in limbo again we can try playing the poking Linus card... he depends on that (and my t8110 support series on top)
#asahi-dev · 2022-08-31 18:24
marcangreat way to demotivate developers, tbh :(
#asahi-dev · 2022-08-31 18:24
marcan(reminds me of ALARM...)
#asahi-dev · 2022-08-31 18:23
marcanthe problem is v1/v2 were forever stuck in "this is ugly but the maintainer doesn't have any better ideas" limbo, and the only reason we knew that was side channels, because there were no direct replies
#asahi-dev · 2022-08-31 18:22
marcanthe split did get an acked-by already at least
#asahi-dev · 2022-08-31 18:21
marcanpovik: it got two replies
#asahi-dev · 2022-08-31 18:21
marcanafter t6000 goes in t8113 should be easy to get supported - that only touches the driver proper, and my series for that is ready
#asahi-dev · 2022-08-31 18:20
marcanjannau: think you can try submitting a v4 sometime soon with the few review comments addressed?
#asahi-dev · 2022-08-31 18:20
marcanthe last review round of that was in june, after v1/v2 got crickets
#asahi-dev · 2022-08-31 18:18
marcan(also, personaly, I'm still a bit dismayed at the blockers - we're coming up on 1 year after the t6000 release and still no DART2 support upstream, that's holding back all chips except the original M1)
#asahi-dev · 2022-08-31 18:16
marcanusually people upstream their own stuff, but I in particular have been behind on that because I have too many things to do...
#asahi-dev · 2022-08-31 18:15
marcan(especially for me, since I actually want to read or at least skim the full backlog here, I've given up on that for #asahi)
#asahi-dev · 2022-08-31 18:14
marcanyeah, it helps keep things more focused and easier to grep for actionable things I find
#asahi-dev · 2022-08-31 18:12
marcanrmk: this is the higher SNR channel :)
#asahi-dev · 2022-08-31 17:29
marcansven: there is that pmgr thing it does, dunno about anything else
#asahi-dev · 2022-08-31 17:28
marcanDmitrySharshakov[m], jannau: I2C/DDC goes through DCP
#asahi-dev · 2022-08-31 05:44
marcanmostly wifi, pcie can stay up as long as wifi doesn't drop the link, but ideally we support that anyway
#asahi-dev · 2022-08-30 17:33
marcanpabloscloud[m]: asking isn't going to make it go any faster, and asking in the channel where developers are trying to work on things *definitely* isn't going to make it go faster ;)
#asahi-dev · 2022-08-30 17:33
marcangoing to sleep

plus ›