#asahi-dev · 2022-09-06 16:57
marcan(to be fair, he had some actual useful feedback that patch series - this wasn't one of them, though)#asahi-dev · 2022-09-06 16:57
marcanbut feel free to remove it or replace it with something else#asahi-dev · 2022-09-06 16:57
marcanyeah, that was a BUG_ON() basically because if it fires someone did something very wrong with that driver#asahi-dev · 2022-09-06 16:56
marcannobody else commented on that, so if you want to drop the BUG_ON, I don't care; it wasn't in v2 either#asahi-dev · 2022-09-06 16:55
marcanI added that after a review discussion with our friend Andy where he claimed the existing code was somehow error-prone#asahi-dev · 2022-09-06 16:54
marcanit's impossible for that BUG_ON to fire unless someone screwed up the code later#asahi-dev · 2022-09-06 16:54
marcanrmk: because the nvram buffer is sized to be able to hold exactly that many extra characters for the MAC address (in the worst case), and either way the format string should be constant length, so any discrepancy there means someone introduced a bug#asahi-dev · 2022-09-06 15:57
marcanand we already had a discussion on how to do the power-enable stuff (differently to how it's done now)#asahi-dev · 2022-09-06 15:57
marcansince yesterday I discovered how to put these chips to sleep finally :)#asahi-dev · 2022-09-06 15:57
marcanI'll be redoing that next#asahi-dev · 2022-09-06 15:56
marcandon't bother with the dt changes of course, since that depends on the pcie power thing#asahi-dev · 2022-09-06 15:56
marcananyway, feel free to submit up to 4378 if you want#asahi-dev · 2022-09-06 15:56
marcanI hope not! :D#asahi-dev · 2022-09-06 15:56
marcanI *think* it was all addressed and the review tags applied. At least I have everything marked as done here.#asahi-dev · 2022-09-06 15:55
marcananyway, I have a meeting in 5 minutes ;)#asahi-dev · 2022-09-06 15:55
marcanunfortunately, special snowflake rules really don't help people who want to contribute...#asahi-dev · 2022-09-06 15:53
marcanI'm working on wifi right now, so I was thinking of finally resubmitting this soon (with even more stuff tacked on, but maybe in chunks this time *sigh*)#asahi-dev · 2022-09-06 15:53
marcannetdev seems to be rather special#asahi-dev · 2022-09-06 15:52
marcan(and the funny comment style)#asahi-dev · 2022-09-06 15:52
marcanas is reverse christmas tree, as I found#asahi-dev · 2022-09-06 15:52
marcanhttps://lore.kernel.org/all/87fspvln3u.fsf@tynnyri.adurom.net/ that reply was what made upstreaming this drop to the bottom of *my* queue ;)#asahi-dev · 2022-09-06 15:51
marcanyeah then you don't care about newer chips#asahi-dev · 2022-09-06 15:51
marcanand what I got back from the maintainer was "if you don't send it in chunks it will go to the bottom of my pile"#asahi-dev · 2022-09-06 15:51
marcanas I explained in my original submission, the series was incremental and could be merged in chunks / reviewed as such#asahi-dev · 2022-09-06 15:50
marcanrmk: if your device has a 4378, you don't need the patches after that#asahi-dev · 2022-09-06 15:49
marcanhttps://lore.kernel.org/all/20220117142919.207370-1-marcan@marcan.st/ this was the fixes series that did go in#asahi-dev · 2022-09-06 15:47
marcanthe actual support series is 29 patches and I never resubmitted it after the fixes part went in#asahi-dev · 2022-09-06 15:47
marcanthe fixes have been merged for a while#asahi-dev · 2022-09-06 15:46
marcanand I never got around to sending the rest because the reaction to the submission got me in a bad mood and I moved onto other things#asahi-dev · 2022-09-06 15:46
marcanthat was the fixes series#asahi-dev · 2022-09-06 15:46
marcanI think it was merged?#asahi-dev · 2022-09-06 13:34
marcanpovik: thanks!#asahi-dev · 2022-09-06 13:09
marcanyeah#asahi-dev · 2022-09-06 12:57
marcanso feel free :)#asahi-dev · 2022-09-06 12:57
marcanpovik: going to do it nowish (today has been full of distractions...)#asahi-dev · 2022-09-06 10:05
marcanhmm, nope#asahi-dev · 2022-09-06 10:02
marcan(assuming this is the same btc_mode)#asahi-dev · 2022-09-06 10:02
marcanlet me try just patching that...#asahi-dev · 2022-09-06 10:02
marcanthe nvram defaults to btc_mode=1 which is lowprio for a2dp, not good#asahi-dev · 2022-09-06 10:00
marcansven: this implies there is a BT-side btc_mode (though that var is in the wlan nvram, but maybe at runtime it comes from BT?)#asahi-dev · 2022-09-06 10:00
marcanhttps://patents.google.com/patent/US8873418#asahi-dev · 2022-09-06 10:00
marcanlol, there is a patent#asahi-dev · 2022-09-06 09:37
marcanSBC is still worse than the speakers so that would still be a usable test#asahi-dev · 2022-09-06 09:37
marcanhmm#asahi-dev · 2022-09-06 09:35
marcanI wonder if Apple does anything special in LDAC mode (do they even support it?)#asahi-dev · 2022-09-06 09:34
marcanon LDAC it just dies, completely, when the wifi is on 2.4#asahi-dev · 2022-09-06 09:34
marcanit's about as bad as the speakers on SBC, maybe a bit worse#asahi-dev · 2022-09-06 09:34
marcanar: ha, good point. it's LDAC that does it, why my speakers were okay#asahi-dev · 2022-09-06 09:33
marcansven: yeah, I was wondering. but I also need to make sure I didn't screw the wifi side up nor miss anything :)#asahi-dev · 2022-09-06 09:27
marcanso, more research needed :p