#
✕ nick:marcan
#asahi-dev · 2022-10-24 15:30
marcanI expect those IDs to be reserved for DCP anyway
#asahi-dev · 2022-10-24 15:30
marcanPRs welcome etc :)
#asahi-dev · 2022-10-24 15:30
marcanbut yes, you should probably just reorder the code
#asahi-dev · 2022-10-24 15:29
marcanI added a quick fix to not propagate the error for now
#asahi-dev · 2022-10-24 15:29
marcanlol
#asahi-dev · 2022-10-24 15:28
marcanor that
#asahi-dev · 2022-10-24 15:28
marcanyou should probably actually return an error on missing alias, and just have the calling code not propagate it and break the loop
#asahi-dev · 2022-10-24 15:28
marcanyes
#asahi-dev · 2022-10-24 15:28
marcanso it just keeps going
#asahi-dev · 2022-10-24 15:28
marcanyou return without error when the alias is missing
#asahi-dev · 2022-10-24 15:27
marcanbecause you're looking for all DCPs
#asahi-dev · 2022-10-24 15:27
marcanit failed trying to map the dcpext4 carveout, so it sounds like it would only work on Ultra? unless the Max iBoot also has the Ultra regions (but then the Pro one has the Max ones?)
#asahi-dev · 2022-10-24 15:26
marcan(which is what I just did)
#asahi-dev · 2022-10-24 15:26
marcan_jannau_: or just not return an error
#asahi-dev · 2022-10-24 15:06
marcan(seriously though, this needs to be actually reliable/stable for us to push it to users, not just in light testing but abuse too)
#asahi-dev · 2022-10-24 15:05
marcandon't make me ask Lina to rewrite DCP in Rust... :p
#asahi-dev · 2022-10-24 14:26
marcanno, you need git m1n1
#asahi-dev · 2022-10-24 14:21
marcananyway, pushed another kernel batch with a config to disable the backlight stuff if DCP is compiled in
#asahi-dev · 2022-10-24 14:14
marcannot as good as macOS yet but better than anything x86, that's for sure
#asahi-dev · 2022-10-24 14:14
marcanI sure hope people don't complain ;)
#asahi-dev · 2022-10-24 14:14
marcan>30h on M1 MBA right now
#asahi-dev · 2022-10-24 14:09
marcantold you.
#asahi-dev · 2022-10-24 14:09
marcanDCP gives us 70% better idle (and by extension s2idle) battery life.
#asahi-dev · 2022-10-24 14:09
marcanPOWER_SUPPLY_TIME_TO_EMPTY_NOW=110040
#asahi-dev · 2022-10-24 14:09
marcanPOWER_SUPPLY_CURRENT_NOW=-137000
#asahi-dev · 2022-10-24 14:09
marcanPOWER_SUPPLY_TIME_TO_EMPTY_NOW=65280
#asahi-dev · 2022-10-24 14:09
marcanPOWER_SUPPLY_CURRENT_NOW=-233000
#asahi-dev · 2022-10-24 14:09
marcanwant to hear some good news?
#asahi-dev · 2022-10-24 13:57
marcanso yeah, we need brightness control
#asahi-dev · 2022-10-24 13:56
marcan_jannau_: nah, indeed after dpms it comes back at min
#asahi-dev · 2022-10-24 13:53
marcan_jannau_: are you sure the brightness control problems aren't just due to the same conflict?
#asahi-dev · 2022-10-24 13:47
marcanonly usable without DCP
#asahi-dev · 2022-10-24 13:47
marcanthe backlight thing was always a hack
#asahi-dev · 2022-10-24 13:47
marcaneither way this was always a bad idea
#asahi-dev · 2022-10-24 13:47
marcanentirely possible DCP manages that gpio on j314c and not j313
#asahi-dev · 2022-10-24 13:46
marcansince we intend to have two kernels but just config changes, not DT changes
#asahi-dev · 2022-10-24 13:46
marcanI'm going to make it a separate kconfig for backlight support and make them mutually exclusive
#asahi-dev · 2022-10-24 13:46
marcanit's incompatible by definition
#asahi-dev · 2022-10-24 13:46
marcanthe idea was always to remove the backlight stuff when we introduce DCP
#asahi-dev · 2022-10-24 13:46
marcanand possibly breaking dcp
#asahi-dev · 2022-10-24 13:46
marcanyes
#asahi-dev · 2022-10-24 13:41
marcanthe backlight stuff was always intended to go away with DCP
#asahi-dev · 2022-10-24 13:41
marcanokay yeah it works now
#asahi-dev · 2022-10-24 13:34
marcanbut also those errors
#asahi-dev · 2022-10-24 13:34
marcan_jannau_: yes, the backlight definitely turns off when DCP loads
#asahi-dev · 2022-10-24 13:33
marcanyeah...
#asahi-dev · 2022-10-24 13:20
marcanI'm getting random SMC command timeouts when running dmesg in a hypervisor console, and I don't know why but I suspect mailbox again
#asahi-dev · 2022-10-24 12:40
marcanyeah okay something's broken
#asahi-dev · 2022-10-24 12:40
marcan[ 2.600009] apple-dcp 231c00000.dcp: RTKit: syslog message: nifiedPipeline.cpp:6548: set_digital_out_mode returned 8000000b
#asahi-dev · 2022-10-24 12:40
marcanit seems to detect a hotplug and set mode after that

plus ›