#
✕ nick:marcan
#asahi-dev · 2023-01-22 15:51
marcanjannau: pushed a fixup with a comment
#asahi-dev · 2023-01-22 15:45
marcanno it's just a race
#asahi-dev · 2023-01-22 15:45
marcanyeah, it's a race
#asahi-dev · 2023-01-22 15:43
marcanI suspect I know what this is
#asahi-dev · 2023-01-22 15:17
marcanafter a couple sleep cycles it stopped saying that
#asahi-dev · 2023-01-22 15:16
marcan(it does work nonetheless though)
#asahi-dev · 2023-01-22 15:16
marcanthat clearly shouldn't happen
#asahi-dev · 2023-01-22 15:15
marcan[ 20.424813] apple-dcp 38bc00000.dcp: failed to suspend DCP
#asahi-dev · 2023-01-22 15:15
marcan[ 20.423739] apple-dcp 38bc00000.dcp: Runtime PM usage count underflow!
#asahi-dev · 2023-01-22 15:15
marcannow it works, except
#asahi-dev · 2023-01-22 15:13
marcanyup...
#asahi-dev · 2023-01-22 15:12
marcandid I miss that patch?
#asahi-dev · 2023-01-22 15:11
marcanoh it's marked always-on
#asahi-dev · 2023-01-22 15:11
marcanno wait, it's not that
#asahi-dev · 2023-01-22 15:10
marcanah yes, some DT stuff I think?
#asahi-dev · 2023-01-22 15:08
marcandid I miss something else?
#asahi-dev · 2023-01-22 15:08
marcanjannau: still times out though, with that
#asahi-dev · 2023-01-22 15:05
marcanyeah, DART rpm was missing
#asahi-dev · 2023-01-22 15:04
marcanI think I might have screwed up some patches, sec
#asahi-dev · 2023-01-22 15:03
marcanno, after a sleep/wake
#asahi-dev · 2023-01-22 15:02
marcanmight want to shorten it
#asahi-dev · 2023-01-22 15:02
marcanthe timeout does cause a slight user visible delay that's not great
#asahi-dev · 2023-01-22 15:02
marcanI assume that's normal?
#asahi-dev · 2023-01-22 15:02
marcan[ 211.942392] apple-dcp 38bc00000.dcp: RTKit: Initializing (protocol version 12)
#asahi-dev · 2023-01-22 15:02
marcan[ 211.940035] apple-dcp 38bc00000.dcp: RTKit wakeup timed out, trying reset. Please do not report bugs
#asahi-dev · 2023-01-22 15:01
marcanjannau: the hack looks fine for now, we can shave that yak later
#asahi-dev · 2023-01-22 14:59
marcanmerged and pushed, smoke tested on t6000
#asahi-dev · 2023-01-22 14:54
marcandone
#asahi-dev · 2023-01-22 14:35
marcanthanks :)
#asahi-dev · 2023-01-22 14:35
marcansure
#asahi-dev · 2023-01-22 14:13
marcanI'll look at it
#asahi-dev · 2023-01-22 14:12
marcanand DCP too, and other things :p
#asahi-dev · 2023-01-22 14:11
marcansven: looks like a generic DMA copy engine?
#asahi-dev · 2023-01-22 14:03
marcanjannau: I think at this point we might just release everything together, so I'm happy to merge those in first
#asahi-dev · 2023-01-22 12:28
marcan(better export unknown keys than leave them out)
#asahi-dev · 2023-01-22 12:28
marcanand leave the others as raw keys
#asahi-dev · 2023-01-22 12:28
marcanthen pull descriptions from the DT or (on intel) hardcoded tables for known keys
#asahi-dev · 2023-01-22 12:27
marcanthe driver needs to just enumerate all T??? keys, and grab the formats, and export everything it supports
#asahi-dev · 2023-01-22 12:27
marcanso apple silicon already has mixed key formats: most templeratures are 'flt ' (float32), but some are 'ioft' (16.16 fixed point). intel macs seem to use (at least) 'sp78' which is 8.8 fixed point (7.8 plus sign bit, but hopefully the sign bit is standard two's complement?)
#asahi-dev · 2023-01-22 12:13
marcanand in the meantime we can just have both drivers mutually exclusive in kconfig and let people pick
#asahi-dev · 2023-01-22 12:12
marcanthose are easy enough to throw in for completeness and call the existing driver superseded
#asahi-dev · 2023-01-22 12:12
marcanonce we have fan/temp unified, the rest of what the intel driver is what... keyboard backlight and some ambient light sensor thing?
#asahi-dev · 2023-01-22 12:10
marcanchadmed_: not worth it IMO
#asahi-dev · 2023-01-22 12:09
marcanyou can query key type and data format
#asahi-dev · 2023-01-22 12:09
marcanthat's just a minor divergence
#asahi-dev · 2023-01-22 12:09
marcanso that means the driver can just find out and support both
#asahi-dev · 2023-01-22 12:09
marcanChaosPrincess: oh, good point, they do, but... key type is discoverable
#asahi-dev · 2023-01-22 12:08
marcan?
#asahi-dev · 2023-01-22 12:08
marcanlike, quite likely, the battery stuff
#asahi-dev · 2023-01-22 12:07
marcanand I expect T2 Macs to share a lot more with M1s

plus ›