#
✕ nick:marcan
#asahi-dev · 2023-03-11 14:10
marcanmore involved fixes can wait
#asahi-dev · 2023-03-11 14:10
marcanat this point I just want to get this out ASAP, we've delayed this release long enough
#asahi-dev · 2023-03-11 14:09
marcanwant to send the patch?
#asahi-dev · 2023-03-11 14:09
marcanyeah okay let's do that
#asahi-dev · 2023-03-11 14:09
marcansigh.
#asahi-dev · 2023-03-11 14:07
marcan(but not now, this is going on my queue for later)
#asahi-dev · 2023-03-11 14:07
marcanif that sounds like a sensible solution to you I'll go with that
#asahi-dev · 2023-03-11 14:06
marcanyeah
#asahi-dev · 2023-03-11 14:06
marcanI don't particularly care about clocks for this platform so someone else can worry about that :-)
#asahi-dev · 2023-03-11 14:05
marcanso I'm thinking the genpd core should refuse to power off PDs if there are any unprobed/unfulfilled fwlinks
#asahi-dev · 2023-03-11 14:05
marcanyeah
#asahi-dev · 2023-03-11 14:05
marcan(because hardware is already on at the bootloader and you can't just yank power from it, or because it's outright a dependent PD)
#asahi-dev · 2023-03-11 14:04
marcanthis is a particular problem for PDs because hardware has interesting rules for that, like you can't just turn off some power domains that are on at boot without first hooking up their dependencies
#asahi-dev · 2023-03-11 14:02
marcanso then another dependency comes along that expected that not to happen and it breaks
#asahi-dev · 2023-03-11 14:02
marcanrobher: PDs turn off when their *first* dependency probes and idles itself
#asahi-dev · 2023-03-11 13:49
marcanuhh
#asahi-dev · 2023-03-11 13:49
marcanI do get the warnings though
#asahi-dev · 2023-03-11 13:49
marcanoh wait I had that in 130 already
#asahi-dev · 2023-03-11 13:48
marcanjannau: added your fix to bits/030-misc
#asahi-dev · 2023-03-11 13:47
marcanI think I saw the patch for that
#asahi-dev · 2023-03-11 13:44
marcan:D
#asahi-dev · 2023-03-11 13:44
marcanthe "proper" fix might have to wait until later though, since I have way too much stuff on my plate first
#asahi-dev · 2023-03-11 13:42
marcannew kernels should be up too
#asahi-dev · 2023-03-11 13:42
marcanbut if people don't like that then hack it is
#asahi-dev · 2023-03-11 13:42
marcanI'll try doing it "properly" with some fwlink based thing in the PM core
#asahi-dev · 2023-03-11 13:41
marcanwe can also do the same thing DCP does for now and unmark that flag in the nvme driver
#asahi-dev · 2023-03-11 13:39
marcanit would depend on probe order, yes
#asahi-dev · 2023-03-11 13:38
marcanwe don't really want that since it makes nvme PM worse, but for now it will do
#asahi-dev · 2023-03-11 13:37
marcanI know OF already has some stuff to pre-populate fwnode links based on power-domains properties, maybe what we should do is make the PM core refuse to power off a domain if there are any links that haven't probed yet?
#asahi-dev · 2023-03-11 13:35
marcanso basically we need some way for the pmgr driver to synchronously ensure the entire hierarchy it is responsible for is probed, not just a single pass with stuff ending up deferred
#asahi-dev · 2023-03-11 13:34
marcanhowever, PD dependencies not being honored are a much bigger problem
#asahi-dev · 2023-03-11 13:34
marcan(we hack around that one by marking it always-on and then the DCP driver unmarks it)
#asahi-dev · 2023-03-11 13:34
marcanthis is a deeper problem we also have with e.g. DCP (where its PD is illegal to turn off until the DCP driver probes), but that's a bit of a special case
#asahi-dev · 2023-03-11 13:34
marcanrobher: is OF probe order across buses/sub-buses defined at all? we have a problem with pmgr nodes, where some nodes probe before their power-domain parents, so they get deferred. then some other device probes, and as the first consumer goes into suspend and the parent gets powered off. then the deferred child probes, and bails when it finds itself on but the parent off, which is illegal.
#asahi-dev · 2023-03-11 13:26
marcanCyrinux9: reverting m1n1/boot.bin to boot.bin.old from recovery will probably work enough to boot to linux and update again
#asahi-dev · 2023-03-11 13:26
marcan(so this is on you to fix, we don't support asahi-dev)
#asahi-dev · 2023-03-11 13:25
marcanCyrinux9: unless you intend your system to break, you shouldn't be using asahi-dev
#asahi-dev · 2023-03-11 13:25
marcanCyrinux9: too late, already on it
#asahi-dev · 2023-03-11 13:22
marcandone, thanks
#asahi-dev · 2023-03-11 13:16
marcanlet's just make ans2 always-on for now
#asahi-dev · 2023-03-11 13:16
marcanblergh this PD thing is going to suck to fix
#asahi-dev · 2023-03-11 13:14
marcansince there's like 8 of those
#asahi-dev · 2023-03-11 13:14
marcankaprests: I think we may need way more for dcpext on e.g. M1 Ultra? if this is about reserved-regions
#asahi-dev · 2023-03-11 13:13
marcanI think what we *really* want here is something in the genpd core to make it refuse to shut down any PDs that have consumers in OF that have not probed yet
#asahi-dev · 2023-03-11 13:08
marcanthat's easy then
#asahi-dev · 2023-03-11 13:07
marcanheh
#asahi-dev · 2023-03-11 13:06
marcanI think we can probably fix it with some ugly custom module init stuff in apple-pmgr-pwrstate, so that it greedily keeps scanning for and probing devices at load time until everything is probed, instead of letting EPROBE_DEFER go back to the driver core
#asahi-dev · 2023-03-11 13:04
marcangoddammit we need some real solution for this mess
#asahi-dev · 2023-03-11 13:04
marcanargh it's because it's a different pmgr altogether
#asahi-dev · 2023-03-11 13:04
marcanwait no

plus ›