#asahi-dev · 2021-12-11 10:30
marcanSPI has no concept of "read" or "write" transactions#asahi-dev · 2021-12-11 10:29
marcanI'm not sure what spi-tx-delay-us and spi-rx-delay-us are supposed to represent though#asahi-dev · 2021-12-11 10:29
marcanI just noticed it only showed up in linux-next#asahi-dev · 2021-12-11 10:29
marcanjannau: oh wow, that entire file isn't even in mainline yet#asahi-dev · 2021-12-11 10:27
marcanif everything's compatible then that's no drama#asahi-dev · 2021-12-11 10:27
marcanmake sure it still works with gpio mode though, ideally we want to keep that option open if we ever find a good reason to switch#asahi-dev · 2021-12-11 10:27
marcansounds good :)#asahi-dev · 2021-12-11 09:55
marcanbut given Apple doesn't hardcode these, I'd be worried about hardcoding them in the driver as far as forwards compat#asahi-dev · 2021-12-11 09:55
marcanI need to dig back through intel mac props, if I can find them, to see if they've changed#asahi-dev · 2021-12-11 09:54
marcanjannau: so what I was thinking is that we might want to add these delays as standard spi-peripheral props and make the SPI core understand them, instead of doing a driver one-off#asahi-dev · 2021-12-11 09:54
marcanseems they have inconsistent numbers in the ADT and in that config from the device :-)#asahi-dev · 2021-12-11 09:53
marcanthe ADT timings are 20us for start/end CS though#asahi-dev · 2021-12-11 09:52
marcanjannau: I think that interpretation makes sense#asahi-dev · 2021-12-11 03:56
marcanj`ey: for the capslock thing, I guess setting cs_inactive would fix that too#asahi-dev · 2021-12-10 15:37
marcanand a fixes = log -1 --format=fixes alias#asahi-dev · 2021-12-10 15:37
marcanI also just added myself a fixes = Fixes: %h (\"%s\") format#asahi-dev · 2021-12-10 15:37
marcanthanks#asahi-dev · 2021-12-10 15:36
marcanah, yeah#asahi-dev · 2021-12-10 15:33
marcanah, forgot the signoff. adding it before submission :p#asahi-dev · 2021-12-10 15:31
marcanI'm just going to send off that spi core patch now, it's obvious#asahi-dev · 2021-12-10 15:31
marcanthen on top of that, you can do this to applespi: https://mrcn.st/p/O5dbDo3P#asahi-dev · 2021-12-10 15:31
marcanj`ey, jannau: pushed the core fixes to asahi#asahi-dev · 2021-12-10 15:11
marcanbroken code, broken code everywhere#asahi-dev · 2021-12-10 15:11
marcanit needs to happen at the end of the function#asahi-dev · 2021-12-10 15:11
marcancs_setup handling is wrong lol#asahi-dev · 2021-12-10 15:10
marcanalso, er, I think it's wrong?#asahi-dev · 2021-12-10 15:10
marcannot if set_cs_timing exists#asahi-dev · 2021-12-10 15:08
marcanthe spi core needs some code to call it during transfer setup passing in spi_device values#asahi-dev · 2021-12-10 15:07
marcanthat removal removed its usage#asahi-dev · 2021-12-10 15:07
marcanthe set_cs_timing thing is definitely wrong though#asahi-dev · 2021-12-10 15:07
marcan(though no drivers do that)#asahi-dev · 2021-12-10 15:06
marcannot through a function#asahi-dev · 2021-12-10 15:06
marcanso I guess we're just supposed to set those directly#asahi-dev · 2021-12-10 15:06
marcanahh right#asahi-dev · 2021-12-10 15:06
marcanshouldn't those values be per-device, not per-controller?#asahi-dev · 2021-12-10 15:06
marcanit bugs me that it changes the delays on the controller though#asahi-dev · 2021-12-10 15:04
marcanthat would be the function for the new HID driver to se the CS delays#asahi-dev · 2021-12-10 15:03
marcanwe need https://gitlab.arm.com/linux-arm/linux-jg/-/commit/4ccf359849ce709f4bf0214b4b5b8b6891d38770 back#asahi-dev · 2021-12-10 15:03
marcanugh#asahi-dev · 2021-12-10 15:00
marcanthere is nothing that calls it, but it existing cancels the delay code#asahi-dev · 2021-12-10 15:00
marcanalso, is it me or is set_cs_timing broken in the spi core?#asahi-dev · 2021-12-10 14:58
marcaneither way obviously the way that driver is doing things is wrong; instead of that delay message it should be setting up a cs_hold#asahi-dev · 2021-12-10 14:57
marcanunless I dropped it while rebasing at some point, but I don't think so? at least not intentionally#asahi-dev · 2021-12-10 14:56
marcanyup, keyboard works now#asahi-dev · 2021-12-10 14:55
marcanthat wasn't in jannau's branch I think#asahi-dev · 2021-12-10 14:53
marcan... because applespi calls applespi_setup_read_txfrs before applespi_setup_spi, which is what sets the cs delay value#asahi-dev · 2021-12-10 14:47
marcanok, got gpiola running on the hypervisor while running linux; I can't see the signals accurately at 8MHz, but I can tell the CS to clock delay isn't being correctly implemented#asahi-dev · 2021-12-10 14:19
marcanfor spi1 it would be 200M, yes#asahi-dev · 2021-12-10 14:19
marcanah yes#asahi-dev · 2021-12-10 14:18
marcanno, 24MHz / CLKDIV