#
✕ nick:marcan
#asahi-dev · 2021-12-22 20:04
marcanrusty-nail[m]: wifi is not done on T2
#asahi-dev · 2021-12-22 11:02
marcanmaz: if that hifive approach sounds good to you, I'll go with that then (plus something for timings)
#asahi-dev · 2021-12-22 11:01
marcansven: yeah, I'll merge it in once I'm done with this T2 mess
#asahi-dev · 2021-12-21 19:21
marcanwell, debugfs I guess
#asahi-dev · 2021-12-21 19:21
marcanwe're definitely going to have a sysfs interface with all the keys for experiments/debug anyway
#asahi-dev · 2021-12-21 19:20
marcanand also we can just read-probe
#asahi-dev · 2021-12-21 19:20
marcanindeed
#asahi-dev · 2021-12-21 19:18
marcanI guess the general driver model would be the same in both cases, it mostly just changes how the subdrivers are instantiated, so it wouldn't be too hard to make the call a bit later
#asahi-dev · 2021-12-21 19:17
marcanif we need to start specifying per-platform props it starts making sense to break it apart like that
#asahi-dev · 2021-12-21 19:17
marcanI guess part of the question is whether we can autodetect ~everything or whether we're going to need DT props at some point
#asahi-dev · 2021-12-21 19:16
marcansome of them would provide DT services, e.g. gpio would be a gpio provider
#asahi-dev · 2021-12-21 19:15
marcan(which is what applesmc.c does on intel systems...)
#asahi-dev · 2021-12-21 19:15
marcanan alternative way would be to ditch all the explicit description in the DT and just have one monolithic driver attempt to autoprobe everything...
#asahi-dev · 2021-12-21 19:14
marcanI think this makes sense because it lets us use the compatible mechanism to identify SMC features/quirks across devices (and makes it more reusable), and allows for obvious things like "the mac mini does not have a battery so does not instantiate that driver"
#asahi-dev · 2021-12-21 19:13
marcanthe parent node would not be a simple-bus derivative; the driver there would be in charge of probing child nodes
#asahi-dev · 2021-12-21 19:13
marcantl;dr one parent node that implements a key/value interface, then a bunch of child nodes each bound by a subdriver that implements a given feature (gpio, battery, hwmon, etc)
#asahi-dev · 2021-12-21 19:12
marcanrobher: would be nice to hear your opinion on the general idea for the bindings before I start writing it that way
#asahi-dev · 2021-12-21 19:11
marcanI'll poke around some more
#asahi-dev · 2021-12-21 19:11
marcanand obviously corellium are not, er, something to reference for correctness :p
#asahi-dev · 2021-12-21 19:11
marcankettenis: there's that really weird read behavior, yeah
#asahi-dev · 2021-12-21 19:11
marcanoops, that wasn't dead yet :)
#asahi-dev · 2021-12-21 19:10
marcan~.
#asahi-dev · 2021-12-21 19:06
marcangiven this needs to come up before the root port does link training, since we don't do hotplug yet...
#asahi-dev · 2021-12-21 19:06
marcan(or maybe there's something already?)
#asahi-dev · 2021-12-21 19:06
marcanmaybe maz has an opinion there?
#asahi-dev · 2021-12-21 19:05
marcanyes, I was wondering about that
#asahi-dev · 2021-12-21 19:05
marcan*side
#asahi-dev · 2021-12-21 19:05
marcanah, you mean on the other wis
#asahi-dev · 2021-12-21 19:05
marcankettenis: I'm thinking smc would be a parent node with subnodes for individual features, then one of those would just be a standard gpio controller
#asahi-dev · 2021-12-21 15:48
marcangreat!
#asahi-dev · 2021-12-21 15:32
marcanGlanzmann: if you aren't doing development, please move to #asahi
#asahi-dev · 2021-12-21 11:31
marcan(for those not reading #asahi, pushed the wifi stuff to wifi/take1)
#asahi-dev · 2021-12-21 10:51
marcan:)
#asahi-dev · 2021-12-21 10:48
marcanyou can always just chainload :p
#asahi-dev · 2021-12-21 10:45
marcanmaz: done
#asahi-dev · 2021-12-21 10:43
marcanyeah, I suspected such
#asahi-dev · 2021-12-21 10:42
marcanchange that to reg_clr, it should be compliant then
#asahi-dev · 2021-12-21 10:42
marcanmaz: https://github.com/AsahiLinux/m1n1/blob/main/src/chickens.c#L41
#asahi-dev · 2021-12-21 10:42
marcanit came along with the macOS chicken bits, since it uses it
#asahi-dev · 2021-12-21 10:41
marcanI'm not sure why they have it
#asahi-dev · 2021-12-21 10:40
marcanwe can turn off that SMC behavior in m1n1
#asahi-dev · 2021-12-21 10:40
marcanmaz: that is a configurable cpu chicken bit
#asahi-dev · 2021-12-21 08:42
marcanthe actual country the device was sold in, if that's anywhere...
#asahi-dev · 2021-12-21 08:03
marcanbut then... where does the real country code come from?
#asahi-dev · 2021-12-21 08:02
marcanso I wonder if it's in there somehow?
#asahi-dev · 2021-12-21 08:02
marcanbecause that comes from the wifi module
#asahi-dev · 2021-12-21 08:02
marcanthat's runtime info, but the CountryCode thing is suspicious
#asahi-dev · 2021-12-21 07:57
marcanand yeah, I'll do that a bit later this week
#asahi-dev · 2021-12-21 07:57
marcanRedecorating[m]: ah it was you, lol, sorry
#asahi-dev · 2021-12-21 07:56
marcanthe remaining question is the antenna SKU

plus ›