#
✕ nick:marcan
#asahi-dev · 2021-12-25 17:45
marcanI called the props apple,module-instance; apple,antenna-sku; brcm,cal-blob (the idea being that the cal blob isn't really apple-specific in nature, though chances are only they use that mechanism, while the other two are related to the funky Apple firmware selection and are definitely Apple-specific)
#asahi-dev · 2021-12-25 17:44
marcan(well, needs DT bindings as usual :p)
#asahi-dev · 2021-12-25 17:42
marcanthe T2 folks have managed to test take4 on all the chips I added support for, so I think this is reasonably in shape for an upstream RFC
#asahi-dev · 2021-12-25 17:41
marcankettenis: pushed wifi/take5 with the TxCap and calibration blob stuff (goes along with a m1n1 patch and a firmware extractor patch)
#asahi-dev · 2021-12-25 11:12
marcanmight as well add those two patches to the initial submission
#asahi-dev · 2021-12-25 11:12
marcankettenis: the txcap stuff needs a minor refactor of one patch and isn't much on top; the calibration isn't much more either
#asahi-dev · 2021-12-25 10:43
marcan... this clearly was intended to do things the Apple Way at some point, then they censored it before releasing...
#asahi-dev · 2021-12-25 10:43
marcanthere's also references to txcap which are stubbed out
#asahi-dev · 2021-12-25 10:43
marcanthat's not actually defined nor used
#asahi-dev · 2021-12-25 10:43
marcan char *clm_path, char *txcap_path);
#asahi-dev · 2021-12-25 10:43
marcanextern int dhdpcie_get_fwpath_otp(dhd_bus_t *bus, char *fw_path, char *nv_path,
#asahi-dev · 2021-12-25 10:43
marcanheh, I just found this in that broadcom android driver
#asahi-dev · 2021-12-25 10:38
marcanalso, we need to forward the wifi calibration blob from ADT to DT; I just realized what that is, it's the calibration that's in SROM on x86 machines, so again presumably it matters
#asahi-dev · 2021-12-25 10:38
marcannot entirely sure what they do, but it sounds important :p
#asahi-dev · 2021-12-25 10:38
marcanalso I just pushed a change to the firmware extractor to also copy txcap_blob files; they are not used yet but will be soon
#asahi-dev · 2021-12-25 10:37
marcanah, cool
#asahi-dev · 2021-12-24 18:05
marcanjannau: j314c issue was a regression from the T2 stuff; pushed take4 to fix that
#asahi-dev · 2021-12-24 18:05
marcanjannau: looks like I have to update my AP (which I haven't since the UniFi mess) and create a WPA3 network.. :-)
#asahi-dev · 2021-12-23 14:49
marcanat least in cases where there is no boardrev so a default gets added, and nothing else removed
#asahi-dev · 2021-12-23 14:48
marcanbut AFAICT that would've been possible
#asahi-dev · 2021-12-23 14:48
marcanI assume linux wasn't actually overflowing since otherwise people would've noticed
#asahi-dev · 2021-12-23 14:47
marcan(it wasn't allocating extra space for additional appended props, so if there wasn't enough space saved from comment/junk removal... that would overflow heap)
#asahi-dev · 2021-12-23 14:47
marcan(which also had a potential buffer overflow which I just fixed as part of these changes... so yeah)
#asahi-dev · 2021-12-23 14:46
marcanincluding removing certain other vars
#asahi-dev · 2021-12-23 14:46
marcanwell, linux already has an nvram parser doing other nonsense
#asahi-dev · 2021-12-23 14:46
marcanbut it doesn't matter any more
#asahi-dev · 2021-12-23 14:46
marcanyeah, I made the linux code properly remove any existing such lines first :p
#asahi-dev · 2021-12-23 14:46
marcanso now I only add it (or replace it if it's already there) iff the platform has a MAC set
#asahi-dev · 2021-12-23 14:45
marcanoriginally I thought it would be easier to just have a default and use the standard firmware set MAC call in a generic way, but I realized today that having a macaddr= unconditionally in nvram overrides the SROM MAC for cards which do have it
#asahi-dev · 2021-12-23 14:44
marcanlinux now appends the macaddr= itself on M1s
#asahi-dev · 2021-12-23 14:44
marcan(since I realized it overrides SROM for T2s)
#asahi-dev · 2021-12-23 14:44
marcanI just removed it
#asahi-dev · 2021-12-23 14:44
marcankettenis: not any more
#asahi-dev · 2021-12-23 14:40
marcanI guess it's not your driver then :p
#asahi-dev · 2021-12-23 14:40
marcanso yeah, looks pretty terrible
#asahi-dev · 2021-12-23 14:40
marcansven: fwiw, since I happen to be on a T2 too, changing size to 100M (I only have the EFI partition mountable here): Jobs: 1 (f=1): [w(1)][2.7%][w=108KiB/s][w=27 IOPS][eta 10m:45s]
#asahi-dev · 2021-12-23 12:16
marcanah, works for me now, apparently
#asahi-dev · 2021-12-23 11:43
marcanit's probably some dumb networkmanager thing I have
#asahi-dev · 2021-12-23 11:43
marcanawesome :)
#asahi-dev · 2021-12-23 10:59
marcanso maybe there's something else to do, but at least it should get the right firmware/config and boot the card
#asahi-dev · 2021-12-23 10:58
marcanI don't actually seem to be able to see any networks in NetworkManager, not sure if that's PEBKAC or something else (it does do scans and returns SSDIs, including some cached ones?)
#asahi-dev · 2021-12-23 10:58
marcanRedecorating[m]: ^
#asahi-dev · 2021-12-23 10:58
marcanjust pushed wifi/take2 with, hopefully, support for all the T2 macs
#asahi-dev · 2021-12-23 10:57
marcanbut at least it'd feel silly not to fix the wifi situation while I'm here
#asahi-dev · 2021-12-23 10:57
marcanmjg59: I had to blacklist two drivers since they were misbehaving badly, and there's still no VHCI driver so no keyboard/touchpad... so clearly there is a ways to go :(
#asahi-dev · 2021-12-23 09:54
marcanseems we unfortunately ended up with the same test machine :p
#asahi-dev · 2021-12-23 09:54
marcanand this is bali u X3 :-)
#asahi-dev · 2021-12-23 09:54
marcanit's not an EFI variable
#asahi-dev · 2021-12-23 09:52
marcanas in ACPI NVS, not wifi NVRAM
#asahi-dev · 2021-12-23 09:52
marcanthat takes it from NVRAM, so that makes sense

plus ›