#
✕ nick:marcan
#asahi-dev · 2022-03-02 14:37
marcanhonestly, re: code, I'd rather you just outright copy stuff if you want and follow the license (which isn't hard) :)
#asahi-dev · 2022-03-02 14:37
marcanbut we try to license everything worth copying as MIT anyway
#asahi-dev · 2022-03-02 14:37
marcanlooking at driver code of course comes with the usual cleanroom caveat, i.e. if you think you might accidentally copy something copyrightable, then you should follow the license
#asahi-dev · 2022-03-02 14:36
marcanfacts aren't copyrightable, so you don't even have to ask that question :-)
#asahi-dev · 2022-03-02 14:35
marcanyou mean like hardware docs and such, not copying anything verbatim?
#asahi-dev · 2022-03-02 14:34
marcanwhat do you mean by use information?
#asahi-dev · 2022-03-02 14:28
marcanof course we could cheat by chaining them all, but that's... not great :/
#asahi-dev · 2022-03-02 14:28
marcankettenis: https://github.com/AsahiLinux/linux/commit/b7f2c99a9de07d20507e0393c4f3184bbfdb13ce
#asahi-dev · 2022-03-02 14:27
marcanthere's more than one leaf
#asahi-dev · 2022-03-02 14:26
marcanso that doesn't work
#asahi-dev · 2022-03-02 14:26
marcankettenis: it's *two* depending domains on t6000
#asahi-dev · 2022-03-02 13:50
marcanwhich means loading nvme as a module fails since by then pmgr has shut things down
#asahi-dev · 2022-03-02 13:50
marcankettenis: the apcie_st nodes do truly depend on ANS2 in hardware; they refuse to come up without it
#asahi-dev · 2022-03-02 13:02
marcanyeah, it doesn't :(
#asahi-dev · 2022-03-02 12:59
marcanthough I still need to double check that ANS2 doesn't just manage these itself
#asahi-dev · 2022-03-02 12:59
marcankettenis: does u-boot support multiple PDs for a single device? because it looks like we're going to need that for ans... :(
#asahi-dev · 2022-03-02 12:58
marcangoing to grab some dinner and then fix this power domain stuff
#asahi-dev · 2022-03-02 12:54
marcanso I guess now I wait for a human :)
#asahi-dev · 2022-03-02 12:54
marcandone, apparently it opens a ticket after asking you for the info
#asahi-dev · 2022-03-02 12:52
marcanI'll ask the chatbot, see what happens
#asahi-dev · 2022-03-02 12:51
marcanI don't even use the master branch in our linux repo
#asahi-dev · 2022-03-02 12:51
marcanyeah, you'd want to rebase asahi when you do that anyway, which you'd be doing via the cli
#asahi-dev · 2022-03-02 12:43
marcan(would be nice if GH had a setting to control this independently, but it seems they don't...)
#asahi-dev · 2022-03-02 12:43
marcan(I'm talking about the 'forked from u-boot/u-boot' at the top of the repo, which apparently makes PRs default to going to that repo)
#asahi-dev · 2022-03-02 12:41
marcanI guess GH-tied forks only make sense for projects that actually take GH PRs...
#asahi-dev · 2022-03-02 12:41
marcanif you're okay with that, I'll try the second route (apparently there's a chatbot? wonder if it's automated...)
#asahi-dev · 2022-03-02 12:41
marcankettenis: apparently PRs default to upstream uboot since ours is a fork. we could re-create the repo, or apparently GH support can just fix it for us; either way I think it's preferable if the fork relationship is removed, since otherwise we might open PRs against upstream. does that make sense?
#asahi-dev · 2022-03-02 12:11
marcan(and just open PRs)
#asahi-dev · 2022-03-02 12:11
marcankettenis: it's easier not to clash if we use separate branches, so I can leave you in charge of asahi if you want
#asahi-dev · 2022-03-02 12:10
marcansven: also the shutdown field being set implies iBoot is doing this too
#asahi-dev · 2022-03-02 12:09
marcando you mind if I push straight to asahi in u-boot? or would you rather I run things through you?
#asahi-dev · 2022-03-02 12:08
marcankettenis: I'll make it do the same thing m1n1 does now at least
#asahi-dev · 2022-03-02 12:07
marcansven: so, good chance this fixed it
#asahi-dev · 2022-03-02 12:05
marcanneed to give it more time
#asahi-dev · 2022-03-02 12:05
marcanactually this timed out, heh
#asahi-dev · 2022-03-02 12:04
marcanu-boot should probably also do this then
#asahi-dev · 2022-03-02 12:04
marcanok, confirmed that the shutdown process at least blocks on the GC rebuild properly
#asahi-dev · 2022-03-02 12:03
marcanand apparently it's transition-sensitive, so it was doing nothing
#asahi-dev · 2022-03-02 12:03
marcanon init
#asahi-dev · 2022-03-02 12:03
marcantook a while to realize we weren't *clearing* the shutdown field
#asahi-dev · 2022-03-02 12:03
marcanok, that works
#asahi-dev · 2022-03-02 12:03
marcanTTY> rtkit(nvme): syslog: [cmd.c:7717]seg->lba 0 saveCtx 1 took 126 ms
#asahi-dev · 2022-03-02 12:03
marcanTTY> rtkit(nvme): syslog: [cmd.c:7704]NVMe shutdown start seg->lba: 0, seg->size: 0
#asahi-dev · 2022-03-02 11:44
marcanaand now I just can't repro
#asahi-dev · 2022-03-02 11:34
marcanthe interesting thing is iBoot doesn't trigger this rebuild at all, which means it's probably booting in some kind of read-only mode?
#asahi-dev · 2022-03-02 11:33
marcanyeah, I already added that
#asahi-dev · 2022-03-02 11:33
marcanand it works without delay if the last shutdown was clean
#asahi-dev · 2022-03-02 11:32
marcancall it another ANS bug? :/
#asahi-dev · 2022-03-02 11:31
marcanI think it explodes if I try to shut it down before the "GC Search bitmap" rebuild is done
#asahi-dev · 2022-03-02 11:31
marcanif I wait before shutdown it works

plus ›