#
✕ nick:jmr2
#asahi-dev · 2021-10-18 23:07
jmr2*greed
#asahi-dev · 2021-10-18 23:07
jmr2So why didn't you have the handler for D117 previously? Is it this handler that fixed that geen flash for you ?
#asahi-dev · 2021-10-18 23:05
jmr2So I see a con, and no pro.
#asahi-dev · 2021-10-18 23:04
jmr2( and I don't see what we gain in shutting down the screen anyway)
#asahi-dev · 2021-10-18 23:04
jmr2My point is that nothing stays perfect forever. If for any reason, the shutdown code does't work, the user should be able to see that the shutdown didn't happen. Currently, there's no way to see it.
#asahi-dev · 2021-10-18 22:51
jmr2Thanks. It's your code, so your call, but I really think that should be like that for everyone. Otherwise, something goes wrong, put computer in bag, come back to a dead battery, customer not happy.
#asahi-dev · 2021-10-18 22:47
jmr2Understood. But I'd rather have the screen stays on if the computer isn't truly shutting down, so I know it's not off. And once the real shutdown is implemented, it won't matter if the display gets turned off before.
#asahi-dev · 2021-10-18 22:33
jmr2... because when I press power for 10s, I still get my monitor to flash "no signal", like it does for both NOP and no handler.
#asahi-dev · 2021-10-18 22:32
jmr2alyssa: looks like FALSE on D117 turns off both the display and the backlight, but not the computer.
#asahi-dev · 2021-10-18 22:24
jmr2Oh crap... OK, retrying...
#asahi-dev · 2021-10-18 22:23
jmr2Oh, and for completeness: I just tried NOP'ing D117 - the one I see as the last line before "system halted" when shutting down. It turns off the display, but the backlight (and I assume, the rest of the computer) stays on. Probably better to leave that one untouched for now. Again, same on 11.4 and 11.5.2.
#asahi-dev · 2021-10-18 22:05
jmr2alyssa: confirmed - 0x0 works too, on both 11.4 and 11.5.2.
#asahi-dev · 2021-10-18 21:07
jmr2weston also starts successfully.
#asahi-dev · 2021-10-18 21:06
jmr2dmesg from the 11.4 stub, but it also boots successfully with the 11.5.2 one
#asahi-dev · 2021-10-18 21:06
jmr2alyssa: here you go: http://paste.debian.net/plainh/efdca4b9 http://paste.debian.net/plainh/155be3dc