#
✕ nick:jannau
#asahi-dev · 2021-12-16 09:48
jannautouchpad coordinates are rounded away from zero to the next multiple of 100, I should have added the measured values as comment
#asahi-dev · 2021-12-16 09:47
jannaukettenis: I see that as well. message payload "e0 10 00 00 00". which doubles the type (ignoring endianess)
#asahi-dev · 2021-12-16 00:43
jannaufixed all report from kernel test robot
#asahi-dev · 2021-12-16 00:42
jannauextended report mode is only switched on by request from hid-magicmouse, I added resolution for X and Y based on the j314 trackpad, no idea if the other ones have other dimensions
#asahi-dev · 2021-12-16 00:39
jannauhid-appleft is no more, suppport is integrated in hid-magicmouse
#asahi-dev · 2021-12-16 00:38
jannaumarcan: just updated https://github.com/jannau/linux/tree/dev/spi-hid-apple
#asahi-dev · 2021-12-15 13:16
jannautouchpad dimensions are would be useful to set the resolution of X and Y
#asahi-dev · 2021-12-15 13:03
jannauwe probably want the IDs in the DT though
#asahi-dev · 2021-12-15 13:03
jannauI was thinking of just apple's target-type as device id
#asahi-dev · 2021-12-15 13:01
jannauwe probably want at least a different device id for the macbook pro 13"
#asahi-dev · 2021-12-15 13:00
jannauI invented or reused USB device ids
#asahi-dev · 2021-12-15 12:48
jannaukettenis: have you already written dt-bindings for the hid transport?
#asahi-dev · 2021-12-15 12:47
jannauI can do that along with finishing the linux drivers
#asahi-dev · 2021-12-15 12:46
jannausomeone has to translate kblang-calibration from the ADT into a DT property
#asahi-dev · 2021-12-15 12:44
jannaukettenis: none so I'ld guess ascii. using USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2021 with hid-apple. That has an incorrect Fn key mapping
#asahi-dev · 2021-12-15 09:04
jannaucopied from the integrated quirk for applespi
#asahi-dev · 2021-12-15 09:02
jannauAttrPalmSizeThreshold=1600
#asahi-dev · 2021-12-15 09:02
jannaumarcan: https://gist.github.com/jannau/8d6fb76397daf7884eef2c1139d4c006
#asahi-dev · 2021-12-15 08:55
jannaumaybe a scaling problem: libinput thinks the trackpad is 69x50mm while it is more like 130x80
#asahi-dev · 2021-12-15 08:51
jannauah, and I wondered why applespi doesn't report pressure. maybe libinput ignores events with low pressure values
#asahi-dev · 2021-12-15 08:47
jannaumarcan: libinput has quirks for applespi / apple touch pads which are not applied for hid-appleft
#asahi-dev · 2021-12-15 08:23
jannau2/3 finger clicks are not working
#asahi-dev · 2021-12-15 08:22
jannauI force pushed some minor changes, I still see occasionally jumps but 2 finger scrolling feels better
#asahi-dev · 2021-12-15 08:13
jannau`libinput debug-events` doesn't semm to get all events either
#asahi-dev · 2021-12-15 08:05
jannauwayland but I assume it's all libinput anyway
#asahi-dev · 2021-12-15 08:04
jannautwo finger scrolling seems to work better when the two fingers are further apart
#asahi-dev · 2021-12-15 08:02
jannauI'm not surprised that !CONFIG_PM_SLEEP is broken
#asahi-dev · 2021-12-15 07:59
jannauoutput reports are not yet implemented, hid-apple doesn't seem to use them with the current keyboard id though
#asahi-dev · 2021-12-15 07:21
jannauI did not start that way
#asahi-dev · 2021-12-15 07:21
jannaubut looking at hte end result of hid-appleft.c it should clearly live in hid-magicmouse
#asahi-dev · 2021-12-15 07:20
jannaumarcan: magicmouse_raw_event uses the Report IDs to identify the data format though. nothing a little refactoring can't fix
#asahi-dev · 2021-12-15 06:58
jannaumarcan: as far as evtest is concerned yes, I haven't done tests beyond that
#asahi-dev · 2021-12-15 00:36
jannauassuming we can get rid of applespi it will probably result in a negative line count change while supporting more hardware
#asahi-dev · 2021-12-15 00:33
jannauit probably should be integrated back into hid-magicmouse but that needs refactoring first. the report id clashes with MAGIC_TRACKPAD2_USB but both use a different format for the touch contacts
#asahi-dev · 2021-12-15 00:28
jannauhttps://github.com/jannau/linux/commits/dev/spi-hid-apple
#asahi-dev · 2021-12-15 00:26
jannauso I've mixed the three existing drivers for apple trackpads to create the fourth, oops
#asahi-dev · 2021-12-14 00:51
jannaustill in rough WIP state
#asahi-dev · 2021-12-14 00:51
jannaumarcan: https://github.com/jannau/linux/tree/dev/spi-hid-apple keyboard works via hid-apple, mouse via hid-generic
#asahi-dev · 2021-12-14 00:49
jannauso the mouse works via hid-generic, that explains the missing multitouch
#asahi-dev · 2021-12-14 00:31
jannauI was more with the transport driver occupied
#asahi-dev · 2021-12-14 00:30
jannauI shoud have looked at things more carefully instead assuming things when the touchpad started working in multi touch mode
#asahi-dev · 2021-12-14 00:28
jannauunrelentingtech: the ignored bytes at the beginning seem to be HID mouse reports
#asahi-dev · 2021-12-13 20:18
jannauok, the internal one in mt mode produces 78 bytes for one finger iirc
#asahi-dev · 2021-12-13 20:13
jannauunrelentingtech: re usb magic trackpad 2: how large are the hid reports
#asahi-dev · 2021-12-13 09:30
jannauj`ey: currently ~800 lines, still with some stub only omplementations and some debugging code which can be removed
#asahi-dev · 2021-12-13 08:48
jannauJamie[m]1: povik is working on audio in https://github.com/povik/linux/tree/asahi-sound
#asahi-dev · 2021-12-13 08:47
jannaumarcan: not yet, it's still more PoC than proper driver. I'll bring it in testable state tonight
#asahi-dev · 2021-12-12 20:10
jannauit even uses the same payload to switch on multitouch
#asahi-dev · 2021-12-12 20:09
jannauyes
#asahi-dev · 2021-12-12 20:08
jannauunrelentingtech: hid-magicmouse works out of the box with my WIP SPI HID transport driver

plus ›