#
✕ nick:jannau
#asahi-dev · 2022-10-25 05:15
jannaumarcan: the boot framebuffer isn't involved anymore. this is a completely new framebuffer as far as drm and dcp are concerned. writing into the first mapped page fills the first line below the notch as expected
#asahi-dev · 2022-10-24 22:40
jannauno idea where fbcon thinks its framebuffer is
#asahi-dev · 2022-10-24 22:38
jannaulol, fbcon and dcp apparently have conflicting ideas where the framebuffer is. the mapped physical memory in dart-dcp is just back. verified with proxy memsets
#asahi-dev · 2022-10-24 20:45
jannausigh, I see nothing wrong with the notchless framebuffer from fbcon
#asahi-dev · 2022-10-24 19:52
jannauhmm, still broken with 120Hz simpledrm, issue seems to be that the atomic_modeset has no changed flags set if drm debug is to be trusted
#asahi-dev · 2022-10-24 19:42
jannaunot sure yet if fbcon or dcp is to blame for that
#asahi-dev · 2022-10-24 19:42
jannauif dcp offers notchless modes too, fbcon selects 60 Hz since it matches the boot mode (60 Hz is assumed default), this requires a modeset and fails somehow
#asahi-dev · 2022-10-24 19:39
jannaulol, fbcon with dcp works only accidentially on the macbook pro 14/16". due to the notchless framebuffer none of the modes match in size and and it sets the preferred 120Hz mode
#asahi-dev · 2022-10-24 14:25
jannauI wonder how that looks on the 14/16" macbooks pros but I guess most additional powerdraw (if any) there is the the backlight and 120Hz display refresh which we currently do not use
#asahi-dev · 2022-10-24 12:15
jannauI think brightness control requires set_block_dcp() calls (I suspect either calibration or temperature data) and then set property calls with numeric IDs which at least differ betwee m1 (imac) and m1 max (macbook pro 14")
#asahi-dev · 2022-10-24 12:12
jannaumarcan: if you test dcp a t8103 laptop would be a good target to start. the imac comes back from dpms/sleep with minimal brightness. If that happens on m1 air and pro 13" as well we to look into display brightness control
#asahi-dev · 2022-10-24 11:57
jannausven: \o/ any changes in apple_drv / iomfb required?
#asahi-dev · 2022-10-24 11:56
jannaumarcan: notchless modes are missing in dcp, I have code for that but I haven't figured out why it breaks fbcon, results black console but X and wayland compositors are working as expected
#asahi-dev · 2022-10-23 18:19
jannauj`ey: compressed kernels with systemd-boot
#asahi-dev · 2022-10-23 18:18
jannausorry
#asahi-dev · 2022-10-23 18:18
jannaupovik: yes, neverming. I had EFI_ZBOOT enabled causing me using an Image.gz
#asahi-dev · 2022-10-23 17:56
jannaupovik: any idea what could cause "apple-admac 238200000.dma-controller: missing or invalid apple,internal-irq-destination property" on j457
#asahi-dev · 2022-10-23 17:51
jannau
#asahi-dev · 2022-10-23 15:22
jannauI have no problem with the allowed but I don't think it will be an supported config and the boot menu makes it far to easy
#asahi-dev · 2022-10-23 15:13
jannauprevent booting from other nvme ESPs
#asahi-dev · 2022-10-23 15:12
jannauthe better option would be to prevent booting from other ESPs
#asahi-dev · 2022-10-23 15:11
jannauyes, asahi-scripts uses that variable
#asahi-dev · 2022-10-23 15:07
jannauthat didn't work for me, it was still the m1n1 set one although I booted a different partition
#asahi-dev · 2022-10-23 14:59
jannauwhat would be required to have labels for the boot entries
#asahi-dev · 2022-10-23 14:59
jannaukettenis: booting works. any idea how to handle "/chosen/asahi,efi-system-partition"?
#asahi-dev · 2022-10-23 14:12
jannauif you uncomment "#pprint.pprint(self.dcpav_prop[key])" dcpext.py will print the parsed Color/Timing Elements
#asahi-dev · 2022-10-23 14:03
jannauI wonder what those "UnsafeColorElementIDs"
#asahi-dev · 2022-10-23 14:02
jannausee get_color_mode()
#asahi-dev · 2022-10-23 14:02
jannausven: python code parses ColorElements and selects the best scored ID
#asahi-dev · 2022-10-23 13:56
jannaudo you have a macos with the same "monitor"? please look at the parameters for set_digital_out_mode
#asahi-dev · 2022-10-23 13:55
jannaubut judging from your trace it looks like there are no color modes
#asahi-dev · 2022-10-23 13:51
jannauit's in the trace
#asahi-dev · 2022-10-23 13:51
jannau >d[0x0] D124 UnifiedPipeline2::setDCPAVPropEnd(key='ColorElements') = True
#asahi-dev · 2022-10-23 13:51
jannauthe chunks, iirc dcp sends 3 different types of chunks
#asahi-dev · 2022-10-23 13:48
jannauis there a ColorElements dcpav_prop?
#asahi-dev · 2022-10-23 13:45
jannaujust extra logging
#asahi-dev · 2022-10-23 13:44
jannauthe commented line at the end of trace_dcp.py
#asahi-dev · 2022-10-23 13:43
jannauand prints it if uncomment "#pprint.pprint(self.dcpav_prop[key])"
#asahi-dev · 2022-10-23 13:41
jannaupython m1n1.fw.dcp.parse_log dcp.log parses it
#asahi-dev · 2022-10-23 13:40
jannauthe extra tracer logs it and saves it as hex string
#asahi-dev · 2022-10-23 13:39
jannaumaybe it's not an array if it's just a single entry?
#asahi-dev · 2022-10-23 13:27
jannauI should have asked lina for the data the parse stumbles over
#asahi-dev · 2022-10-23 13:26
jannauI think we're just parsing id and score for the color modes and skip other fields. the python parsing code does more
#asahi-dev · 2022-10-23 12:51
jannauhow does the parsing fails? I hope it's not the color mode check I added for lina's capture card / glmark2-drm
#asahi-dev · 2022-10-23 11:15
jannau"New drivers should support default domains and so the detach_dev() op will never be called"
#asahi-dev · 2022-10-23 11:11
jannauon the other hand there seems to be an attach_dev for the default domain after detach
#asahi-dev · 2022-10-23 11:10
jannaudetach_dev doesn't seem to be called at all, even for an explicit iommu_detach_device()
#asahi-dev · 2022-10-23 11:07
jannauonly the active domain can sync to the real L0 table
#asahi-dev · 2022-10-23 11:06
jannauyes, we still need a way to figure out which is the active
#asahi-dev · 2022-10-23 11:03
jannaustill a strange that dma_map_sgtable continues to work. I would have expected errors

plus ›